- User Since
- Oct 20 2017, 4:34 PM (118 w, 2 d)
Wed, Jan 8
Dec 18 2019
This was landed.
Great point! Fixed.
fixup according to Greg's requests
Dec 17 2019
Dec 9 2019
Dec 5 2019
LGTM. Any concerns @clayborg?
Sep 4 2019
Aug 27 2019
Aug 23 2019
Jul 23 2019
Jul 22 2019
Jul 21 2019
Jul 19 2019
Yup! Sorry about that, this was fixed in git commit 474ca495a914fca0e.
Jul 18 2019
So add_llvm_utility exports it's target if LLVM_DISTRIBUTION_COMPONENTS doesn't exist. So I guess the better solution would just be setting that.
@JDevlieghere is this what you had in mind?
Jul 17 2019
Am I guessing correctly that this happens when you installed combined llvm+lldb build, and then try to build lldb standalone against that?
If you want to add the Swift-specific variable too, you could put up a PR for that on swift-lldb.
adjust for beanz comments
You can use CROSS_TOOLCHAIN_FLAGS_<PROJECT_NAME> (in this case CROSS_TOOLCHAIN_FLAGS_LLDB) to pass additional variables to the cross-compiling configure. That seems more appropriate for setting these options instead of hardcoding them in LLDB's CMake.
Jul 16 2019
LGTM! So the other functions (e.g. GetOrCreateDeclContextForUid, GetParentDeclContext etc.) will be also replaced in the future in a corresponding manner?
Was there a proposal or discussion (e.g., a thread on lldb-dev) about making PdbAstBuilder abstract in order to handle other languages? It sounds like a good idea, but I'd like to catch up on any context I may have missed.
I'm pretty sure that this doesn't work for Visual Studio (where you do not have a cross-compiler).