Page MenuHomePhabricator

lanza (Nathan Lanza)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 20 2017, 4:34 PM (153 w, 1 d)

Recent Activity

Thu, Sep 24

lanza added inline comments to D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.
Thu, Sep 24, 5:22 PM · Restricted Project
lanza added a comment to D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.

Fixed and added a test under the REDUNDANCY prefix.

Thu, Sep 24, 5:19 PM · Restricted Project
lanza updated the diff for D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.

Fix duplicate inheritance issue

Thu, Sep 24, 5:17 PM · Restricted Project

Wed, Sep 23

lanza added a comment to D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.

@theraven @rjmccall should be ready for review whenever you guys are ready!

Wed, Sep 23, 11:46 PM · Restricted Project
lanza updated the diff for D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.

Update

Wed, Sep 23, 11:45 PM · Restricted Project

Wed, Sep 16

lanza added a comment to D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.

Hmm, I thought we actually just generated a bogus definition for the protocol when it was forward-declared; really, this is better behavior that I expected. Regardless, I don't think it's worthwhile to diagnose this more strongly than a warning because of the history of not doing so.

Wed, Sep 16, 1:24 PM · Restricted Project

Tue, Sep 8

lanza added a comment to D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.

I don't think it'll actually error out at link time: protocol objects get emitted eagerly on use, cross-module linking is just a code-size optimization. This actually has caused longstanding problems.

Tue, Sep 8, 11:29 PM · Restricted Project
lanza added a comment to D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.

A concern that has come up while rewriting this for the listed concerns is forward declared protocols that are defined as non_runtime.

Tue, Sep 8, 4:06 PM · Restricted Project

Wed, Sep 2

lanza added a comment to D86952: [MIRVRegNamer] MachineInstr StableHashing..

Other than the one comment LGTM.

Wed, Sep 2, 10:44 AM · Restricted Project

Aug 28 2020

lanza abandoned D86331: Fix a cmake failure on Windows when LLVM_ENABLE_TERMINFO is set.

Looks like it, I did this around the same time the patch landed. Thanks!

Aug 28 2020, 10:33 AM · Restricted Project

Aug 20 2020

lanza added a reviewer for D86331: Fix a cmake failure on Windows when LLVM_ENABLE_TERMINFO is set: phosek.
Aug 20 2020, 10:08 PM · Restricted Project
lanza requested review of D86331: Fix a cmake failure on Windows when LLVM_ENABLE_TERMINFO is set.
Aug 20 2020, 10:07 PM · Restricted Project

Aug 19 2020

lanza added a comment to D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods..

This change provides a codegen options flag to clang -fobjc-export-direct-method-wrappers to generate the wrapper functions that begin with the prefix objc_direct_wrapper and are marked as attribute__((alwaysinline)). This way within a link unit the wrapper functions should be inlined away at their call sites, but across a dylib boundary the wrapper call is used.

Aug 19 2020, 9:50 AM · Restricted Project

Aug 11 2020

lanza added a reviewer for D85586: Force Remove Attribute: jmolloy.

Adding jmolloy, he seems to be the original author.

Aug 11 2020, 3:22 PM · Restricted Project

Aug 4 2020

lanza added a comment to D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.

No problem! Thank you, John!

Aug 4 2020, 11:28 AM · Restricted Project

Aug 3 2020

lanza added a comment to D84269: [lldb] Add some example type anotations to python.swig.

Sounds good, just sent out a message to the mailing list.

Aug 3 2020, 3:11 PM · Restricted Project
lanza added a comment to D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.

ping @rjmccall. Any update on a timeline for this review process? Thanks!

Aug 3 2020, 2:12 PM · Restricted Project

Jul 21 2020

Herald added a project to D84269: [lldb] Add some example type anotations to python.swig: Restricted Project.
Jul 21 2020, 1:55 PM · Restricted Project

Apr 30 2020

lanza added a comment to D70885: [lldb] Use explicit lldb commands on tests.

Sorry for bump to this old diff, but I agree with both Jim and Greg -- we shouldn't be importing your ~/.lldbinit, but tests shouldn't depend on there never being another br s. This change should land as breakpoint set.

Apr 30 2020, 5:11 PM · Restricted Project
lanza added a comment to D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.

@rjmccall Hey John, I sent the proposal to the addresses I was pointed to but haven't heard back in multiple weeks. Any update on this?

Apr 30 2020, 5:11 PM · Restricted Project

Apr 14 2020

lanza closed D77106: [cmake] Only set deps for an ExternalProject if the type is executable or library.

Closed by https://reviews.llvm.org/rG7f5fe30a150e7e87d3fbe4da4ab0e76ec38b40b9

Apr 14 2020, 12:24 PM · Restricted Project

Apr 11 2020

lanza added a comment to D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.

If someone writes up a short proposal for this, with motivation and impact, we'd be happy to present it internally.

Apr 11 2020, 10:07 AM · Restricted Project

Apr 1 2020

lanza committed rG7f5fe30a150e: [cmake] Only set deps for an ExternalProject if the type is executable or… (authored by lanza).
[cmake] Only set deps for an ExternalProject if the type is executable or…
Apr 1 2020, 8:42 PM
lanza closed D77284: [cmake] Only set deps for an ExternalProject if the type is executable or library.
Apr 1 2020, 8:42 PM · Restricted Project
lanza created D77284: [cmake] Only set deps for an ExternalProject if the type is executable or library.
Apr 1 2020, 8:42 PM · Restricted Project
lanza updated the diff for D77106: [cmake] Only set deps for an ExternalProject if the type is executable or library.

fix message

Apr 1 2020, 11:49 AM · Restricted Project
lanza added inline comments to D77106: [cmake] Only set deps for an ExternalProject if the type is executable or library.
Apr 1 2020, 11:49 AM · Restricted Project
lanza updated the diff for D77106: [cmake] Only set deps for an ExternalProject if the type is executable or library.

update

Apr 1 2020, 11:49 AM · Restricted Project

Mar 30 2020

lanza added a reviewer for D77106: [cmake] Only set deps for an ExternalProject if the type is executable or library: xiaobai.
Mar 30 2020, 6:02 PM · Restricted Project
lanza added reviewers for D77106: [cmake] Only set deps for an ExternalProject if the type is executable or library: beanz, smeenai.
Mar 30 2020, 6:02 PM · Restricted Project
lanza created D77106: [cmake] Only set deps for an ExternalProject if the type is executable or library.
Mar 30 2020, 5:30 PM · Restricted Project

Mar 25 2020

lanza updated the diff for D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.

Reword commit

Mar 25 2020, 4:49 PM · Restricted Project
lanza updated the diff for D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.

Rename and address some issues

Mar 25 2020, 4:49 PM · Restricted Project

Mar 7 2020

lanza added a comment to D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.

Adding some more knowledgeable reviewers for comments on your RFC. I pointed out a few minor nits, but I'll hold off on a technical review until the ObjC-specific details are worked out and there is buy-in on the feature.

Mar 7 2020, 3:09 PM · Restricted Project

Mar 3 2020

lanza created D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.
Mar 3 2020, 3:00 PM · Restricted Project

Jan 8 2020

lanza abandoned D63526: [NativePDB] Read inc-link thunks from /* LINKER */ module and create symbols.
Jan 8 2020, 1:00 PM

Dec 18 2019

lanza abandoned D64692: [NativePDB] Change GetOrCreateFunctionDecl to private and introduce CreateFunctionDecl.
Dec 18 2019, 4:33 PM
lanza abandoned D64691: [NativePDB] Make GetParentDeclContext return an lldb type.
Dec 18 2019, 4:33 PM
lanza abandoned D64690: [NativePDB] Make GetOrCreateDeclContextForUid return an lldb type.
Dec 18 2019, 4:33 PM
lanza closed D71034: [lldb-vscode] Added support for ‘totalFrames’ field in StackTraces response .

This was landed.

Dec 18 2019, 4:33 PM · Restricted Project
lanza abandoned D64693: [NativePDB] Change GetOrCreateBlockDecl to private and introduce CreateBlockDecl.
Dec 18 2019, 4:33 PM
lanza added a comment to D71633: [lldb-vscode] Only close the debuggers in/out when DAP is over stdin/out.

Great point! Fixed.

Dec 18 2019, 11:26 AM · Restricted Project
lanza updated the diff for D71633: [lldb-vscode] Only close the debuggers in/out when DAP is over stdin/out.

fixup according to Greg's requests

Dec 18 2019, 11:26 AM · Restricted Project

Dec 17 2019

lanza created D71633: [lldb-vscode] Only close the debuggers in/out when DAP is over stdin/out.
Dec 17 2019, 3:34 PM · Restricted Project

Dec 9 2019

lanza committed rG6dad5e441db5: The field ‘totalFrames’ which is total number of frames available, is mandatory… (authored by serhiy.redko).
The field ‘totalFrames’ which is total number of frames available, is mandatory…
Dec 9 2019, 10:53 AM

Dec 5 2019

lanza added a comment to D71034: [lldb-vscode] Added support for ‘totalFrames’ field in StackTraces response .

LGTM. Any concerns @clayborg?

Dec 5 2019, 1:25 PM · Restricted Project

Sep 4 2019

lanza committed rL370978: Request commit access for lanza.
Request commit access for lanza
Sep 4 2019, 1:46 PM

Aug 27 2019

lanza committed rL370106: [Platform/Android] Read the adb server from an env variable if set.
[Platform/Android] Read the adb server from an env variable if set
Aug 27 2019, 1:19 PM
lanza committed rG0c01d920512c: [Platform/Android] Read the adb server from an env variable if set (authored by lanza).
[Platform/Android] Read the adb server from an env variable if set
Aug 27 2019, 1:17 PM
lanza closed D66689: [Platform/Android] Read the adb server from an env variable if set.
Aug 27 2019, 1:14 PM · Restricted Project

Aug 23 2019

lanza created D66689: [Platform/Android] Read the adb server from an env variable if set.
Aug 23 2019, 4:05 PM · Restricted Project

Jul 23 2019

lanza accepted D65155: [lldb] Remove Xcode project legacy.

Not directly related, but there's some other legacy cruft I figure are valid for removal. e.g.

utils/sync-source
misc/grep-svn-log.py
git-svn/convert.py
Jul 23 2019, 9:44 AM · Restricted Project, Restricted Project

Jul 22 2019

lanza added inline comments to D65109: [LLDB] Remove the Xcode project.
Jul 22 2019, 1:26 PM · Restricted Project, Restricted Project

Jul 21 2019

lanza closed D64689: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl.
Jul 21 2019, 1:45 AM
lanza committed rGfe1b8a09113d: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl (authored by lanza).
[NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl
Jul 21 2019, 12:47 AM
lanza committed rL366650: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl.
[NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl
Jul 21 2019, 12:46 AM

Jul 19 2019

lanza added a comment to D64942: [cmake] Only run llvm-codesign if targetting apple on an apple host.

Yup! Sorry about that, this was fixed in git commit 474ca495a914fca0e.

Jul 19 2019, 10:53 AM · Restricted Project

Jul 18 2019

lanza abandoned D64848: Only build lit-cpuid if the target doesn't already exist.

So add_llvm_utility exports it's target if LLVM_DISTRIBUTION_COMPONENTS doesn't exist. So I guess the better solution would just be setting that.

Jul 18 2019, 5:49 PM
lanza committed rGcb30520555da: check for interrupt from fgets on Windows (authored by lanza).
check for interrupt from fgets on Windows
Jul 18 2019, 5:42 PM
lanza closed D64615: check for interrupt from fgets on Windows.
Jul 18 2019, 5:40 PM
lanza committed rL366520: check for interrupt from fgets on Windows.
check for interrupt from fgets on Windows
Jul 18 2019, 5:40 PM
lanza updated the diff for D64615: check for interrupt from fgets on Windows.

rebase

Jul 18 2019, 5:39 PM
lanza committed rG3d9955c869f4: [cmake] Fix typo where a varible was checked for Apple instead of Darwin (authored by lanza).
[cmake] Fix typo where a varible was checked for Apple instead of Darwin
Jul 18 2019, 5:22 PM
lanza committed rL366515: [cmake] Fix typo where a varible was checked for Apple instead of Darwin.
[cmake] Fix typo where a varible was checked for Apple instead of Darwin
Jul 18 2019, 5:21 PM
lanza closed D64965: [cmake] Fix typo where a varible was checked for Apple instead of Darwin.
Jul 18 2019, 5:21 PM · Restricted Project
lanza added a reviewer for D64965: [cmake] Fix typo where a varible was checked for Apple instead of Darwin: JDevlieghere.
Jul 18 2019, 5:19 PM · Restricted Project
lanza created D64965: [cmake] Fix typo where a varible was checked for Apple instead of Darwin.
Jul 18 2019, 5:19 PM · Restricted Project
lanza committed rGc9477949ba85: [cmake] Convert the NATIVE llvm build process to be project agnostic (authored by lanza).
[cmake] Convert the NATIVE llvm build process to be project agnostic
Jul 18 2019, 5:11 PM
lanza closed D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.
Jul 18 2019, 5:11 PM · Restricted Project
lanza committed rL366514: [cmake] Convert the NATIVE llvm build process to be project agnostic.
[cmake] Convert the NATIVE llvm build process to be project agnostic
Jul 18 2019, 5:11 PM
lanza committed rG01eb3ab70c98: [cmake] Update NATIVE build variables to account for standalone changes (authored by lanza).
[cmake] Update NATIVE build variables to account for standalone changes
Jul 18 2019, 4:44 PM
lanza committed rL366513: [cmake] Update NATIVE build variables to account for standalone changes.
[cmake] Update NATIVE build variables to account for standalone changes
Jul 18 2019, 4:40 PM
lanza closed D64959: [cmake] Update NATIVE build variables to account for standalone changes.
Jul 18 2019, 4:40 PM · Restricted Project
lanza added a reviewer for D64959: [cmake] Update NATIVE build variables to account for standalone changes: xiaobai.
Jul 18 2019, 4:10 PM · Restricted Project
lanza created D64959: [cmake] Update NATIVE build variables to account for standalone changes.
Jul 18 2019, 4:09 PM · Restricted Project
lanza committed rG1a81d54c77b0: [cmake] Only run llvm-codesign if targetting apple on an apple host (authored by lanza).
[cmake] Only run llvm-codesign if targetting apple on an apple host
Jul 18 2019, 2:15 PM
lanza committed rL366498: [cmake] Only run llvm-codesign if targetting apple on an apple host.
[cmake] Only run llvm-codesign if targetting apple on an apple host
Jul 18 2019, 2:14 PM
lanza closed D64942: [cmake] Only run llvm-codesign if targetting apple on an apple host.
Jul 18 2019, 2:14 PM · Restricted Project
lanza updated the diff for D64942: [cmake] Only run llvm-codesign if targetting apple on an apple host.

rebase

Jul 18 2019, 2:11 PM · Restricted Project
lanza added reviewers for D64942: [cmake] Only run llvm-codesign if targetting apple on an apple host: JDevlieghere, sgraenitz, xiaobai.
Jul 18 2019, 1:09 PM · Restricted Project
lanza added a comment to D64942: [cmake] Only run llvm-codesign if targetting apple on an apple host.

@JDevlieghere is this what you had in mind?

Jul 18 2019, 1:09 PM · Restricted Project
lanza created D64942: [cmake] Only run llvm-codesign if targetting apple on an apple host.
Jul 18 2019, 1:08 PM · Restricted Project
lanza updated the diff for D64689: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl.

optional

Jul 18 2019, 12:26 AM

Jul 17 2019

lanza added inline comments to D64689: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl.
Jul 17 2019, 11:57 PM
lanza committed rG4f93b8b56f59: Fix typo in programmer's manual cantFile -> cantFail (authored by lanza).
Fix typo in programmer's manual cantFile -> cantFail
Jul 17 2019, 10:28 PM
lanza committed rL366403: Fix typo in programmer's manual cantFile -> cantFail.
Fix typo in programmer's manual cantFile -> cantFail
Jul 17 2019, 10:27 PM
lanza added a reviewer for D64848: Only build lit-cpuid if the target doesn't already exist: xiaobai.
Jul 17 2019, 6:28 PM
lanza committed rGbd3e74c73d96: Only build lldb-tblgen if it's not a current target (authored by lanza).
Only build lldb-tblgen if it's not a current target
Jul 17 2019, 6:28 PM
lanza added a comment to D64848: Only build lit-cpuid if the target doesn't already exist.

Am I guessing correctly that this happens when you installed combined llvm+lldb build, and then try to build lldb standalone against that?

Jul 17 2019, 6:28 PM
lanza committed rL366394: Only build lldb-tblgen if it's not a current target.
Only build lldb-tblgen if it's not a current target
Jul 17 2019, 6:28 PM
lanza closed D64847: Only build lldb-tblgen if it's not a current target.
Jul 17 2019, 6:27 PM
lanza updated the diff for D64847: Only build lldb-tblgen if it's not a current target.

rebase

Jul 17 2019, 6:27 PM
lanza closed D64846: [cmake] Add NATIVE build for cross compiling standalone builds.
Jul 17 2019, 5:24 PM
lanza committed rG0c6ad3d5d19f: [cmake] Add NATIVE build for cross compiling standalone builds (authored by lanza).
[cmake] Add NATIVE build for cross compiling standalone builds
Jul 17 2019, 5:24 PM
lanza committed rL366392: [cmake] Add NATIVE build for cross compiling standalone builds.
[cmake] Add NATIVE build for cross compiling standalone builds
Jul 17 2019, 5:22 PM
lanza updated the diff for D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

typo

Jul 17 2019, 5:05 PM · Restricted Project
lanza updated the diff for D64846: [cmake] Add NATIVE build for cross compiling standalone builds.

typo

Jul 17 2019, 4:40 PM
lanza added a comment to D64846: [cmake] Add NATIVE build for cross compiling standalone builds.

If you want to add the Swift-specific variable too, you could put up a PR for that on swift-lldb.

Jul 17 2019, 4:40 PM
lanza updated the diff for D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

adjust for beanz comments

Jul 17 2019, 3:26 PM · Restricted Project
lanza updated the diff for D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

typo

Jul 17 2019, 3:20 PM · Restricted Project