Page MenuHomePhabricator

lanza (Nathan Lanza)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 20 2017, 4:34 PM (87 w, 4 d)

Recent Activity

Tue, Jun 18

lanza updated the diff for D63526: [NativePDB] Read inc-link thunks from /* LINKER */ module and create symbols.

Fix a test

Tue, Jun 18, 7:22 PM
lanza retitled D63526: [NativePDB] Read inc-link thunks from /* LINKER */ module and create symbols from [PDB] Read inc-link thunks from /* LINKER */ module and create symbols to [NativePDB] Read inc-link thunks from /* LINKER */ module and create symbols.
Tue, Jun 18, 5:53 PM
lanza created D63526: [NativePDB] Read inc-link thunks from /* LINKER */ module and create symbols.
Tue, Jun 18, 4:24 PM

Tue, Jun 4

lanza added a comment to D58678: Improve step over performance by not stopping at branches that are function calls and stepping into and them out of each one.

@clayborg Seems like this still steps into the call if the call is the last instruction in the range. ThreadPlanStepRange::SetNextBranchBreakpoint checks if (last_index - pc_index > 1) before setting the breakpoint. So if last_index == pc_index and pc points to call then the thread plan will resort to single stepping and thus go through all the same machinery. Obviously, this isn't a problem as this just leads to using the same functionality that it used prior to this patch, but you miss out on the optimization you're aiming for.

Tue, Jun 4, 2:54 PM · Restricted Project

Wed, May 29

lanza added a comment to D62547: (lldb-vscode) Evaluate expressions as LLDB commands when in REPL mode..

Yup, clayborg and I talked about the solution I discuss in that request. The hopeful eventual goal is for this communication:

Wed, May 29, 2:58 PM · Restricted Project

Tue, May 28

lanza added a comment to D62547: (lldb-vscode) Evaluate expressions as LLDB commands when in REPL mode..

Any reason why the backtick method is insufficient? I don't like the idea of the behavior of typing q or c being dependent upon the frame you're in.

Tue, May 28, 3:55 PM · Restricted Project

May 16 2019

lanza added a comment to D53753: [Windows] Define generic arguments registers for Windows x64.

So the ABI plugin for Windows x64 seems to be necessary for proper unwinding. (Also, proper parsing of xdata and pdata sections might be necessary, too.) I suspect that this could be related to https://bugs.llvm.org/show_bug.cgi?id=32343, but would need to look more into this.

May 16 2019, 10:46 PM · Restricted Project, Restricted Project

May 15 2019

Herald added a project to D53753: [Windows] Define generic arguments registers for Windows x64: Restricted Project.

@aleksandr.urakov Microsoft's docs state

May 15 2019, 2:27 PM · Restricted Project, Restricted Project

May 7 2019

lanza added a comment to D61476: [WIP] Add command interpreter to lldb-vscode.

So I was looking at something like this, but I don't see a way to access PTYs & VSCode terminal emulators at that level of granularity. The current api (vscode.window.createTerminal) only let's you launch a single process which is automatically attached to the terminal emulator within vscode. There seems to be a proposed API that would offer this control, but it seems that this has been stuck as a proposed API (e.g. not usable for public plugins) for over a year now.

May 7 2019, 2:34 PM

May 2 2019

lanza created D61476: [WIP] Add command interpreter to lldb-vscode.
May 2 2019, 6:57 PM
lanza added reviewers for D61476: [WIP] Add command interpreter to lldb-vscode: clayborg, xiaobai.
May 2 2019, 6:57 PM

Apr 10 2019

lanza abandoned D60434: Add a default for LLVM_CXX_STD in HandleLLVMOptions.
Apr 10 2019, 12:01 PM · Restricted Project

Apr 8 2019

lanza added a reviewer for D60434: Add a default for LLVM_CXX_STD in HandleLLVMOptions: bogner.
Apr 8 2019, 6:32 PM · Restricted Project
lanza created D60434: Add a default for LLVM_CXX_STD in HandleLLVMOptions.
Apr 8 2019, 6:31 PM · Restricted Project

Apr 6 2019

lanza abandoned D60373: test windows arcanist setup.
Apr 6 2019, 9:30 PM
lanza created D60373: test windows arcanist setup.
Apr 6 2019, 7:36 PM
lanza added a comment to D60157: [NativePDB] Add a check for nullptr for a TagTypeNode.

@xiaobai ping, this is a trivial change.

Apr 6 2019, 6:24 PM

Apr 2 2019

lanza updated the summary of D60157: [NativePDB] Add a check for nullptr for a TagTypeNode.
Apr 2 2019, 3:35 PM
lanza created D60157: [NativePDB] Add a check for nullptr for a TagTypeNode.
Apr 2 2019, 3:12 PM
lanza added a comment to D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.
Ok I see what the confusion is now. Unfortunately I was on vacation all of last week so I didn't see the initial round of patches, but now that I have a chance to see what's going on I'm a little concerned about the entire direction.
Apr 2 2019, 3:12 PM

Apr 1 2019

lanza added inline comments to D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.
Apr 1 2019, 6:10 PM
lanza added a comment to D59866: Fork PDBASTParser to a base class and create PDBASTParserClang.

Is the nature of the PDB different enough that it warrants an entirely new implementation? There's a few places where we parse decorated / undecorated names, but in general I would imagine most of the stuff is language agnostic no?

Apr 1 2019, 5:59 PM
lanza added a comment to D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.

Can't you just write a function that, every time you call it, traces the symbol back to its original compile unit (you can get this from the PdbCompilandSymId), get the CompileUnit item, and ask it for its language? The part that seems unnecessary is the cache.

Apr 1 2019, 5:53 PM
lanza added a comment to D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.

@zturner Yup, the target language is Swift. So you can have C, C++ and Swift. I guess an alternative idea would be to just store every symbol that isn't C++ since the majority of them are. I'll check into that.

Apr 1 2019, 3:18 PM

Mar 29 2019

lanza abandoned D60011: If MSVC and cross compiling use CMAKE_NM for gen_exports_msvc.
Mar 29 2019, 4:09 PM · Restricted Project
lanza added a comment to D60011: If MSVC and cross compiling use CMAKE_NM for gen_exports_msvc.

@smeenai sounds good to me!

Mar 29 2019, 4:09 PM · Restricted Project
lanza edited reviewers for D60011: If MSVC and cross compiling use CMAKE_NM for gen_exports_msvc, added: Wallbraker; removed: serge-sans-paille.
Mar 29 2019, 2:24 PM · Restricted Project
lanza added reviewers for D60011: If MSVC and cross compiling use CMAKE_NM for gen_exports_msvc: smeenai, serge-sans-paille.
Mar 29 2019, 2:23 PM · Restricted Project
lanza added a reviewer for D60011: If MSVC and cross compiling use CMAKE_NM for gen_exports_msvc: compnerd.
Mar 29 2019, 1:53 PM · Restricted Project
lanza created D60011: If MSVC and cross compiling use CMAKE_NM for gen_exports_msvc.
Mar 29 2019, 1:53 PM · Restricted Project

Mar 28 2019

lanza updated the diff for D59915: Convert SymbolFilePDB::CompleteType to get the typesystem from the arg.

rebase

Mar 28 2019, 3:20 PM
lanza updated the diff for D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.

update

Mar 28 2019, 3:15 PM
lanza added a comment to D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.

@MaskRay 👍🏼

Mar 28 2019, 3:15 PM

Mar 27 2019

lanza created D59915: Convert SymbolFilePDB::CompleteType to get the typesystem from the arg.
Mar 27 2019, 8:52 PM
lanza added a reviewer for D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes: asmith.
Mar 27 2019, 6:50 PM
lanza added a reviewer for D59866: Fork PDBASTParser to a base class and create PDBASTParserClang: asmith.
Mar 27 2019, 6:50 PM
lanza added a reviewer for D59904: Convert PDBASTParser::GetDCContainingSymbol to be non-clang specific: compnerd.
Mar 27 2019, 6:48 PM
lanza updated the diff for D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.

fix comment

Mar 27 2019, 6:48 PM
lanza updated the diff for D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.

optimize

Mar 27 2019, 6:31 PM
lanza closed D59864: Teach TypeSystem about PDBASTParser.

r357131

Mar 27 2019, 4:43 PM
lanza committed rG50a11863812b: Teach TypeSystem about PDBASTParser (authored by lanza).
Teach TypeSystem about PDBASTParser
Mar 27 2019, 4:02 PM
lanza committed rLLDB357131: Teach TypeSystem about PDBASTParser.
Teach TypeSystem about PDBASTParser
Mar 27 2019, 3:59 PM
lanza committed rL357131: Teach TypeSystem about PDBASTParser.
Teach TypeSystem about PDBASTParser
Mar 27 2019, 3:59 PM
lanza updated the diff for D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.

add default to c++

Mar 27 2019, 3:09 PM
lanza created D59906: Convert PDBASTParser::GetDeclForSymbol to CompilerDecl from clang::Decl.
Mar 27 2019, 3:09 PM
lanza created D59905: Convert PDBASTParser::GetDeclContextForSymbol to non-clang specific.
Mar 27 2019, 3:09 PM
lanza created D59904: Convert PDBASTParser::GetDCContainingSymbol to be non-clang specific.
Mar 27 2019, 3:05 PM
lanza committed rG1a0a24f1104a: Kill unused variable m_tu_decl_up in SymbolFilePDB (authored by lanza).
Kill unused variable m_tu_decl_up in SymbolFilePDB
Mar 27 2019, 12:17 PM
lanza committed rL357113: Kill unused variable m_tu_decl_up in SymbolFilePDB.
Kill unused variable m_tu_decl_up in SymbolFilePDB
Mar 27 2019, 12:17 PM
lanza committed rLLDB357113: Kill unused variable m_tu_decl_up in SymbolFilePDB.
Kill unused variable m_tu_decl_up in SymbolFilePDB
Mar 27 2019, 12:16 PM
lanza closed D59804: Kill unused variable m_tu_decl_up in SymbolFilePDB.
Mar 27 2019, 12:16 PM · Restricted Project
lanza updated the diff for D59804: Kill unused variable m_tu_decl_up in SymbolFilePDB.

rebase

Mar 27 2019, 12:13 PM · Restricted Project

Mar 26 2019

lanza added reviewers for D59866: Fork PDBASTParser to a base class and create PDBASTParserClang: compnerd, zturner.
Mar 26 2019, 10:40 PM
lanza updated the diff for D59866: Fork PDBASTParser to a base class and create PDBASTParserClang.

Fixed some missing =0s

Mar 26 2019, 10:40 PM
lanza created D59866: Fork PDBASTParser to a base class and create PDBASTParserClang.
Mar 26 2019, 10:35 PM
lanza abandoned D59728: [PDB] Refactor PDBASTParser to a base class and add PDBASTParserClang.
Mar 26 2019, 10:35 PM
lanza updated the diff for D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.

clean up

Mar 26 2019, 9:36 PM
lanza abandoned D59865: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.
Mar 26 2019, 9:34 PM
lanza created D59865: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.
Mar 26 2019, 9:33 PM
lanza added reviewers for D59864: Teach TypeSystem about PDBASTParser: compnerd, zturner.
Mar 26 2019, 7:54 PM
lanza updated subscribers of D59864: Teach TypeSystem about PDBASTParser.

@compnerd this is step one of refactoring that much larger diff.

Mar 26 2019, 7:54 PM
lanza created D59864: Teach TypeSystem about PDBASTParser.
Mar 26 2019, 7:54 PM
lanza added reviewers for D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes: compnerd, zturner.
Mar 26 2019, 7:18 PM
lanza created D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.
Mar 26 2019, 7:17 PM
lanza committed rGd0050d1b8bae: Get the lang from the CompileUnit for ParseCompileUnitFunctionForPDBFunc (authored by lanza).
Get the lang from the CompileUnit for ParseCompileUnitFunctionForPDBFunc
Mar 26 2019, 6:25 PM
lanza committed rL357044: Get the lang from the CompileUnit for ParseCompileUnitFunctionForPDBFunc.
Get the lang from the CompileUnit for ParseCompileUnitFunctionForPDBFunc
Mar 26 2019, 6:25 PM
lanza committed rLLDB357044: Get the lang from the CompileUnit for ParseCompileUnitFunctionForPDBFunc.
Get the lang from the CompileUnit for ParseCompileUnitFunctionForPDBFunc
Mar 26 2019, 6:25 PM
lanza closed D59805: Get the lang from the CompileUnit for ParseCompileUnitFunctionForPDBFunc.
Mar 26 2019, 6:24 PM
lanza updated the diff for D59805: Get the lang from the CompileUnit for ParseCompileUnitFunctionForPDBFunc.

land

Mar 26 2019, 6:24 PM
lanza abandoned D59532: Fix a bug where the bitwise-not'ed bitset was accidently being used.
Mar 26 2019, 1:15 PM
lanza added a comment to D59532: Fix a bug where the bitwise-not'ed bitset was accidently being used.

I believe that this is correct. Some events are designed to only be forwarded to one listener. We could allow each broadcaster to define which events are ok to multi-cast, but one of the events that is sensitive to this is the process state listener. One other option would be to use the "target stop-hook add" command to add a command to execute after each public stop? FYI: there are public and private stops when running the program, the events get generated for both, but only public stops get delivered to the listener of the process state change. The target stop-hook command can do something each time we stop in the UI. You could run a custom python command in the target stop-hook that could pass along the info. Not sure what happens when you just switch between threads/frames though without getting a new stop?

Mar 26 2019, 1:15 PM

Mar 25 2019

lanza updated the diff for D59728: [PDB] Refactor PDBASTParser to a base class and add PDBASTParserClang.

clean up

Mar 25 2019, 8:42 PM
lanza updated the diff for D59728: [PDB] Refactor PDBASTParser to a base class and add PDBASTParserClang.

Ask TypeSystem for a PDBParser instead of casting first to ClangASTContext

Mar 25 2019, 6:31 PM
lanza added reviewers for D59805: Get the lang from the CompileUnit for ParseCompileUnitFunctionForPDBFunc: zturner, compnerd.
Mar 25 2019, 5:49 PM
lanza created D59805: Get the lang from the CompileUnit for ParseCompileUnitFunctionForPDBFunc.
Mar 25 2019, 5:47 PM
lanza added reviewers for D59804: Kill unused variable m_tu_decl_up in SymbolFilePDB: rnk, zturner, compnerd.
Mar 25 2019, 5:42 PM · Restricted Project
lanza created D59804: Kill unused variable m_tu_decl_up in SymbolFilePDB.
Mar 25 2019, 5:41 PM · Restricted Project

Mar 22 2019

lanza added a comment to D59532: Fix a bug where the bitwise-not'ed bitset was accidently being used.

@clayborg Actually after going through the implementation, I might have been mistaken. Is the intent of the BroadcasterManager to restrict each Broadcaster to only emit each event to one listener? e.g. this available_bits value is the mask of events that currently aren't being listened to.

Mar 22 2019, 9:24 PM
lanza updated the diff for D59728: [PDB] Refactor PDBASTParser to a base class and add PDBASTParserClang.

clang-format

Mar 22 2019, 5:05 PM
lanza added reviewers for D59728: [PDB] Refactor PDBASTParser to a base class and add PDBASTParserClang: zturner, compnerd.
Mar 22 2019, 4:58 PM
lanza created D59728: [PDB] Refactor PDBASTParser to a base class and add PDBASTParserClang.
Mar 22 2019, 4:57 PM

Mar 19 2019

lanza added a reviewer for D59532: Fix a bug where the bitwise-not'ed bitset was accidently being used: clayborg.
Mar 19 2019, 9:17 PM

Mar 18 2019

lanza created D59532: Fix a bug where the bitwise-not'ed bitset was accidently being used.
Mar 18 2019, 11:47 PM

Mar 11 2019

lanza committed rG0561be6ce490: Add a case in SymbolFile{Native,}PDB::TranslateLanguage for Swift (authored by lanza).
Add a case in SymbolFile{Native,}PDB::TranslateLanguage for Swift
Mar 11 2019, 4:32 PM
lanza closed D59229: Add Swift enumerator value for CodeView::SourceLanguage.
Mar 11 2019, 4:31 PM · Restricted Project
lanza committed rL355883: Add a case in SymbolFile{Native,}PDB::TranslateLanguage for Swift.
Add a case in SymbolFile{Native,}PDB::TranslateLanguage for Swift
Mar 11 2019, 4:30 PM
lanza committed rLLDB355883: Add a case in SymbolFile{Native,}PDB::TranslateLanguage for Swift.
Add a case in SymbolFile{Native,}PDB::TranslateLanguage for Swift
Mar 11 2019, 4:30 PM
lanza closed D59230: Add a case in SymbolFile{Native,}PDB::TranslateLanguage for Swift.
Mar 11 2019, 4:30 PM · Restricted Project
lanza updated the diff for D59230: Add a case in SymbolFile{Native,}PDB::TranslateLanguage for Swift.

rebase

Mar 11 2019, 4:29 PM · Restricted Project
lanza committed rGcc51dc649aba: Add Swift enumerator value for CodeView::SourceLanguage (authored by lanza).
Add Swift enumerator value for CodeView::SourceLanguage
Mar 11 2019, 4:27 PM
lanza committed rL355882: Add Swift enumerator value for CodeView::SourceLanguage.
Add Swift enumerator value for CodeView::SourceLanguage
Mar 11 2019, 4:27 PM
lanza updated the summary of D59230: Add a case in SymbolFile{Native,}PDB::TranslateLanguage for Swift.
Mar 11 2019, 3:18 PM · Restricted Project
lanza abandoned D59231: Add Swift enumerator value for CodeView::SourceLanguage.
Mar 11 2019, 3:18 PM · Restricted Project
lanza updated the diff for D59229: Add Swift enumerator value for CodeView::SourceLanguage.

Add test and fix llvm-readobj printout

Mar 11 2019, 3:17 PM · Restricted Project
lanza updated the diff for D59229: Add Swift enumerator value for CodeView::SourceLanguage.

typo

Mar 11 2019, 2:56 PM · Restricted Project
lanza updated the diff for D59229: Add Swift enumerator value for CodeView::SourceLanguage.

Rewrite switch case to be more grepable

Mar 11 2019, 2:48 PM · Restricted Project
lanza accepted D59231: Add Swift enumerator value for CodeView::SourceLanguage.
Mar 11 2019, 2:48 PM · Restricted Project
lanza created D59231: Add Swift enumerator value for CodeView::SourceLanguage.
Mar 11 2019, 2:48 PM · Restricted Project
lanza created D59230: Add a case in SymbolFile{Native,}PDB::TranslateLanguage for Swift.
Mar 11 2019, 2:20 PM · Restricted Project
lanza closed D58415: Add Swift enumerator value for CodeView::SourceLanguage.
Mar 11 2019, 2:10 PM · Restricted Project