Page MenuHomePhabricator

lanza (Nathan Lanza)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 20 2017, 4:34 PM (103 w, 3 d)

Recent Activity

Sep 4 2019

lanza committed rL370978: Request commit access for lanza.
Request commit access for lanza
Sep 4 2019, 1:46 PM

Aug 27 2019

lanza committed rL370106: [Platform/Android] Read the adb server from an env variable if set.
[Platform/Android] Read the adb server from an env variable if set
Aug 27 2019, 1:19 PM
lanza committed rG0c01d920512c: [Platform/Android] Read the adb server from an env variable if set (authored by lanza).
[Platform/Android] Read the adb server from an env variable if set
Aug 27 2019, 1:17 PM
lanza closed D66689: [Platform/Android] Read the adb server from an env variable if set.
Aug 27 2019, 1:14 PM · Restricted Project

Aug 23 2019

lanza created D66689: [Platform/Android] Read the adb server from an env variable if set.
Aug 23 2019, 4:05 PM · Restricted Project

Jul 23 2019

lanza accepted D65155: [lldb] Remove Xcode project legacy.

utils/sync-source
misc/grep-svn-log.py

Jul 23 2019, 9:44 AM · Restricted Project, Restricted Project

Jul 22 2019

lanza added inline comments to D65109: [LLDB] Remove the Xcode project.
Jul 22 2019, 1:26 PM · Restricted Project, Restricted Project

Jul 21 2019

lanza closed D64689: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl.
Jul 21 2019, 1:45 AM
lanza committed rGfe1b8a09113d: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl (authored by lanza).
[NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl
Jul 21 2019, 12:47 AM
lanza committed rL366650: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl.
[NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl
Jul 21 2019, 12:46 AM

Jul 19 2019

lanza added a comment to D64942: [cmake] Only run llvm-codesign if targetting apple on an apple host.

Yup! Sorry about that, this was fixed in git commit 474ca495a914fca0e.

Jul 19 2019, 10:53 AM · Restricted Project

Jul 18 2019

lanza abandoned D64848: Only build lit-cpuid if the target doesn't already exist.

So add_llvm_utility exports it's target if LLVM_DISTRIBUTION_COMPONENTS doesn't exist. So I guess the better solution would just be setting that.

Jul 18 2019, 5:49 PM
lanza committed rGcb30520555da: check for interrupt from fgets on Windows (authored by lanza).
check for interrupt from fgets on Windows
Jul 18 2019, 5:42 PM
lanza closed D64615: check for interrupt from fgets on Windows.
Jul 18 2019, 5:40 PM
lanza committed rL366520: check for interrupt from fgets on Windows.
check for interrupt from fgets on Windows
Jul 18 2019, 5:40 PM
lanza updated the diff for D64615: check for interrupt from fgets on Windows.

rebase

Jul 18 2019, 5:39 PM
lanza committed rG3d9955c869f4: [cmake] Fix typo where a varible was checked for Apple instead of Darwin (authored by lanza).
[cmake] Fix typo where a varible was checked for Apple instead of Darwin
Jul 18 2019, 5:22 PM
lanza committed rL366515: [cmake] Fix typo where a varible was checked for Apple instead of Darwin.
[cmake] Fix typo where a varible was checked for Apple instead of Darwin
Jul 18 2019, 5:21 PM
lanza closed D64965: [cmake] Fix typo where a varible was checked for Apple instead of Darwin.
Jul 18 2019, 5:21 PM · Restricted Project
lanza added a reviewer for D64965: [cmake] Fix typo where a varible was checked for Apple instead of Darwin: JDevlieghere.
Jul 18 2019, 5:19 PM · Restricted Project
lanza created D64965: [cmake] Fix typo where a varible was checked for Apple instead of Darwin.
Jul 18 2019, 5:19 PM · Restricted Project
lanza committed rGc9477949ba85: [cmake] Convert the NATIVE llvm build process to be project agnostic (authored by lanza).
[cmake] Convert the NATIVE llvm build process to be project agnostic
Jul 18 2019, 5:11 PM
lanza closed D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.
Jul 18 2019, 5:11 PM · Restricted Project
lanza committed rL366514: [cmake] Convert the NATIVE llvm build process to be project agnostic.
[cmake] Convert the NATIVE llvm build process to be project agnostic
Jul 18 2019, 5:11 PM
lanza committed rG01eb3ab70c98: [cmake] Update NATIVE build variables to account for standalone changes (authored by lanza).
[cmake] Update NATIVE build variables to account for standalone changes
Jul 18 2019, 4:44 PM
lanza committed rL366513: [cmake] Update NATIVE build variables to account for standalone changes.
[cmake] Update NATIVE build variables to account for standalone changes
Jul 18 2019, 4:40 PM
lanza closed D64959: [cmake] Update NATIVE build variables to account for standalone changes.
Jul 18 2019, 4:40 PM · Restricted Project
lanza added a reviewer for D64959: [cmake] Update NATIVE build variables to account for standalone changes: xiaobai.
Jul 18 2019, 4:10 PM · Restricted Project
lanza created D64959: [cmake] Update NATIVE build variables to account for standalone changes.
Jul 18 2019, 4:09 PM · Restricted Project
lanza committed rG1a81d54c77b0: [cmake] Only run llvm-codesign if targetting apple on an apple host (authored by lanza).
[cmake] Only run llvm-codesign if targetting apple on an apple host
Jul 18 2019, 2:15 PM
lanza committed rL366498: [cmake] Only run llvm-codesign if targetting apple on an apple host.
[cmake] Only run llvm-codesign if targetting apple on an apple host
Jul 18 2019, 2:14 PM
lanza closed D64942: [cmake] Only run llvm-codesign if targetting apple on an apple host.
Jul 18 2019, 2:14 PM · Restricted Project
lanza updated the diff for D64942: [cmake] Only run llvm-codesign if targetting apple on an apple host.

rebase

Jul 18 2019, 2:11 PM · Restricted Project
lanza added reviewers for D64942: [cmake] Only run llvm-codesign if targetting apple on an apple host: JDevlieghere, sgraenitz, xiaobai.
Jul 18 2019, 1:09 PM · Restricted Project
lanza added a comment to D64942: [cmake] Only run llvm-codesign if targetting apple on an apple host.

@JDevlieghere is this what you had in mind?

Jul 18 2019, 1:09 PM · Restricted Project
lanza created D64942: [cmake] Only run llvm-codesign if targetting apple on an apple host.
Jul 18 2019, 1:08 PM · Restricted Project
lanza updated the diff for D64689: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl.

optional

Jul 18 2019, 12:26 AM

Jul 17 2019

lanza added inline comments to D64689: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl.
Jul 17 2019, 11:57 PM
lanza committed rG4f93b8b56f59: Fix typo in programmer's manual cantFile -> cantFail (authored by lanza).
Fix typo in programmer's manual cantFile -> cantFail
Jul 17 2019, 10:28 PM
lanza committed rL366403: Fix typo in programmer's manual cantFile -> cantFail.
Fix typo in programmer's manual cantFile -> cantFail
Jul 17 2019, 10:27 PM
lanza added a reviewer for D64848: Only build lit-cpuid if the target doesn't already exist: xiaobai.
Jul 17 2019, 6:28 PM
lanza committed rGbd3e74c73d96: Only build lldb-tblgen if it's not a current target (authored by lanza).
Only build lldb-tblgen if it's not a current target
Jul 17 2019, 6:28 PM
lanza added a comment to D64848: Only build lit-cpuid if the target doesn't already exist.

Am I guessing correctly that this happens when you installed combined llvm+lldb build, and then try to build lldb standalone against that?

Jul 17 2019, 6:28 PM
lanza committed rL366394: Only build lldb-tblgen if it's not a current target.
Only build lldb-tblgen if it's not a current target
Jul 17 2019, 6:28 PM
lanza closed D64847: Only build lldb-tblgen if it's not a current target.
Jul 17 2019, 6:27 PM
lanza updated the diff for D64847: Only build lldb-tblgen if it's not a current target.

rebase

Jul 17 2019, 6:27 PM
lanza closed D64846: [cmake] Add NATIVE build for cross compiling standalone builds.
Jul 17 2019, 5:24 PM
lanza committed rG0c6ad3d5d19f: [cmake] Add NATIVE build for cross compiling standalone builds (authored by lanza).
[cmake] Add NATIVE build for cross compiling standalone builds
Jul 17 2019, 5:24 PM
lanza committed rL366392: [cmake] Add NATIVE build for cross compiling standalone builds.
[cmake] Add NATIVE build for cross compiling standalone builds
Jul 17 2019, 5:22 PM
lanza updated the diff for D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

typo

Jul 17 2019, 5:05 PM · Restricted Project
lanza updated the diff for D64846: [cmake] Add NATIVE build for cross compiling standalone builds.

typo

Jul 17 2019, 4:40 PM
lanza added a comment to D64846: [cmake] Add NATIVE build for cross compiling standalone builds.

If you want to add the Swift-specific variable too, you could put up a PR for that on swift-lldb.

Jul 17 2019, 4:40 PM
lanza updated the diff for D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

adjust for beanz comments

Jul 17 2019, 3:26 PM · Restricted Project
lanza updated the diff for D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

typo

Jul 17 2019, 3:20 PM · Restricted Project
lanza updated the diff for D64846: [cmake] Add NATIVE build for cross compiling standalone builds.

update

Jul 17 2019, 3:20 PM
lanza updated the diff for D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

update

Jul 17 2019, 1:44 PM · Restricted Project
lanza updated the diff for D64846: [cmake] Add NATIVE build for cross compiling standalone builds.

remove swift

Jul 17 2019, 1:44 PM
lanza added a comment to D64846: [cmake] Add NATIVE build for cross compiling standalone builds.

You can use CROSS_TOOLCHAIN_FLAGS_<PROJECT_NAME> (in this case CROSS_TOOLCHAIN_FLAGS_LLDB) to pass additional variables to the cross-compiling configure. That seems more appropriate for setting these options instead of hardcoding them in LLDB's CMake.

Jul 17 2019, 1:44 PM
lanza added a comment to D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

This just seems like it's replacing all instances of LLVM with ${CMAKE_PROJECT_NAME}?

I think it'd be cleaner and more explicit to pass an additional project name parameter to llvm_create_cross_target instead of implicitly using ${CMAKE_PROJECT_NAME}. There's some prior art for that, e.g. in https://reviews.llvm.org/diffusion/L/browse/llvm/trunk/cmake/modules/AddLLVM.cmake;366290$1009?as=source&blame=off

Jul 17 2019, 11:59 AM · Restricted Project
lanza committed rG3b96ebeee473: [NativePDB] Add a FromCompilerDecl for going from lldb -> clang (authored by lanza).
[NativePDB] Add a FromCompilerDecl for going from lldb -> clang
Jul 17 2019, 9:46 AM
lanza committed rL366345: [NativePDB] Add a FromCompilerDecl for going from lldb -> clang.
[NativePDB] Add a FromCompilerDecl for going from lldb -> clang
Jul 17 2019, 9:43 AM
lanza closed D64851: [NativePDB] Add a FromCompilerDecl for going from lldb -> clang.
Jul 17 2019, 9:43 AM · Restricted Project
lanza updated the diff for D64851: [NativePDB] Add a FromCompilerDecl for going from lldb -> clang.

rebase

Jul 17 2019, 9:39 AM · Restricted Project
lanza abandoned D56826: Clean up FindPythonInterp and FindPythonLibs usage.
Jul 17 2019, 12:12 AM
lanza updated the diff for D64689: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl.

update

Jul 17 2019, 12:12 AM
lanza closed D64688: [NativePDB] Make GetTranslationUnitDecl return an lldb CompilerDeclCtx.
Jul 17 2019, 12:12 AM
lanza added inline comments to D64689: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl.
Jul 17 2019, 12:12 AM
lanza committed rG06bf5d853881: [NativePDB] Make GetTranslationUnitDecl return an lldb CompilerDeclCtx (authored by lanza).
[NativePDB] Make GetTranslationUnitDecl return an lldb CompilerDeclCtx
Jul 17 2019, 12:06 AM
lanza committed rL366293: [NativePDB] Make GetTranslationUnitDecl return an lldb CompilerDeclCtx.
[NativePDB] Make GetTranslationUnitDecl return an lldb CompilerDeclCtx
Jul 17 2019, 12:06 AM

Jul 16 2019

lanza added reviewers for D64851: [NativePDB] Add a FromCompilerDecl for going from lldb -> clang: aleksandr.urakov, amccarth.
Jul 16 2019, 11:56 PM · Restricted Project
lanza updated the diff for D64851: [NativePDB] Add a FromCompilerDecl for going from lldb -> clang.

update

Jul 16 2019, 11:55 PM · Restricted Project
lanza updated the diff for D64851: [NativePDB] Add a FromCompilerDecl for going from lldb -> clang.

update

Jul 16 2019, 11:55 PM · Restricted Project
lanza abandoned D64851: [NativePDB] Add a FromCompilerDecl for going from lldb -> clang.
Jul 16 2019, 11:55 PM · Restricted Project
lanza added inline comments to D64688: [NativePDB] Make GetTranslationUnitDecl return an lldb CompilerDeclCtx.
Jul 16 2019, 11:49 PM
lanza updated the diff for D64688: [NativePDB] Make GetTranslationUnitDecl return an lldb CompilerDeclCtx.

update

Jul 16 2019, 11:48 PM
lanza created D64852: [NativePDB] Make GetTranslationUnitDecl return an lldb CompilerDeclCtx.
Jul 16 2019, 11:48 PM
lanza abandoned D64852: [NativePDB] Make GetTranslationUnitDecl return an lldb CompilerDeclCtx.
Jul 16 2019, 11:48 PM
lanza updated the diff for D64851: [NativePDB] Add a FromCompilerDecl for going from lldb -> clang.

fix typo

Jul 16 2019, 11:41 PM · Restricted Project
lanza created D64851: [NativePDB] Add a FromCompilerDecl for going from lldb -> clang.
Jul 16 2019, 11:38 PM · Restricted Project
lanza added a comment to D64689: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl.

LGTM! So the other functions (e.g. GetOrCreateDeclContextForUid, GetParentDeclContext etc.) will be also replaced in the future in a corresponding manner?

Jul 16 2019, 10:04 PM
lanza updated the diff for D64847: Only build lldb-tblgen if it's not a current target.

fix

Jul 16 2019, 9:52 PM
lanza added a comment to D64689: [NativePDB] Make GetOrCreateDeclForUid return an lldb CompilerDecl.

Was there a proposal or discussion (e.g., a thread on lldb-dev) about making PdbAstBuilder abstract in order to handle other languages? It sounds like a good idea, but I'd like to catch up on any context I may have missed.

Jul 16 2019, 9:45 PM
lanza created D64848: Only build lit-cpuid if the target doesn't already exist.
Jul 16 2019, 9:42 PM
lanza created D64847: Only build lldb-tblgen if it's not a current target.
Jul 16 2019, 9:42 PM
lanza updated the diff for D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

format

Jul 16 2019, 8:01 PM · Restricted Project
lanza updated the diff for D64846: [cmake] Add NATIVE build for cross compiling standalone builds.

format

Jul 16 2019, 8:01 PM
lanza added reviewers for D64846: [cmake] Add NATIVE build for cross compiling standalone builds: smeenai, compnerd, beanz.
Jul 16 2019, 7:56 PM
lanza added a comment to D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

I'm pretty sure that this doesn't work for Visual Studio (where you do not have a cross-compiler).

Jul 16 2019, 7:56 PM · Restricted Project
lanza abandoned D64840: [wip] Convert the NATIVE llvm build process to be project agnostic.
Jul 16 2019, 7:53 PM · Restricted Project
lanza retitled D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic from [wip] Convert the NATIVE llvm build process to be project agnostic to [cmake] Convert the NATIVE llvm build process to be project agnostic.
Jul 16 2019, 7:53 PM · Restricted Project
lanza updated the diff for D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

title

Jul 16 2019, 7:51 PM · Restricted Project
lanza created D64846: [cmake] Add NATIVE build for cross compiling standalone builds.
Jul 16 2019, 7:50 PM
lanza updated the diff for D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

update

Jul 16 2019, 7:50 PM · Restricted Project
lanza updated the diff for D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

update

Jul 16 2019, 5:02 PM · Restricted Project
lanza created D64840: [wip] Convert the NATIVE llvm build process to be project agnostic.
Jul 16 2019, 5:00 PM · Restricted Project
lanza committed rG98a48794ecdf: Don't require python exe and lib versions to match while crosscompiling (authored by lanza).
Don't require python exe and lib versions to match while crosscompiling
Jul 16 2019, 4:55 PM
lanza committed rL366285: Don't require python exe and lib versions to match while crosscompiling.
Don't require python exe and lib versions to match while crosscompiling
Jul 16 2019, 4:54 PM
lanza closed D64822: Don't require python exe and lib versions to match while crosscompiling.
Jul 16 2019, 4:54 PM · Restricted Project
lanza committed rGe71679082c0e: add a workaround in GetLine to account for ReadFile not reporintg error (authored by lanza).
add a workaround in GetLine to account for ReadFile not reporintg error
Jul 16 2019, 4:04 PM
lanza committed rL366281: add a workaround in GetLine to account for ReadFile not reporintg error.
add a workaround in GetLine to account for ReadFile not reporintg error
Jul 16 2019, 4:01 PM