- User Since
- Oct 20 2017, 4:34 PM (153 w, 1 d)
Thu, Sep 24
Fixed and added a test under the REDUNDANCY prefix.
Fix duplicate inheritance issue
Wed, Sep 23
Wed, Sep 16
Hmm, I thought we actually just generated a bogus definition for the protocol when it was forward-declared; really, this is better behavior that I expected. Regardless, I don't think it's worthwhile to diagnose this more strongly than a warning because of the history of not doing so.
Tue, Sep 8
I don't think it'll actually error out at link time: protocol objects get emitted eagerly on use, cross-module linking is just a code-size optimization. This actually has caused longstanding problems.
A concern that has come up while rewriting this for the listed concerns is forward declared protocols that are defined as non_runtime.
Wed, Sep 2
Other than the one comment LGTM.
Aug 28 2020
Looks like it, I did this around the same time the patch landed. Thanks!
Aug 20 2020
Aug 19 2020
This change provides a codegen options flag to clang -fobjc-export-direct-method-wrappers to generate the wrapper functions that begin with the prefix objc_direct_wrapper and are marked as attribute__((alwaysinline)). This way within a link unit the wrapper functions should be inlined away at their call sites, but across a dylib boundary the wrapper call is used.
Aug 11 2020
Adding jmolloy, he seems to be the original author.
Aug 4 2020
No problem! Thank you, John!
Aug 3 2020
Sounds good, just sent out a message to the mailing list.
ping @rjmccall. Any update on a timeline for this review process? Thanks!
Jul 21 2020
Apr 30 2020
Sorry for bump to this old diff, but I agree with both Jim and Greg -- we shouldn't be importing your ~/.lldbinit, but tests shouldn't depend on there never being another br s. This change should land as breakpoint set.
@rjmccall Hey John, I sent the proposal to the addresses I was pointed to but haven't heard back in multiple weeks. Any update on this?
Apr 14 2020
Apr 11 2020
If someone writes up a short proposal for this, with motivation and impact, we'd be happy to present it internally.
Apr 1 2020
Mar 30 2020
Mar 25 2020
Rename and address some issues
Mar 7 2020
Adding some more knowledgeable reviewers for comments on your RFC. I pointed out a few minor nits, but I'll hold off on a technical review until the ObjC-specific details are worked out and there is buy-in on the feature.
Mar 3 2020
Jan 8 2020
Dec 18 2019
This was landed.
Great point! Fixed.
fixup according to Greg's requests
Dec 17 2019
Dec 9 2019
Dec 5 2019
LGTM. Any concerns @clayborg?
Sep 4 2019
Aug 27 2019
Aug 23 2019
Jul 23 2019
Not directly related, but there's some other legacy cruft I figure are valid for removal. e.g.
utils/sync-source misc/grep-svn-log.py git-svn/convert.py
Jul 22 2019
Jul 21 2019
Jul 19 2019
Yup! Sorry about that, this was fixed in git commit 474ca495a914fca0e.
Jul 18 2019
So add_llvm_utility exports it's target if LLVM_DISTRIBUTION_COMPONENTS doesn't exist. So I guess the better solution would just be setting that.
@JDevlieghere is this what you had in mind?
Jul 17 2019
Am I guessing correctly that this happens when you installed combined llvm+lldb build, and then try to build lldb standalone against that?
If you want to add the Swift-specific variable too, you could put up a PR for that on swift-lldb.
adjust for beanz comments