- User Since
- Oct 20 2017, 4:34 PM (87 w, 4 d)
Tue, Jun 18
Fix a test
Tue, Jun 4
@clayborg Seems like this still steps into the call if the call is the last instruction in the range. ThreadPlanStepRange::SetNextBranchBreakpoint checks if (last_index - pc_index > 1) before setting the breakpoint. So if last_index == pc_index and pc points to call then the thread plan will resort to single stepping and thus go through all the same machinery. Obviously, this isn't a problem as this just leads to using the same functionality that it used prior to this patch, but you miss out on the optimization you're aiming for.
Wed, May 29
Yup, clayborg and I talked about the solution I discuss in that request. The hopeful eventual goal is for this communication:
Tue, May 28
Any reason why the backtick method is insufficient? I don't like the idea of the behavior of typing q or c being dependent upon the frame you're in.
May 16 2019
So the ABI plugin for Windows x64 seems to be necessary for proper unwinding. (Also, proper parsing of xdata and pdata sections might be necessary, too.) I suspect that this could be related to https://bugs.llvm.org/show_bug.cgi?id=32343, but would need to look more into this.
May 15 2019
@aleksandr.urakov Microsoft's docs state
May 7 2019
So I was looking at something like this, but I don't see a way to access PTYs & VSCode terminal emulators at that level of granularity. The current api (vscode.window.createTerminal) only let's you launch a single process which is automatically attached to the terminal emulator within vscode. There seems to be a proposed API that would offer this control, but it seems that this has been stuck as a proposed API (e.g. not usable for public plugins) for over a year now.
May 2 2019
Apr 10 2019
Apr 8 2019
Apr 6 2019
@xiaobai ping, this is a trivial change.
Apr 2 2019
Ok I see what the confusion is now. Unfortunately I was on vacation all of last week so I didn't see the initial round of patches, but now that I have a chance to see what's going on I'm a little concerned about the entire direction.
Apr 1 2019
Is the nature of the PDB different enough that it warrants an entirely new implementation? There's a few places where we parse decorated / undecorated names, but in general I would imagine most of the stuff is language agnostic no?
Can't you just write a function that, every time you call it, traces the symbol back to its original compile unit (you can get this from the PdbCompilandSymId), get the CompileUnit item, and ask it for its language? The part that seems unnecessary is the cache.
@zturner Yup, the target language is Swift. So you can have C, C++ and Swift. I guess an alternative idea would be to just store every symbol that isn't C++ since the majority of them are. I'll check into that.
Mar 29 2019
@smeenai sounds good to me!
Mar 28 2019
Mar 27 2019
add default to c++
Mar 26 2019
Fixed some missing =0s
@compnerd this is step one of refactoring that much larger diff.
I believe that this is correct. Some events are designed to only be forwarded to one listener. We could allow each broadcaster to define which events are ok to multi-cast, but one of the events that is sensitive to this is the process state listener. One other option would be to use the "target stop-hook add" command to add a command to execute after each public stop? FYI: there are public and private stops when running the program, the events get generated for both, but only public stops get delivered to the listener of the process state change. The target stop-hook command can do something each time we stop in the UI. You could run a custom python command in the target stop-hook that could pass along the info. Not sure what happens when you just switch between threads/frames though without getting a new stop?
Mar 25 2019
Ask TypeSystem for a PDBParser instead of casting first to ClangASTContext
Mar 22 2019
@clayborg Actually after going through the implementation, I might have been mistaken. Is the intent of the BroadcasterManager to restrict each Broadcaster to only emit each event to one listener? e.g. this available_bits value is the mask of events that currently aren't being listened to.
Mar 19 2019
Mar 18 2019
Mar 11 2019
Add test and fix llvm-readobj printout
Rewrite switch case to be more grepable