Page MenuHomePhabricator

[flang][openacc][NFC] Organize clause validity tests by directive
ClosedPublic

Authored by clementval on Jan 24 2021, 7:07 PM.

Details

Summary

Split the tests from acc-clause-validity.f90 in dedicated files by directives.
The file acc-clause-validity.f90 was getting too big to be correctly maintained.
Tests are identical.

Diff Detail

Event Timeline

clementval created this revision.Jan 24 2021, 7:07 PM
clementval requested review of this revision.Jan 24 2021, 7:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2021, 7:07 PM
clementval edited the summary of this revision. (Show Details)Jan 24 2021, 7:08 PM
clementval added a project: Restricted Project.
SouraVX accepted this revision.Jan 26 2021, 6:14 AM

Thanks! LGTM! Same approach I followed in openmp work, keeping test cases short and dedicated for instance (a directive and all it's assoicated clauses). It pays off in diagnosing/modifying when some test case fails(due to 2 branch development).

This revision is now accepted and ready to land.Jan 26 2021, 6:14 AM

Thanks! LGTM! Same approach I followed in openmp work, keeping test cases short and dedicated for instance (a directive and all it's assoicated clauses). It pays off in diagnosing/modifying when some test case fails(due to 2 branch development).

Thanks for the review. Right it was getting too big to maintain it correctly and also lit can parallelize tests so more small tests are better.