The legacy protocol will be removed on trunk after the 12 branch cut,
and gone in clangd 13.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM, a friendly ping to @nridge though, as he was working on theia related stuff (at least in the past, not sure if you still do :D), to give him a heads-up if this is going to require some changes on their end.
Comment Actions
Thanks for the heads up! It would be nice to get D77702 landed before the removal of TheiaSemanticHighlighting. I'll try to find some time to rebase it.
Comment Actions
Good point!
I've revived D77811, as I'd prefer not to start adding modifiers before can make them independent of kinds. (Moving features to different infrastructure tends to involve some backward-compatibility/testing toil...)
From there I think it should be easy to get the rest of this merged:
- scope modifiers make a lot of sense and should be straightforward to add
- dependent type vs name: maybe we should consider making dependent a modifier instead? but otherwise LG
- the "member" issue I think has been resolved for the most part, by clarifying the spec