Page MenuHomePhabricator

[mlir][Linalg] Add missing check to canonicalization of GenericOp that are identity ops.
ClosedPublic

Authored by mravishankar on Jan 15 2021, 12:50 PM.

Details

Summary

The operantion is an identity if the values yielded by the operation
is the argument of the basic block of that operation. Add this missing check.

Diff Detail

Event Timeline

mravishankar created this revision.Jan 15 2021, 12:50 PM
mravishankar requested review of this revision.Jan 15 2021, 12:50 PM
silvas accepted this revision.Jan 15 2021, 12:57 PM

LGTM, but ot sounds like you might want to add some more testing as well. A payload that returns an argument of the enclosing function would be enough.

This revision is now accepted and ready to land.Jan 15 2021, 12:57 PM

LGTM, but ot sounds like you might want to add some more testing as well. A payload that returns an argument of the enclosing function would be enough.

Done