This is an archive of the discontinued LLVM Phabricator instance.

[Attributor][NFC] Make `--allow-unused-prefixes=true` explicit in the tests
AcceptedPublic

Authored by jdoerfert on Jan 14 2021, 8:14 PM.

Details

Summary

This allows us to not warn in update_test_checks if the command
line contains the flag. See discussion here: D93078.

Diff Detail

Event Timeline

jdoerfert created this revision.Jan 14 2021, 8:14 PM
jdoerfert requested review of this revision.Jan 14 2021, 8:14 PM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: bbn. · View Herald Transcript

LGTM, but I only looked at lit.local.cfg.

LGTM, but I only looked at lit.local.cfg.

The rest is the result of replace "FileCheck" "FileCheck --allow-unused-prefixes=true" in the Attributor test folder. I run lit and it seems to be OK.

mtrofin accepted this revision.Jan 14 2021, 8:36 PM
This revision is now accepted and ready to land.Jan 14 2021, 8:36 PM