Page MenuHomePhabricator

[clangd] Extend hints for gRPC and Protobuf CMake config paths
AbandonedPublic

Authored by kbobyrev on Jan 12 2021, 1:53 AM.

Details

Reviewers
sammccall
Summary

Otherwise CMake can't find respective libraries in Ubuntu 20.04 causing our
builds to fail:

https://github.com/clangd/clangd/runs/1678096007

Resolves: https://github.com/clangd/clangd/issues/641

Diff Detail

Event Timeline

kbobyrev created this revision.Jan 12 2021, 1:53 AM
kbobyrev requested review of this revision.Jan 12 2021, 1:53 AM
sammccall accepted this revision.Jan 12 2021, 4:53 AM

(What broke this?)

This revision is now accepted and ready to land.Jan 12 2021, 4:53 AM
kbobyrev abandoned this revision.Jan 13 2021, 11:21 PM

As mentioned offline, this is not the right fix :( The correct one is pushed to our CI.