Page MenuHomePhabricator

Enable python bindings for tensor, shape and linalg dialects.
ClosedPublic

Authored by stellaraccident on Jan 9 2021, 5:16 PM.

Details

Summary
  • We've got significant missing features in order to use most of these effectively (i.e. custom builders, region-based builders).
  • We presently also lack a mechanism for actually registering these dialects but they can be use with contexts that allow unregistered dialects for further prototyping.

Diff Detail

Event Timeline

stellaraccident created this revision.Jan 9 2021, 5:16 PM
stellaraccident requested review of this revision.Jan 9 2021, 5:16 PM
ftynse accepted this revision.Jan 11 2021, 6:03 AM
This revision is now accepted and ready to land.Jan 11 2021, 6:03 AM

Fix dependency issue for generated Linalg ODS.

This revision was landed with ongoing or failed builds.Jan 11 2021, 12:36 PM
This revision was automatically updated to reflect the committed changes.

I think it'd be preferable to write basic smoke tests for the bindings when adding these.

I think it'd be preferable to write basic smoke tests for the bindings when adding these.

+1 especially given that it is python, having a test that it even loads adds some value. How do you square that with the general policy of not testing specific oss generated code?

I think it'd be preferable to write basic smoke tests for the bindings when adding these.

+1 especially given that it is python, having a test that it even loads adds some value. How do you square that with the general policy of not testing specific oss generated code?

s/oss/ods/

We don't need to test completeness: i.e. no need to test every feature from ODS, just basic plumbing here (import and create / round-trip one or two ops), that's why I mentioned "smoke test".
I guess it'll be more useful with the registration aspect sorted out.

We don't need to test completeness: i.e. no need to test every feature from ODS, just basic plumbing here (import and create / round-trip one or two ops), that's why I mentioned "smoke test".
I guess it'll be more useful with the registration aspect sorted out.

I can add it to my list.