This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] [NFC] Add AIX triple to some regression tests
ClosedPublic

Authored by qiucf on Jan 5 2021, 11:58 PM.

Details

Summary

As part of the effort to improve AIX support, regression test coverage misses quite a lot for AIX subtarget. This patch adds AIX triple to those don't need extra change, and we can cover more cases in following commits.

Diff Detail

Event Timeline

qiucf created this revision.Jan 5 2021, 11:58 PM
qiucf requested review of this revision.Jan 5 2021, 11:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2021, 11:58 PM

It surprises to me that you didn't see the difference between LE and AIX, which doesn't make sense to me. Please double confirm to see if there is any conflict when update the test with the script.

qiucf added a comment.Jan 12 2021, 1:44 AM

It surprises to me that you didn't see the difference between LE and AIX, which doesn't make sense to me. Please double confirm to see if there is any conflict when update the test with the script.

I pre-committed a change updating tests marked auto-generated (except those have extra combining/scheduling log check) and rebased this patch. So these cases won't change again after running the script. I plan this patch as first step to improve AIX test coverage, so this includes only cases which don't need extra prefix. And I'll add others in following commits.

steven.zhang accepted this revision.Jan 12 2021, 1:52 AM

Thank you for doing this. LGTM now.

This revision is now accepted and ready to land.Jan 12 2021, 1:52 AM
This revision was automatically updated to reflect the committed changes.