[ELFObjectWriter] emit STT_SECTION symbols for sections

[nickdesaulniers]

Summary

Effectively a revert of r239045 ("Omit unused section symbols from the symbol table.")

By not emitted STT_SECTION symbols for each section, external utilities
that rely on address calculations from these symbols break when moving
from GNU as (via -no-integrated-as) to Clang's integrated assembler.

Particularly, the Linux kernel's objtool utility which is used to
embed custom format unwind info for x86 into the kernel image.

To improve compatibility with GAS, do not intentionally omit these
section symbols.

Increases binary sizes slightly due to additional symbol entries in the
symbol table.

r239045 cites readability of tests as a reason for the optimization. We
can fix that by using -NEXT less aggressively in tests.

Link: https://github.com/ClangBuiltLinux/linux/issues/669
Link: https://github.com/ClangBuiltLinux/linux/issues/872
Link: https://github.com/ClangBuiltLinux/linux/issues/1209

[nickdesaulniers]

TODO: fix failing tests:

• lld/test/ELF/error-handling-script-linux.test
• llvm/test/ExecutionEngine/JITLink/X86/ELF_x86-64_relocations.s

[MaskRay]

I understand that it is a pain for Linux kernel's objtool but r239045 ("Omit unused section symbols from the symbol table.") is a really/really desired enhancement and size optimization.
GNU as's behavior is inferior here. For a -ffunction-sections or -fdata-sections build, there can be many sections. Wasting sizeof(Elf64_Shdr)=64 bytes (STT_SECTION not used by a relocation, which is very common) on each section is really not acceptable.
objtool should take pain and fix whatever issues due to this. I'll happy to defend MC's behavior for any such instance in Linux kernel's mailing lists.

I thought I filed a GNU as feature request but it seems that I haven't (perhaps I just mentioned this on a [e-mail] thread but did not actually file a feature request). I'll file a feature request.

[MaskRay]

Filed GNU as feature request https://sourceware.org/bugzilla/show_bug.cgi?id=27109

[MaskRay]

GNU as (x86/powerpc) has omitted unused STT_SECTION. Some Linux kernel has been worked around for the objtool limitation. This can probably be closed.

lld/test/ELF/icf-safe.s

 # merge with the empty section in the other input file). Here we check that the
 # only two sections merged are the two empty sections and the sections with only
 # STB_LOCAL or STV_HIDDEN symbols. The dynsym entries should have prevented
 # anything else from being merged.
 # EXPORT-NOT: selected section
 # EXPORT: selected section {{.*}}:(.rodata.h3)
 # EXPORT:   removing identical section {{.*}}:(.rodata.h4)
 # EXPORT-NOT: selected section
-# EXPORT: selected section {{.*}}:(.text)
-# EXPORT:   removing identical section {{.*}}:(.text)
-# EXPORT-NOT: selected section
 # EXPORT: selected section {{.*}}:(.rodata.l3)
 # EXPORT:   removing identical section {{.*}}:(.rodata.l4)
 # EXPORT-NOT: selected section
 
 # If --icf=all is specified when exporting we can also merge the exported text
 # sections, but not the exported rodata.
 # ALL-EXPORT-NOT: selected section
 # ALL-EXPORT: selected section {{.*}}:(.text.f3)

lld/test/ELF/lto/thinlto-single-module.ll

 ; RUN: llvm-readelf -S -s single1.o1 | FileCheck %s --check-prefix=MAIN
 ; RUN: not ls single1.o2
 ; RUN: not ls a.out
 
 ; DEFAULT:       Value        Size Type Bind   Vis     Ndx Name
 ; DEFAULT:   0000000000000000    0 FILE LOCAL  DEFAULT ABS ld-temp.o
 ; MAIN:          Value        Size Type Bind   Vis     Ndx Name
 ; MAIN:      0000000000000000    0 FILE LOCAL  DEFAULT ABS thinlto-single-module.ll
+; MAIN-NEXT: 0000000000000000    0 SECTION LOCAL DEFAULT 2 .text
+; MAIN-NEXT: 0000000000000000    0 SECTION LOCAL DEFAULT 3 .text._start
+; MAIN-NEXT: 0000000000000000    0 SECTION LOCAL DEFAULT 4 .note.GNU-stack
 ; MAIN-NEXT: 0000000000000000    3 FUNC GLOBAL DEFAULT   3 _start
 
 ;; --thinlto-single-module=thin.a should result in only thin1.o and thin2.o compiled.
 ; RUN: ld.lld main.o thin.a --thinlto-single-module=thin.a --lto-obj-path=single2.o
 ; RUN: llvm-readelf -S -s single2.o | FileCheck %s --check-prefix=DEFAULT
 ; RUN: llvm-readelf -S -s single2.o1 | FileCheck %s --check-prefix=FOO
 ; RUN: llvm-readelf -S -s single2.o2 | FileCheck %s --check-prefix=BLAH
 ; RUN: not ls single1.o3
 
 ;; Multiple --thinlto-single-module uses should result in a combination of inputs compiled.
 ; RUN: ld.lld main.o thin.a --thinlto-single-module=main.o --thinlto-single-module=thin2.o --lto-obj-path=single4.o
 ; RUN: llvm-readelf -S -s single4.o | FileCheck %s --check-prefix=DEFAULT
 ; RUN: llvm-readelf -S -s single4.o1 | FileCheck %s --check-prefix=MAIN
 ; RUN: llvm-readelf -S -s single4.o2 | FileCheck %s --check-prefix=BLAH
 ; RUN: not ls single4.o3
 
 ; FOO:           Value        Size Type Bind   Vis     Ndx Name
 ; FOO:       0000000000000000    0 FILE LOCAL  DEFAULT ABS thin1.ll
+; FOO-NEXT:  0000000000000000 0 SECTION LOCAL DEFAULT 2 .text
+; FOO-NEXT:  0000000000000000 0 SECTION LOCAL DEFAULT 3 .text.foo
+; FOO-NEXT:  0000000000000000 0 SECTION LOCAL DEFAULT 4 .note.GNU-stack
 ; FOO-NEXT:  0000000000000000    6 FUNC GLOBAL DEFAULT   3 foo
 ; BLAH:          Value        Size Type Bind   Vis     Ndx Name
 ; BLAH:      0000000000000000    0 FILE LOCAL  DEFAULT ABS thin2.ll
+; BLAH-NEXT: 0000000000000000 0 SECTION LOCAL DEFAULT 2 .text
+; BLAH-NEXT: 0000000000000000 0 SECTION LOCAL DEFAULT 3 .text.blah
+; BLAH-NEXT: 0000000000000000 0 SECTION LOCAL DEFAULT 4 .note.GNU-stack
 ; BLAH-NEXT: 0000000000000000    4 FUNC GLOBAL DEFAULT   3 blah
 
 ;; Check only main.o is in the result thin index file.
 ;; Also check a *.thinlto.bc file generated for main.o only.
 ; RUN: ld.lld main.o thin.a --thinlto-single-module=main.o --thinlto-index-only=single5.idx
 ; RUN: ls main.o.thinlto.bc
 ; RUN: ls | FileCheck --implicit-check-not='thin.{{.*}}.thinlto.bc' /dev/null
 ; RUN: FileCheck %s --check-prefix=IDX < single5.idx

llvm/lib/MC/ELFObjectWriter.cpp

if (Symbol.isVariable() && Symbol.isUndefined()) {
     // FIXME: this is here just to diagnose the case of a var = commmon_sym.
     Layout.getBaseSymbol(Symbol);
     return false;
   }
 
   if (Symbol.isTemporary())
     return false;
 
-  if (Symbol.getType() == ELF::STT_SECTION)
-    return false;
-
   return true;
 }
 
 void ELFWriter::computeSymbolTable(
     MCAssembler &Asm, const MCAsmLayout &Layout,
     const SectionIndexMapTy &SectionIndexMap, const RevGroupMapTy &RevGroupMap,
     SectionOffsetsTy &SectionOffsets) {
   MCContext &Ctx = Asm.getContext();

llvm/test/CodeGen/PowerPC/pcrel-tls-general-dynamic.ll

define i32 @GeneralDynamicValueLoad() {
   ; CHECK-O-LABEL: <GeneralDynamicValueLoad>:
   ; CHECK-O:         4c: 00 00 10 06 00 00 60 38       paddi 3, 0, 0, 1
   ; CHECK-O-NEXT:    000000000000004c:  R_PPC64_GOT_TLSGD_PCREL34    x
   ; CHECK-O-NEXT:    54: 01 00 00 48                   bl 0x54
   ; CHECK-O-NEXT:    0000000000000054:  R_PPC64_TLSGD        x
   ; CHECK-O-NEXT:    0000000000000054:  R_PPC64_REL24_NOTOC  __tls_get_addr
   ; CHECK-O-NEXT:    58: 00 00 63 80                   lwz 3, 0(3)
 
-  ; CHECK-SYM-LABEL: Symbol table '.symtab' contains 7 entries
-  ; CHECK-SYM:         6: 0000000000000000     0 TLS     GLOBAL DEFAULT  UND x
+  ; CHECK-SYM-LABEL: Symbol table '.symtab' contains 9 entries
+  ; CHECK-SYM:         8: 0000000000000000     0 TLS     GLOBAL DEFAULT  UND x
   entry:
     %0 = load i32, i32* @x, align 4
     ret i32 %0
 }

llvm/test/CodeGen/PowerPC/pcrel-tls-initial-exec.ll

 ; CHECK-S-NEXT:    blr
 ; CHECK-O-LABEL: <InitialExecValueLoad>:
 ; CHECK-O:         00 00 10 04 00 00 60 e4        pld 3, 0(0), 1
 ; CHECK-O-NEXT:    0000000000000020:  R_PPC64_GOT_TPREL_PCREL34 x
 ; CHECK-O-NEXT:    2e 68 63 7c                    lwzx 3, 3, 13
 ; CHECK-O-NEXT:    0000000000000029:  R_PPC64_TLS x
 ; CHECK-O-NEXT:    20 00 80 4e                    blr
 
-; CHECK-SYM-LABEL: Symbol table '.symtab' contains 6 entries
-; CHECK-SYM:         5: 0000000000000000     0 TLS     GLOBAL DEFAULT  UND x
+; CHECK-SYM-LABEL: Symbol table '.symtab' contains 8 entries
+; CHECK-SYM:         7: 0000000000000000     0 TLS     GLOBAL DEFAULT  UND x
 entry:
   %0 = load i32, i32* @x, align 4
   ret i32 %0
 }

llvm/test/MC/AArch64/size-directive.s

 // CHECK-OBJ:   Name: .size.aarch64_size
 // CHECK-OBJ:   SectionData (
 // CHECK-OBJ-NEXT:   0000: 00000000 00000000 00000000 00000000  |................|
 // CHECK-OBJ-NEXT:   0010: 00000000 0000                        |......|
 // CHECK-OBJ-NEXT: )
 
 // SYMS:      Type   Bind   Vis     Ndx Name
 // SYMS:      NOTYPE LOCAL  DEFAULT   3 $d.0
+// SYMS-NEXT: SECTION LOCAL DEFAULT 2 .text
+// SYMS-NEXT: SECTION LOCAL DEFAULT 3 .size.aarch64_size
 // SYMS-NEXT: FUNC   GLOBAL DEFAULT   3 aarch64_size
 // SYMS-NEXT: NOTYPE GLOBAL DEFAULT UND also_double_word
 // SYMS-NEXT: NOTYPE GLOBAL DEFAULT UND double_word
 // SYMS-NEXT: NOTYPE GLOBAL DEFAULT UND full_word
 // SYMS-NEXT: NOTYPE GLOBAL DEFAULT UND half_word

llvm/test/MC/ELF/alias.s

 // CHECK-NEXT:     Value: 0x1
 // CHECK-NEXT:     Size: 0
 // CHECK-NEXT:     Binding: Local
 // CHECK-NEXT:     Type: Function
 // CHECK-NEXT:     Other: 0
 // CHECK-NEXT:     Section: .text
 // CHECK-NEXT:   }
 // CHECK-NEXT:   Symbol {
+// CHECK-NEXT:     Name: .text (0)
+// CHECK-NEXT:     Value: 0x0
+// CHECK-NEXT:     Size: 0
+// CHECK-NEXT:     Binding: Local (0x0)
+// CHECK-NEXT:     Type: Section (0x3)
+// CHECK-NEXT:     Other: 0
+// CHECK-NEXT:     Section: .text (0x2)
+// CHECK-NEXT:   }
+// CHECK-NEXT:   Symbol {
 // CHECK-NEXT:     Name: .data (0)
 // CHECK-NOT: Symbol {
 // CHECK:        }
 // CHECK-NEXT:   Symbol {
 // CHECK-NEXT:     Name: bar2
 // CHECK-NEXT:     Value: 0x0
 // CHECK-NEXT:     Size: 0
 // CHECK-NEXT:     Binding: Global

llvm/test/MC/ELF/cgprofile.s

 # CHECK-NEXT: Address:
 # CHECK-NEXT: Offset:
 # CHECK-NEXT: Size: 64
 # CHECK-NEXT: Link: 6
 # CHECK-NEXT: Info: 0
 # CHECK-NEXT: AddressAlignment: 1
 # CHECK-NEXT: EntrySize: 16
 # CHECK-NEXT: SectionData (
-# CHECK-NEXT:   0000: 01000000 05000000 20000000 00000000
-# CHECK-NEXT:   0010: 06000000 01000000 0B000000 00000000
-# CHECK-NEXT:   0020: 07000000 02000000 14000000 00000000
-# CHECK-NEXT:   0030: 04000000 05000000 2A000000 00000000
+# CHECK-NEXT:   0000: 01000000 06000000 20000000 00000000
+# CHECK-NEXT:   0010: 07000000 01000000 0B000000 00000000
+# CHECK-NEXT:   0020: 08000000 02000000 14000000 00000000
+# CHECK-NEXT:   0030: 05000000 06000000 2A000000 00000000
 # CHECK-NEXT: )
 
 # CHECK: Symbols [
 # CHECK:      Name: a
 # CHECK-NEXT: Value:
 # CHECK-NEXT: Size:
 # CHECK-NEXT: Binding: Local
 # CHECK-NEXT: Type:
 # CHECK-NEXT: Other:
 # CHECK-NEXT: Section: .test
 # CHECK:      Name: late2
 # CHECK-NEXT: Value:
 # CHECK-NEXT: Size:
 # CHECK-NEXT: Binding: Local
 # CHECK-NEXT: Type:
 # CHECK-NEXT: Other:
 # CHECK-NEXT: Section: .test
 # CHECK:      Name: late3
 # CHECK-NEXT: Value:
 # CHECK-NEXT: Size:
 # CHECK-NEXT: Binding: Local
 # CHECK-NEXT: Type:
 # CHECK-NEXT: Other:
 # CHECK-NEXT: Section: .test
+# CHECK:      Name: .text
+# CHECK-NEXT: Value: 0x0
+# CHECK-NEXT: Size: 0
+# CHECK-NEXT: Binding: Local
+# CHECK-NEXT: Type: Section
+# CHECK-NEXT: Other: 0
+# CHECK-NEXT: Section: .text
+# CHECK:      Name: .test
+# CHECK-NEXT: Value: 0x0
+# CHECK-NEXT: Size: 0
+# CHECK-NEXT: Binding: Local
+# CHECK-NEXT: Type: Section
+# CHECK-NEXT: Other: 0
+# CHECK-NEXT: Section: .test
 # CHECK:      Name: b
 # CHECK-NEXT: Value:
 # CHECK-NEXT: Size:
 # CHECK-NEXT: Binding: Global
 # CHECK-NEXT: Type:
 # CHECK-NEXT: Other:
 # CHECK-NEXT: Section: Undefined
 # CHECK:      Name: freq

 # CHECK-NEXT:     To: late2
 # CHECK-NEXT:     Weight: 20
 # CHECK-NEXT:   }
 # CHECK-NEXT:   CGProfileEntry {
 # CHECK-NEXT:     From:
 # CHECK-NEXT:     To: b
 # CHECK-NEXT:     Weight: 42
 # CHECK-NEXT:   }
-# CHECK-NEXT: ]
+# CHECK-NEXT: ]
 

llvm/test/MC/ELF/comdat.s

 // CHECK-NEXT:     Name: .group
 // CHECK-NEXT:     Type: SHT_GROUP
 // CHECK-NEXT:     Flags [
 // CHECK-NEXT:     ]
 // CHECK-NEXT:     Address: 0x0
 // CHECK-NEXT:     Offset:
 // CHECK-NEXT:     Size: 12
 // CHECK-NEXT:     Link:
-// CHECK-NEXT:     Info: 3
+// CHECK-NEXT:     Info: 8
 // CHECK-NEXT:     AddressAlignment: 4
 // CHECK-NEXT:     EntrySize: 4
 // CHECK-NEXT:     SectionData (
 // CHECK-NEXT:       0000:    01000000 09000000 0A000000
 // CHECK-NEXT:     )
 // CHECK-NEXT:   }
 
 // Test that g1 and g2 are local, but g3 is an undefined global.

llvm/test/MC/ELF/empty.s

 // CHECK-NEXT:   }
 // CHECK:        Section {
 // CHECK:          Name: .symtab
 // CHECK-NEXT:     Type: SHT_SYMTAB
 // CHECK-NEXT:     Flags [
 // CHECK-NEXT:     ]
 // CHECK-NEXT:     Address: 0x0
 // CHECK-NEXT:     Offset:
-// CHECK-NEXT:     Size: 24
+// CHECK-NEXT:     Size: 48
 // CHECK-NEXT:     Link:
-// CHECK-NEXT:     Info: 1
+// CHECK-NEXT:     Info: 2
 // CHECK-NEXT:     AddressAlignment: 8
 // CHECK-NEXT:     EntrySize: 24
 // CHECK-NEXT:   }

llvm/test/MC/ELF/reloc-same-name-section.s

 // RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux %s -o - | llvm-readobj -r --expand-relocs - | FileCheck %s
 
 // test that we produce one relocation against each section.
 
 // CHECK:      Relocations [
 // CHECK-NEXT:   Section {{.*}} {
 // CHECK-NEXT:     Relocation {
 // CHECK-NEXT:       Offset:
 // CHECK-NEXT:       Type:
-// CHECK-NEXT:       Symbol:  .foo (4)
+// CHECK-NEXT:       Symbol:  .foo (5)
 // CHECK-NEXT:       Addend:
 // CHECK-NEXT:     }
 // CHECK-NEXT:     Relocation {
 // CHECK-NEXT:       Offset:
 // CHECK-NEXT:       Type:
-// CHECK-NEXT:       Symbol:  .foo (5)
+// CHECK-NEXT:       Symbol:  .foo (6)
 // CHECK-NEXT:       Addend:
 // CHECK-NEXT:     }
 // CHECK-NEXT:   }
 // CHECK-NEXT: ]
 
   .section  .foo,"aG",@progbits,v,comdat
 f:
 
   .section  .foo,"a",@progbits
 g:
 
 
   .section  .bar
   .quad f
   .quad g

llvm/test/MC/ELF/relocation-alias.s

 memcpy_plus_1 = __GI_memcpy+1
 call memcpy_plus_1@PLT
 .endif
 
 ## Redirected symbols do not have a symbol table entry.
 # SYM:      NOTYPE  LOCAL  DEFAULT UND
 # SYM-NEXT: NOTYPE  LOCAL  DEFAULT ABS abs
 # SYM-NEXT: NOTYPE  LOCAL  DEFAULT   4 data_alias_l
+# SYM-NEXT: SECTION LOCAL  DEFAULT   2 .text
 # SYM-NEXT: SECTION LOCAL  DEFAULT   4 .data
 # SYM-NEXT: NOTYPE  GLOBAL DEFAULT UND __GI_memcpy
 # SYM-NEXT: NOTYPE  GLOBAL DEFAULT   4 data
 # SYM-NEXT: NOTYPE  GLOBAL DEFAULT   4 data_alias
 # SYM-NOT:  {{.}}

llvm/test/MC/ELF/section-sym.s

 // CHECK-NEXT:   Offset:
 // CHECK-NEXT:   Size:    0
 // CHECK-NEXT:   Link:    0
 // CHECK-NEXT:   Info:    0
 // CHECK-NEXT:   AddressAlignment:        1
 // CHECK-NEXT:   EntrySize:       0
 // CHECK-NEXT: }
 
-// The relocation points to symbol 3
+// The relocation points to symbol 4
 // CHECK:      Relocations [
 // CHECK-NEXT:   Section ({{.*}}) .relabar {
 // CHECK-NEXT:     Relocation {
 // CHECK-NEXT:       Offset:  0x0
 // CHECK-NEXT:       Type:    R_X86_64_32 (10)
-// CHECK-NEXT:       Symbol:  foo (3)
+// CHECK-NEXT:       Symbol:  foo (4)
 // CHECK-NEXT:       Addend:  0x0
 // CHECK-NEXT:     }
 // CHECK-NEXT:   }
 // CHECK-NEXT: ]
 
 // Symbol 3 is section 6
 // CHECK: Symbols [
 // CHECK-NEXT:  Symbol {

 // CHECK-NEXT:    Value: 0x0
 // CHECK-NEXT:    Size: 0
 // CHECK-NEXT:    Binding: Local (0x0)
 // CHECK-NEXT:    Type: None (0x0)
 // CHECK-NEXT:    Other: 0
 // CHECK-NEXT:    Section: .group
 // CHECK-NEXT:  }
 // CHECK-NEXT:  Symbol {
+// CHECK-NEXT:    Name: .text (0)
+// CHECK-NEXT:    Value: 0x0
+// CHECK-NEXT:    Size: 0
+// CHECK-NEXT:    Binding: Local (0x0)
+// CHECK-NEXT:    Type: Section (0x3)
+// CHECK-NEXT:    Other: 0
+// CHECK-NEXT:    Section: .text (0x2)
+// CHECK-NEXT:  }
+// CHECK-NEXT:  Symbol {
 // CHECK-NEXT:    Name:  foo (0)
 // CHECK-NEXT:    Value: 0x0
 // CHECK-NEXT:    Size: 0
 // CHECK-NEXT:    Binding: Local (0x0)
 // CHECK-NEXT:    Type: Section (0x3)
 // CHECK-NEXT:    Other: 0
 // CHECK-NEXT:    Section: foo (0x4)
 // CHECK-NEXT:  }
+// CHECK-NEXT:  Symbol {
+// CHECK-NEXT:    Name: foo (0)
+// CHECK-NEXT:    Value: 0x0
+// CHECK-NEXT:    Size: 0
+// CHECK-NEXT:    Binding: Local (0x0)
+// CHECK-NEXT:    Type: Section (0x3)
+// CHECK-NEXT:    Other: 0
+// CHECK-NEXT:    Section: foo (0x6)
+// CHECK-NEXT:  }
+// CHECK-NEXT:  Symbol {
+// CHECK-NEXT:    Name: bar (0)
+// CHECK-NEXT:    Value: 0x0
+// CHECK-NEXT:    Size: 0
+// CHECK-NEXT:    Binding: Local (0x0)
+// CHECK-NEXT:    Type: Section (0x3)
+// CHECK-NEXT:    Other: 0
+// CHECK-NEXT:    Section: bar (0x7)
+// CHECK-NEXT:  }
 // CHECK-NEXT: ]

llvm/test/MC/ELF/undef.s

 // CHECK-NEXT:     Value: 0x0
 // CHECK-NEXT:     Size: 0
 // CHECK-NEXT:     Binding: Local
 // CHECK-NEXT:     Type: None
 // CHECK-NEXT:     Other: 0
 // CHECK-NEXT:     Section: .rodata.str1.1
 // CHECK-NEXT:   }
 // CHECK-NEXT:   Symbol {
+// CHECK-NEXT:     Name: .text (0)
+// CHECK-NEXT:     Value: 0x0
+// CHECK-NEXT:     Size: 0
+// CHECK-NEXT:     Binding: Local (0x0)
+// CHECK-NEXT:     Type: Section (0x3)
+// CHECK-NEXT:     Other: 0
+// CHECK-NEXT:     Section: .text (0x2)
+// CHECK-NEXT:   }
+// CHECK-NEXT:   Symbol {
+// CHECK-NEXT:     Name: .rodata.str1.1 (0)
+// CHECK-NEXT:     Value: 0x0
+// CHECK-NEXT:     Size: 0
+// CHECK-NEXT:     Binding: Local (0x0)
+// CHECK-NEXT:     Type: Section (0x3)
+// CHECK-NEXT:     Other: 0
+// CHECK-NEXT:     Section: .rodata.str1.1 (0x4)
+// CHECK-NEXT:   }
+// CHECK-NEXT:   Symbol {
 // CHECK-NEXT:     Name: hidden
 // CHECK-NEXT:     Value: 0x0
 // CHECK-NEXT:     Size: 0
 // CHECK-NEXT:     Binding: Global
 // CHECK-NEXT:     Type: None
 // CHECK-NEXT:     Other [
 // CHECK-NEXT:       STV_HIDDEN
 // CHECK-NEXT:     ]

llvm/test/tools/llvm-objdump/X86/demangle.s

 # RUN: llvm-mc %s -filetype=obj -triple=x86_64-pc-linux -o %t
 # RUN: llvm-objdump -t -r --demangle %t | FileCheck %s
 
 ## Check we demangle symbols when printing symbol table.
 # CHECK:      SYMBOL TABLE:
+# CHECK-NEXT: 0000000000000000 l     d .text           0000000000000000 .text
 # CHECK-NEXT: 0000000000000000 g     F .text           0000000000000000 foo()
 
 ## Check we demangle symbols when printing relocations.
 # CHECK:      000000000000001 R_X86_64_PLT32 foo()-0x4
 
 ## Check the case when relocations are inlined into disassembly.
 # RUN: llvm-objdump -d -r --demangle %t | FileCheck %s --check-prefix=INLINE
 # INLINE:      <foo()>:
 # INLINE-NEXT:  0: {{.*}}  callq   0x5 <foo()+0x5>
 # INLINE-NEXT:  0000000000000001:  R_X86_64_PLT32 foo()-0x4
 
 .text
 .globl _Z3foov
 .type _Z3foov,@function
 _Z3foov:
  callq _Z3foov@PLT

llvm/test/tools/llvm-readobj/ELF/many-sections2.s

.irp k, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
           .globl sym_\i\j\k\l\q
            sym_\i\j\k\l\q:
         .endr
       .endr
     .endr
   .endr
 .endr
 
-# CHECK:     65278: 0000000000000000 0 NOTYPE GLOBAL DEFAULT 65280 sym_65277
-# CHECK:     65310: 0000000000000000 0 NOTYPE GLOBAL DEFAULT 65312 sym_65309
-# CHECK:     65342: 0000000000000000 0 NOTYPE GLOBAL DEFAULT 65344 sym_65341
+# CHECK:    135279: 0000000000000000 0 NOTYPE GLOBAL DEFAULT 65280 sym_65277
+# CHECK:    135311: 0000000000000000 0 NOTYPE GLOBAL DEFAULT 65312 sym_65309
+# CHECK:    135343: 0000000000000000 0 NOTYPE GLOBAL DEFAULT 65344 sym_65341