- User Since
- May 15 2019, 3:25 PM (99 w, 5 d)
This broke the ppc64le-sanitizer builderr: https://lab.llvm.org/buildbot/#/builders/19/builds/3565. Will fix it.
Fri, Apr 9
Thu, Apr 8
Fix a typo.
Tue, Apr 6
I'm ok with this, and thanks for taking the time to work on it. It would be good to collect another LGTM from another reviewer before submitting.
Mon, Apr 5
Only accept MCExpr in the affected instructions.
Thu, Apr 1
Relanded without -fno-initegrated-as case at https://reviews.llvm.org/rG76d9bc72784d88f4dd57b9939e52c73739438af5.
Wed, Mar 31
We can probably remove the -fno-integraetd-as case.
Tue, Mar 30
Update tests to address comments.
Mon, Mar 29
Thu, Mar 25
Mon, Mar 22
Fri, Mar 19
Address comments so far.
Thu, Mar 18
Mar 12 2021
I'm not sure if this would be a big issue but restoreStatOnFile also runs on the split dwo file, and will keep its ownership with this change. I don't think GNU assembler does that currently. Also you could delete the code added in https://reviews.llvm.org/D98511 for passing user and group ID since they are no longer needed, assuming the new behavior is what we want.
Mar 2 2021
Mar 1 2021
Add period after a comment.
Remove unncessary CHECK-NOT.
Update test cases.
Feb 26 2021
Skip range check of MCBinaryExpr in b.w instead of any non-constant expressions.
Skip range check of MCBinaryExpr instead of any non-constant expressions.
This is created based on the discussion at https://reviews.llvm.org/D97501#inline-914358.
Feb 25 2021
Remove encodings from the tests.
Update the test cases.
Feb 17 2021
Feb 12 2021
Feb 11 2021
Update a comment.
If you use arc diff 'HEAD^', you need --verbatim to amend the description.
Gotcha. Thanks. I've updated the message.
Feb 9 2021
Thanks for this patch. You mentioned the following issue in one of your comments on https://reviews.llvm.org/D93881. IIUC, this patch seems to not have taken care of this issue.
Feb 5 2021
Reuse the result of stat instead of calling it on the output file again.
Feb 4 2021
Check the user of the temporary file instead of the output file to decide the user that invokes the tool.
Limit the patch to root user.
Feb 3 2021
Add trailing comma to comments.
Feb 2 2021
Address @manojgupta's comments.
Update the ownership of the temporary file, instead of the overwritten file.
Jan 14 2021
The test failure turned out to be a false positive. Relanded the change on https://github.com/llvm/llvm-project/commit/9dfeec853008109b1cbe926c22675c96226040d9
I have mentioned that the GNU objcopy/strip smart_rename still has vulnerability and the owner preservation does not work for non-root (CAP_CHOWN) users.
But I think we should do better: instead of: (1) create a temp file (2) open it by name again (3) check it is a regular file with one hard link & it is writable (S_IWUSR) (4) fstat (5) fchown,
we should just modify the destination in place (for objcopy file and strip file). If the file has been mapped readonly, on many platforms it may be unwritable. We have to accept this.
Jan 13 2021
Jan 8 2021
GNU objcopy before 2.36 had the symlink attach vulnerability. The patch would introduce the similar vulnerability to llvm-objcopy.
Jan 6 2021
Address some comments.
Jan 5 2021
Dec 20 2020
Dec 17 2020
Update the test case.
Dec 4 2020
Updated a test case.
Update the syntax in the comment.
Address @jrtc27's comment. paseOp function now skips all the spaces between string arguments until it hits any comma or end of statement. For now we will limit the support to .ascii only.