- User Since
- May 15 2019, 3:25 PM (158 w, 2 d)
Oct 4 2021
Sep 28 2021
Fix my typos.
Sep 27 2021
Sep 13 2021
Aug 17 2021
Jul 16 2021
On second thought, my earlier analysis regarding the time complexity was not correct. Integrating the implementation of LOCAL directive into the for loop that handles macro arguments does not make it more expensive. This implements LOCAL directive within the for loop and avoids copying the macro body, and hopefully is more consistent with the existing code. This also reduces the number of lines added.
Jul 13 2021
Jul 9 2021
Use StringSet instead of std::unordered_set <std::string>.
Jun 23 2021
Jun 21 2021
After chatting with @nickdesaulniers offline, we have decided to abondoned D104656 in favor of keeping all the updates to this differential review for consistency. Appologies for any inconvenience caused.
Add comments explaning the difference with D103184. The implementation in D103184 unconditionally calls getAArch64ArchFeaturesFromMarch, which returns false when an irrelevant -Wa value is detected and parsed (e.g. -Wa,--version) and causes Clang to bail out.
Use the original flawed code for future reference.
It's probably clearer to use a new differential review for relanding. I've created https://reviews.llvm.org/D104656. Sorry for the noises.
The original implementation was indeed flawed. The failed test does not specify target triple so on X86 machines the issue won't happen unless I explicitly specify "-target aarch64".
This fixes the problem.
Jun 7 2021
Jun 4 2021
Update test cases based on comments.
Address the comments and add more tests.
Jun 2 2021
Add a test case.
Jun 1 2021
Limit the change to assembler files, and add more tests.
Thanks for the comments. Please see my replies inlined.
May 27 2021
May 26 2021
Apr 12 2021
This broke the ppc64le-sanitizer builderr: https://lab.llvm.org/buildbot/#/builders/19/builds/3565. Will fix it.
Apr 9 2021
Apr 8 2021
Fix a typo.
Apr 6 2021
I'm ok with this, and thanks for taking the time to work on it. It would be good to collect another LGTM from another reviewer before submitting.
Apr 5 2021
Only accept MCExpr in the affected instructions.
Apr 1 2021
Relanded without -fno-initegrated-as case at https://reviews.llvm.org/rG76d9bc72784d88f4dd57b9939e52c73739438af5.
Mar 31 2021
We can probably remove the -fno-integraetd-as case.
Mar 30 2021
Update tests to address comments.
Mar 29 2021
Mar 25 2021
Mar 22 2021
Mar 19 2021
Address comments so far.