Page MenuHomePhabricator

Fix NDEBUG build after https://reviews.llvm.org/D93005.
ClosedPublic

Authored by csigg on Dec 17 2020, 11:35 AM.

Diff Detail

Event Timeline

csigg created this revision.Dec 17 2020, 11:35 AM
csigg requested review of this revision.Dec 17 2020, 11:35 AM
jpienaar accepted this revision.Dec 17 2020, 11:38 AM
This revision is now accepted and ready to land.Dec 17 2020, 11:38 AM
mehdi_amini accepted this revision.Dec 17 2020, 11:38 AM

Feel free to push build fixes without going through review: getting the build green is the priority :)

rriddle accepted this revision.Dec 17 2020, 11:38 AM

Feel free to just submit this stuff directly in the future BTW.

mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
327

Could we just change this to terminator->successor_begin(), terminator->successor_end() and drop the unused variable?

This revision was landed with ongoing or failed builds.Dec 17 2020, 11:38 AM
This revision was automatically updated to reflect the committed changes.

Feel free to push build fixes without going through review: getting the build green is the priority :)

I was just trying to change as little as possible from my normal workflow when submitting a fix without review or proper testing. Git and me aren't long-time friends.

No worry, thanks for the quick fix!