Page MenuHomePhabricator

[compiler-rt] [builtins] Fix name of __aarch64_have_lse_atomics on Darwin
ClosedPublic

Authored by sberg on Dec 16 2020, 3:53 AM.

Details

Summary

...where the name of that variable defined in
compiler-rt/lib/builtins/cpu_model.c is decorated with a leading underscore

Diff Detail

Event Timeline

sberg created this revision.Dec 16 2020, 3:53 AM
sberg requested review of this revision.Dec 16 2020, 3:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2020, 3:53 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

The one in cpu_model.c has 2 underscores. Where do the three come from for non-Apple?

sberg added a comment.Dec 16 2020, 4:01 AM

The one in cpu_model.c has 2 underscores. Where do the three come from for non-Apple?

It's the other way around, the third underscore is for Apple only, where C symbols are generally decorated with a leading underscore.

ilinpv accepted this revision.Dec 16 2020, 5:19 AM

Thanks for fixing this.

This revision is now accepted and ready to land.Dec 16 2020, 5:19 AM
This revision was landed with ongoing or failed builds.Dec 16 2020, 5:42 AM
This revision was automatically updated to reflect the committed changes.