Page MenuHomePhabricator

ilinpv (Pavel Iliin)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 6 2020, 9:58 AM (54 w, 6 d)

Recent Activity

Mon, Feb 8

ilinpv added a comment to rGb2851aea80e5: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser….

@tambre , as a fallback, is it possible to disable building LSE atomics via a cmake option? I tried COMPILER_RT_HAS_ASM_LSE=OFF, but it didn't work.

There is no such option, as clang outline atomics (enabled by default for Linux so far with intend to extend it for other targets) are rely on compiler-rt support as well.
I would recommend to backport this workaround if statement separator for MSVC takes long.

Mon, Feb 8, 4:43 AM

Fri, Feb 5

ilinpv accepted D96083: [LTT] Don't attempt to lower type tests used only by assumes.

LGTM, thank you for quick fix!

Fri, Feb 5, 4:00 PM · Restricted Project

Fri, Jan 29

ilinpv committed rGc5e7e649d537: [AArch64][Clang][Linux] Enable out-of-line atomics by default. (authored by ilinpv).
[AArch64][Clang][Linux] Enable out-of-line atomics by default.
Fri, Jan 29, 9:46 AM
ilinpv closed D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default..
Fri, Jan 29, 9:46 AM · Restricted Project, Restricted Project
ilinpv updated the diff for D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default..
Fri, Jan 29, 8:21 AM · Restricted Project, Restricted Project
ilinpv updated the diff for D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default..

Tests for "-m[no]outline-atomics" options added.

Fri, Jan 29, 6:30 AM · Restricted Project, Restricted Project

Thu, Jan 28

ilinpv accepted D95639: [compiler-rt] Fix AArch64 out-of-line atomics visibility on mach-o.

Yes, I missed it, thanks for fix!

Thu, Jan 28, 2:58 PM · Restricted Project
ilinpv updated the diff for D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default..
Thu, Jan 28, 2:47 PM · Restricted Project, Restricted Project

Wed, Jan 27

ilinpv updated the diff for D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default..

Clang driver tests for outline atomics were added.

Wed, Jan 27, 4:04 PM · Restricted Project, Restricted Project

Jan 25 2021

ilinpv added a comment to D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default..

@t.p.northover sorry for pinging you, do you have any concerns about latest patch? It enables outline atomics by default on Aarch64/Linux/Clang with libraries check. I am hoping to get this in before LLVM 12 branch.

Jan 25 2021, 7:51 AM · Restricted Project, Restricted Project

Jan 20 2021

ilinpv updated the diff for D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default..
Jan 20 2021, 5:30 AM · Restricted Project, Restricted Project

Jan 13 2021

ilinpv added inline comments to D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default..
Jan 13 2021, 11:50 AM · Restricted Project, Restricted Project
ilinpv updated the diff for D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default..
Jan 13 2021, 11:37 AM · Restricted Project, Restricted Project

Jan 9 2021

ilinpv updated the diff for D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default..

RT library detection and check for outline atomics support added to the driver.

Jan 9 2021, 9:29 AM · Restricted Project, Restricted Project

Jan 6 2021

ilinpv added a comment to D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default..

You said Android is planning to adopt this. Do you know how? I thought they had their own libc; does it also implement getauxval, or do they have a separate compiler-rt, or something entirely different?

Android uses compiler-rt and has getauxval support: https://android.googlesource.com/platform/bionic/+/master/libc/bionic/getauxval.cpp

There would need to be more checks in the CompilerRT case because most platforms won't benefit. There's already Clang logic to discover GCC installations (search for GCCInstallationDetector); I hope you'll be able to use that instead of trying to redo it.

Thanks for the tip, I'll try to utilize it.

Jan 6 2021, 11:32 AM · Restricted Project, Restricted Project

Dec 22 2020

ilinpv added a comment to D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default..

I think this ought to be a Clang patch that detects which platform and libgcc it's targeting before adding the attribute.

Do you mean implementing in Clang Driver something like

Dec 22 2020, 4:53 PM · Restricted Project, Restricted Project

Dec 20 2020

ilinpv added a comment to D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default..

Outline atomics were added with gcc 9.3.1 and turned on by default in gcc 10.1. Consequently most of distributions had libgcc with outline atomics already.
Besides Linux, Android will utilize them as well. Don't know about iOs and MacOs, I guess they are compiling with LSE enabled, so outline atomics should not affect them.
As for benchmarks, I rely on investigations completed during gcc outline atomics enablement work.
Choice of solution ../gcc/libgcc/config/aarch64/lse.S:

Dec 20 2020, 11:28 AM · Restricted Project, Restricted Project

Dec 19 2020

ilinpv requested review of D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default..
Dec 19 2020, 12:45 PM · Restricted Project, Restricted Project

Dec 16 2020

ilinpv accepted D93390: [compiler-rt] [builtins] Fix name of __aarch64_have_lse_atomics on Darwin.

Thanks for fixing this.

Dec 16 2020, 5:19 AM · Restricted Project

Dec 15 2020

ilinpv requested changes to D92836: [AArch64] don't build out of line atomics on Darwin or Windows.

lse.S syntax fixed, compiler-rt with outline atomics should be built fine. If there are no any other issues can we abandon this patch?

Dec 15 2020, 5:07 AM

Dec 14 2020

ilinpv added a comment to D93211: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

It'd be great if you could figure out a way to have the macro expand in a way that doesn't hit the assembly parser bug.

Newline for .cfi_startproc https://reviews.llvm.org/D93236

Dec 14 2020, 11:53 AM · Restricted Project
ilinpv requested review of D93236: [Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug..
Dec 14 2020, 11:50 AM · Restricted Project
ilinpv added a comment to D93211: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

@ilinpv D92530 helped, but CFI start and end directives still seem to cause problems. Any ideas?

Dec 14 2020, 8:24 AM · Restricted Project
ilinpv added a comment to D93199: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

@ilinpv Any ideas why the Apple buildbots might be failing (example)? The errrors seem to be about explicit relocation types missing, but I can't see anything in my changes that could've caused those.

Fix for lse.S is not landed yet: https://reviews.llvm.org/D92530

Any reason for that to not have landed yet? If not, I could probably land that prior to recommiting mine.

I guess because of patch https://reviews.llvm.org/D92836 removing outline atomics for Apple.
Anyway it would be great to have Apple syntax fix landed, thank you for help.

Dec 14 2020, 3:28 AM · Restricted Project
ilinpv added a reviewer for D92836: [AArch64] don't build out of line atomics on Darwin or Windows: tambre.
Dec 14 2020, 2:59 AM
ilinpv added a comment to D93199: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

@ilinpv Any ideas why the Apple buildbots might be failing (example)? The errrors seem to be about explicit relocation types missing, but I can't see anything in my changes that could've caused those.

Dec 14 2020, 2:58 AM · Restricted Project

Dec 13 2020

ilinpv accepted D93178: [CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately.

Thanks for fix, creating symlinks is more elegant and firm solution indeed.

Dec 13 2020, 12:44 PM · Restricted Project

Dec 8 2020

ilinpv added a comment to D92836: [AArch64] don't build out of line atomics on Darwin or Windows.

lse.S syntax could be fixed: https://reviews.llvm.org/D92530
The question is, should outline atomics be in compiler-rt for iOS and ARM-based macOS?

Dec 8 2020, 9:16 AM

Dec 6 2020

ilinpv committed rG377ba7be933f: [compiler-rt][AArch64] Put outline atomic helpers into dedicated dir. (authored by ilinpv).
[compiler-rt][AArch64] Put outline atomic helpers into dedicated dir.
Dec 6 2020, 4:29 PM
ilinpv closed D92724: [compiler-rt][AArch64] Put outline atomic helpers into dedicated dir..
Dec 6 2020, 4:29 PM · Restricted Project

Dec 5 2020

ilinpv added inline comments to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..
Dec 5 2020, 1:35 PM · Restricted Project
ilinpv requested review of D92724: [compiler-rt][AArch64] Put outline atomic helpers into dedicated dir..
Dec 5 2020, 1:12 PM · Restricted Project

Dec 3 2020

ilinpv accepted D92530: [compiler-rt] [builtins] Make lse.S compile on Darwin.

LGTM. Thanks!

Dec 3 2020, 9:17 AM · Restricted Project
ilinpv added a reviewer for D92530: [compiler-rt] [builtins] Make lse.S compile on Darwin: mstorsjo.
Dec 3 2020, 5:38 AM · Restricted Project
ilinpv added inline comments to D92530: [compiler-rt] [builtins] Make lse.S compile on Darwin.
Dec 3 2020, 5:37 AM · Restricted Project
ilinpv added a comment to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..

This broke building for non-ELF targets, I'll send a patch for fixing that.

Dec 3 2020, 4:34 AM · Restricted Project
ilinpv added inline comments to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..
Dec 3 2020, 4:33 AM · Restricted Project
ilinpv added a comment to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..

Also, I see that this wasn't actually sent to any mailing list - I guess we should have some list auto-added for anything touching compiler-rt?

Dec 3 2020, 4:25 AM · Restricted Project

Dec 2 2020

ilinpv committed rGa4ac434c4743: [AArch64] Compiler-rt interface for out-of-line atomics. (authored by ilinpv).
[AArch64] Compiler-rt interface for out-of-line atomics.
Dec 2 2020, 12:08 PM
ilinpv closed D91156: [AArch64] Compiler-rt interface for out-of-line atomics..
Dec 2 2020, 12:07 PM · Restricted Project

Nov 26 2020

ilinpv added a comment to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..

Thank you, does anyone have any more concerns? Could you accept revision?

Nov 26 2020, 2:32 PM · Restricted Project

Nov 25 2020

ilinpv added inline comments to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..
Nov 25 2020, 2:15 AM · Restricted Project
ilinpv updated the diff for D91156: [AArch64] Compiler-rt interface for out-of-line atomics..

Correct getauxval check.

Nov 25 2020, 2:03 AM · Restricted Project

Nov 23 2020

ilinpv added inline comments to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..
Nov 23 2020, 3:15 PM · Restricted Project
ilinpv added inline comments to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..
Nov 23 2020, 9:48 AM · Restricted Project
ilinpv added inline comments to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..
Nov 23 2020, 9:45 AM · Restricted Project
ilinpv updated the diff for D91156: [AArch64] Compiler-rt interface for out-of-line atomics..

Comments were taken into account.

Nov 23 2020, 9:43 AM · Restricted Project

Nov 20 2020

ilinpv committed rG4d7df43ffdb4: [AArch64] Out-of-line atomics (-moutline-atomics) implementation. (authored by ilinpv).
[AArch64] Out-of-line atomics (-moutline-atomics) implementation.
Nov 20 2020, 5:30 AM
ilinpv closed D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation..
Nov 20 2020, 5:30 AM · Restricted Project, Restricted Project

Nov 19 2020

ilinpv updated the diff for D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation..

LCALL4 removed in TargetLoweringBase.

Nov 19 2020, 1:13 PM · Restricted Project, Restricted Project
ilinpv added inline comments to D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation..
Nov 19 2020, 10:23 AM · Restricted Project, Restricted Project
ilinpv added a comment to D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation..

Have you got any further comments?

Nov 19 2020, 7:22 AM · Restricted Project, Restricted Project

Nov 17 2020

ilinpv abandoned D78928: fp16 indexed patterns V16-V31 registers test cases..
Nov 17 2020, 8:51 AM · Restricted Project
ilinpv reclaimed D91156: [AArch64] Compiler-rt interface for out-of-line atomics..
Nov 17 2020, 8:50 AM · Restricted Project
ilinpv edited reviewers for D91156: [AArch64] Compiler-rt interface for out-of-line atomics., added: t.p.northover, jfb, danielkiss; removed: eli.friedman.
Nov 17 2020, 8:45 AM · Restricted Project

Nov 11 2020

ilinpv added inline comments to D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation..
Nov 11 2020, 3:36 PM · Restricted Project, Restricted Project
ilinpv updated the diff for D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation..

Work on comments has been done.

Nov 11 2020, 3:11 PM · Restricted Project, Restricted Project
ilinpv committed rGfdb979cfbbbf: [NFC] [Legalize] Fix spaces and style. (authored by ilinpv).
[NFC] [Legalize] Fix spaces and style.
Nov 11 2020, 11:26 AM
ilinpv abandoned D91156: [AArch64] Compiler-rt interface for out-of-line atomics..

Need to resolve license issue first.

Nov 11 2020, 5:47 AM · Restricted Project
ilinpv added a comment to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..

This is a port of libgcc implementation

I take it the licensing stuff all works out because Linaro is the original author and you're working with them?

Nov 11 2020, 5:39 AM · Restricted Project

Nov 10 2020

ilinpv requested review of D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation..
Nov 10 2020, 5:56 AM · Restricted Project, Restricted Project
ilinpv requested review of D91156: [AArch64] Compiler-rt interface for out-of-line atomics..
Nov 10 2020, 5:52 AM · Restricted Project

Jul 16 2020

ilinpv closed D83830: [ARM] VBIT/VBIF support added..

The patch landed b9a6fb64281b6836e565ee39fb0d543bf184fd88

Jul 16 2020, 3:57 AM · Restricted Project
ilinpv committed rGb9a6fb64281b: [ARM] VBIT/VBIF support added. (authored by ilinpv).
[ARM] VBIT/VBIF support added.
Jul 16 2020, 3:27 AM

Jul 15 2020

ilinpv updated the diff for D83830: [ARM] VBIT/VBIF support added..

vbit/vbif encoding tests added.

Jul 15 2020, 5:11 PM · Restricted Project

Jul 14 2020

Herald added a project to D83830: [ARM] VBIT/VBIF support added.: Restricted Project.
Jul 14 2020, 4:31 PM · Restricted Project

Jul 13 2020

ilinpv committed rG8f7d3430b72e: [ARM][NFC] More detailed vbsl checks in ARM & Thumb2 tests. (authored by ilinpv).
[ARM][NFC] More detailed vbsl checks in ARM & Thumb2 tests.
Jul 13 2020, 9:01 AM

Apr 27 2020

ilinpv created D78928: fp16 indexed patterns V16-V31 registers test cases..
Apr 27 2020, 7:29 AM · Restricted Project

Apr 23 2020

ilinpv committed rGcc457672e628: [AArch64][FIX] FPR16_lo for f16 indexed patterns. (authored by ilinpv).
[AArch64][FIX] FPR16_lo for f16 indexed patterns.
Apr 23 2020, 3:49 PM
ilinpv added inline comments to D78252: [AArch64] FMLA/FMLS patterns improvement..
Apr 23 2020, 3:48 PM · Restricted Project

Apr 22 2020

ilinpv added a comment to D78252: [AArch64] FMLA/FMLS patterns improvement..

Patterns corrected to comply with encoding 4eca1c06a4a9183fcf7bb230d894617caf3cf3be

Apr 22 2020, 7:33 AM · Restricted Project
ilinpv committed rG4eca1c06a4a9: [AArch64][FIX] f16 indexed patterns encoding restrictions. (authored by ilinpv).
[AArch64][FIX] f16 indexed patterns encoding restrictions.
Apr 22 2020, 6:28 AM
ilinpv added inline comments to D78252: [AArch64] FMLA/FMLS patterns improvement..
Apr 22 2020, 6:28 AM · Restricted Project

Apr 21 2020

ilinpv closed D78252: [AArch64] FMLA/FMLS patterns improvement..

Committed be881e2831735d6879ee43710f5a4d1c8d50c615

Apr 21 2020, 12:26 PM · Restricted Project
ilinpv committed rGbe881e283173: [AArch64] FMLA/FMLS patterns improvement. (authored by ilinpv).
[AArch64] FMLA/FMLS patterns improvement.
Apr 21 2020, 10:49 AM
ilinpv updated the diff for D78252: [AArch64] FMLA/FMLS patterns improvement..

v2f32 pattern removed, test added.

Apr 21 2020, 8:37 AM · Restricted Project
ilinpv committed rGc2dd38f1cb7e: [AArch64][NFC] One more intrinsic test. (authored by ilinpv).
[AArch64][NFC] One more intrinsic test.
Apr 21 2020, 7:31 AM

Apr 20 2020

ilinpv updated the diff for D78252: [AArch64] FMLA/FMLS patterns improvement..

Patterns corrected, vector_extract tests added.

Apr 20 2020, 5:22 PM · Restricted Project
ilinpv committed rG6e22a1e5c4df: [AArch64][NFC] More intrinsic tests. (authored by ilinpv).
[AArch64][NFC] More intrinsic tests.
Apr 20 2020, 4:18 PM

Apr 18 2020

ilinpv added inline comments to D78252: [AArch64] FMLA/FMLS patterns improvement..
Apr 18 2020, 7:32 AM · Restricted Project

Apr 17 2020

ilinpv added inline comments to D78252: [AArch64] FMLA/FMLS patterns improvement..
Apr 17 2020, 9:42 AM · Restricted Project
ilinpv updated the diff for D78252: [AArch64] FMLA/FMLS patterns improvement..

More patterns added.

Apr 17 2020, 8:37 AM · Restricted Project

Apr 15 2020

ilinpv created D78252: [AArch64] FMLA/FMLS patterns improvement..
Apr 15 2020, 4:34 PM · Restricted Project
ilinpv committed rGb2dff0dbeabc: [AArch64][NFC]Autogenerated checks. (authored by ilinpv).
[AArch64][NFC]Autogenerated checks.
Apr 15 2020, 12:40 PM

Feb 15 2020

ilinpv added a comment to D74147: [AArch64] Add BIT/BIF support..

Fixed in dc0b8159890134a59fdf34b20e8b2052d9456441. All AArch64 expensive check tests passed.

Feb 15 2020, 5:05 AM · Restricted Project
ilinpv committed rGdc0b81598901: [AArch64][FIX] Correct register live range during pseudo expansion. (authored by ilinpv).
[AArch64][FIX] Correct register live range during pseudo expansion.
Feb 15 2020, 4:19 AM

Feb 14 2020

ilinpv closed D74496: [AArch64][NFC] Update test checks..
Feb 14 2020, 7:00 AM · Restricted Project
ilinpv committed rGb6a9fe209992: [AArch64] Add BIT/BIF support. (authored by ilinpv).
[AArch64] Add BIT/BIF support.
Feb 14 2020, 6:23 AM
ilinpv closed D74147: [AArch64] Add BIT/BIF support..
Feb 14 2020, 6:23 AM · Restricted Project
ilinpv added inline comments to D74147: [AArch64] Add BIT/BIF support..
Feb 14 2020, 5:01 AM · Restricted Project
ilinpv updated the diff for D74147: [AArch64] Add BIT/BIF support..

Obsolete patterns removed, schedulers patched.

Feb 14 2020, 2:30 AM · Restricted Project

Feb 13 2020

ilinpv committed rGb23ec439738a: [AArch64][NFC] Update test checks. This NFC commit updates several llc tests… (authored by ilinpv).
[AArch64][NFC] Update test checks. This NFC commit updates several llc tests…
Feb 13 2020, 4:22 PM
ilinpv added inline comments to D74147: [AArch64] Add BIT/BIF support..
Feb 13 2020, 2:58 AM · Restricted Project

Feb 12 2020

ilinpv updated the diff for D74147: [AArch64] Add BIT/BIF support..

Diff amended in accordance with comments.

Feb 12 2020, 1:01 PM · Restricted Project
ilinpv created D74496: [AArch64][NFC] Update test checks..
Feb 12 2020, 10:33 AM · Restricted Project
ilinpv added inline comments to D74147: [AArch64] Add BIT/BIF support..
Feb 12 2020, 4:23 AM · Restricted Project

Feb 7 2020

ilinpv updated the diff for D74147: [AArch64] Add BIT/BIF support..

More diff context added

Feb 7 2020, 2:56 AM · Restricted Project

Feb 6 2020

ilinpv created D74147: [AArch64] Add BIT/BIF support..
Feb 6 2020, 11:07 AM · Restricted Project