This is almost entirely mechanical.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Time | Test | |
---|---|---|
70 ms | x64 windows > LLVM.CodeGen/XCore::threads.ll |
Event Timeline
Looks good, a few nits.
mlir/include/mlir/Dialect/Tensor/IR/Tensor.h | ||
---|---|---|
31 | Can you start a new comment block to separate this from Tensor Dialect Operations above? | |
34 | Can we remove the reference to MemRef here? | |
mlir/include/mlir/Dialect/Tensor/IR/TensorOps.td | ||
27 | Put this on the previous line? | |
mlir/lib/Dialect/Tensor/IR/TensorOps.cpp | ||
67 | nit: Spell out auto here. | |
69 | nit: Can you just merge this if into the parent one? | |
mlir/lib/Dialect/Tensor/Transforms/Bufferize.cpp | ||
34 | These could just be in the same anonymous namespace. |
Address River's comments.
mlir/lib/Dialect/Tensor/IR/TensorOps.cpp | ||
---|---|---|
69 | Actually, ss != st is redundant. (this was the previous code). I simplified it. | |
mlir/lib/Dialect/Tensor/Transforms/Bufferize.cpp | ||
34 | LLVM coding standard is to keep them small as small as possible so that there is good locality of reference. https://llvm.org/docs/CodingStandards.html#anonymous-namespaces "Because of this, we have a simple guideline: make anonymous namespaces as small as possible, and only use them for class declarations. For example:" |
Can you start a new comment block to separate this from Tensor Dialect Operations above?