This is an archive of the discontinued LLVM Phabricator instance.

Differential D93347

[Test] Fix undef var in attr-speculative-load-hardening.c
ClosedPublic

Authored by thopre on Dec 15 2020, 3:08 PM.

Download Raw Diff

Details

Reviewers

zbrid
chandlerc
EricWF
rsmith
rnk
kristof.beyls

Commits

rG2426b1fa66f9: [Test] Fix undef var in attr-speculative-load-hardening.c

Summary

Fix use of undefined variable in CHECK-NOT directive in clang test
CodeGen/attr-speculative-load-hardening.c.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

thopre requested review of this revision.Dec 15 2020, 3:08 PM

thopre created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2020, 3:08 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B82542: Diff 312049.Dec 15 2020, 3:10 PM

thopre added a child revision: D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.Dec 15 2020, 3:20 PM

Ping?

Ping?

Ping?

LGTM, thanks!

This revision is now accepted and ready to land.Mar 17 2021, 10:57 AM

This revision was landed with ongoing or failed builds.Mar 17 2021, 12:12 PM

Closed by commit rG2426b1fa66f9: [Test] Fix undef var in attr-speculative-load-hardening.c (authored by thopre). · Explain Why

This revision was automatically updated to reflect the committed changes.

thopre added a commit: rG2426b1fa66f9: [Test] Fix undef var in attr-speculative-load-hardening.c.

thopre removed a child revision: D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.Mar 26 2021, 2:41 PM

Revision Contents

Path

Size

clang/

test/

CodeGen/

attr-speculative-load-hardening.c

2 lines

Diff 312049

clang/test/CodeGen/attr-speculative-load-hardening.c

	// RUN: %clang_cc1 -mspeculative-load-hardening -disable-llvm-passes -emit-llvm %s -o - \| FileCheck %s -check-prefix=SLH			// RUN: %clang_cc1 -mspeculative-load-hardening -disable-llvm-passes -emit-llvm %s -o - \| FileCheck %s -check-prefix=SLH
	// RUN: %clang -mno-speculative-load-hardening -S -emit-llvm %s -o - \| FileCheck %s -check-prefix=NOSLH			// RUN: %clang -mno-speculative-load-hardening -S -emit-llvm %s -o - \| FileCheck %s -check-prefix=NOSLH
	//			//
	// Check that we set the attribute on each function.			// Check that we set the attribute on each function.

	int test1() {			int test1() {
	return 42;			return 42;
	}			}
	// SLH: @{{.}}test1{{.}}[[SLH:#[0-9]+]]			// SLH: @{{.}}test1{{.}}[[SLH:#[0-9]+]]

	// SLH: attributes [[SLH]] = { {{.}}speculative_load_hardening{{.}} }			// SLH: attributes [[SLH]] = { {{.}}speculative_load_hardening{{.}} }

	// NOSLH: @{{.}}test1{{.}}[[NOSLH:#[0-9]+]]			// NOSLH: @{{.}}test1{{.}}[[NOSLH:#[0-9]+]]

	// NOSLH-NOT: attributes [[SLH]] = { {{.}}speculative_load_hardening{{.}} }			// NOSLH-NOT: attributes [[NOSLH]] = { {{.}}speculative_load_hardening{{.}} }