Page MenuHomePhabricator

zbrid (Zola Bridges)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 1 2018, 5:48 PM (103 w, 11 h)

Recent Activity

Aug 15 2020

zbrid removed a reviewer for D86034: [WIP] Attribute harden_misspeculation: aaron.ballman.
Aug 15 2020, 11:03 PM · Restricted Project
zbrid updated the summary of D86034: [WIP] Attribute harden_misspeculation.
Aug 15 2020, 11:03 PM · Restricted Project
zbrid requested review of D86034: [WIP] Attribute harden_misspeculation.
Aug 15 2020, 11:02 PM · Restricted Project
zbrid updated the summary of D86033: This is mostly prototype code that should be deleted..
Aug 15 2020, 11:01 PM · Restricted Project
zbrid requested review of D86033: This is mostly prototype code that should be deleted..
Aug 15 2020, 11:01 PM · Restricted Project

Jul 31 2020

zbrid updated subscribers of D85039: [DO NOT SUBMIT][WIP] prototype.
Jul 31 2020, 11:38 AM · Restricted Project, Restricted Project, Restricted Project
zbrid requested review of D85039: [DO NOT SUBMIT][WIP] prototype.
Jul 31 2020, 11:37 AM · Restricted Project, Restricted Project, Restricted Project

Jul 7 2020

zbrid committed rG9d9e499840af: [x86][seses] Add clang flag; Use lvi-cfi with seses (authored by zbrid).
[x86][seses] Add clang flag; Use lvi-cfi with seses
Jul 7 2020, 1:21 PM
zbrid closed D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses.
Jul 7 2020, 1:21 PM · Restricted Project, Restricted Project
zbrid updated the diff for D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses.

rebase prior to commit

Jul 7 2020, 1:19 PM · Restricted Project, Restricted Project
zbrid updated the diff for D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses.

update seses flag

Jul 7 2020, 11:28 AM · Restricted Project, Restricted Project
zbrid updated the diff for D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses.

rebase

Jul 7 2020, 11:10 AM · Restricted Project, Restricted Project
zbrid committed rGdfabffb195ee: [x86][lvi][seses] Use SESES at O0 for LVI mitigation (authored by zbrid).
[x86][lvi][seses] Use SESES at O0 for LVI mitigation
Jul 7 2020, 11:05 AM
zbrid closed D82037: [x86][lvi][seses] Use SESES at O0 for LVI mitigation.
Jul 7 2020, 11:05 AM · Restricted Project
zbrid updated the diff for D82037: [x86][lvi][seses] Use SESES at O0 for LVI mitigation.

Update commit message to add info about SESES change too

Jul 7 2020, 11:03 AM · Restricted Project
zbrid added a comment to D82037: [x86][lvi][seses] Use SESES at O0 for LVI mitigation.

Going to merge this today. I updated based on the comments.

Jul 7 2020, 10:54 AM · Restricted Project
zbrid updated the diff for D82037: [x86][lvi][seses] Use SESES at O0 for LVI mitigation.

Fix redundant LFENCE problem with SESES

Jul 7 2020, 10:53 AM · Restricted Project
zbrid updated the diff for D82037: [x86][lvi][seses] Use SESES at O0 for LVI mitigation.

Add inline comment about lvi hardening falling back to seses

Jul 7 2020, 10:18 AM · Restricted Project

Jun 29 2020

zbrid added a comment to D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses.

@sconstab @craig.topper - Ping for review

Jun 29 2020, 11:55 AM · Restricted Project, Restricted Project
zbrid added a comment to D82037: [x86][lvi][seses] Use SESES at O0 for LVI mitigation.

@sconstab @craig.topper - Ping for review

Jun 29 2020, 11:55 AM · Restricted Project

Jun 23 2020

Herald added a reviewer for D58866: [docs] add missing nosanitize metadata documentation: jdoerfert.

Hi pranavk, Any reason this didn't get upstreamed? I was just looking for something like this in the docs and came across your patch here.

Jun 23 2020, 10:10 AM · Restricted Project

Jun 19 2020

zbrid added inline comments to D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses.
Jun 19 2020, 11:26 AM · Restricted Project, Restricted Project
zbrid updated the diff for D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses.

Fix accidentally deleted clang command line ref

Jun 19 2020, 10:19 AM · Restricted Project, Restricted Project
zbrid added a comment to D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses.

@sconstab @craig.topper @mattdr -- This is ready for another round of review.

Jun 19 2020, 10:19 AM · Restricted Project, Restricted Project
zbrid updated the diff for D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses.

seses implies lvi-cfi

Jun 19 2020, 10:19 AM · Restricted Project, Restricted Project
zbrid added inline comments to D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses.
Jun 19 2020, 9:44 AM · Restricted Project, Restricted Project
zbrid updated the diff for D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses.

Update Clang Command Ref with automated tool

Jun 19 2020, 9:44 AM · Restricted Project, Restricted Project

Jun 18 2020

zbrid updated the diff for D82037: [x86][lvi][seses] Use SESES at O0 for LVI mitigation.

Add comment to clarify

Jun 18 2020, 11:27 AM · Restricted Project

Jun 17 2020

zbrid added a comment to D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses.

Thanks for the ping, Scott. I'll update this so I can get it submitted soon.

Jun 17 2020, 12:56 PM · Restricted Project, Restricted Project
zbrid updated the summary of D82037: [x86][lvi][seses] Use SESES at O0 for LVI mitigation.
Jun 17 2020, 12:24 PM · Restricted Project
zbrid added inline comments to D82037: [x86][lvi][seses] Use SESES at O0 for LVI mitigation.
Jun 17 2020, 12:24 PM · Restricted Project
zbrid added a comment to D80964: [X86] Add an Unoptimized Load Value Injection (LVI) Load Hardening Pass.

I created a patch for the suggested change. Perhaps we should continue the conversation there? https://reviews.llvm.org/D82037

Jun 17 2020, 12:24 PM · Restricted Project
zbrid retitled D82037: [x86][lvi][seses] Use SESES at O0 for LVI mitigation from [lvi][seses] Use SESES at O0 for LVI mitigation to [x86][lvi][seses] Use SESES at O0 for LVI mitigation.
Jun 17 2020, 12:24 PM · Restricted Project
zbrid created D82037: [x86][lvi][seses] Use SESES at O0 for LVI mitigation.
Jun 17 2020, 12:23 PM · Restricted Project
zbrid added a comment to D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..

Thanks for the explanation!

Jun 17 2020, 10:13 AM · Restricted Project
zbrid added a comment to D80964: [X86] Add an Unoptimized Load Value Injection (LVI) Load Hardening Pass.

It may also be worth noting that this new unoptimized pass is equivalent to the behavior of the mitigation implemented for gcc through binutils. Given that I wonder if it makes sense to use this pass at O1 or O2 and save the mostly costly analysis for O3.

Jun 17 2020, 10:13 AM · Restricted Project
zbrid added a comment to D80964: [X86] Add an Unoptimized Load Value Injection (LVI) Load Hardening Pass.

From a security perspective, I think that this could become problematic. It would mean that at -O0 I would get more security than I would at -O[1-3]. IMO optimization levels should not work like that.

Jun 17 2020, 10:13 AM · Restricted Project

Jun 16 2020

zbrid added a comment to D80964: [X86] Add an Unoptimized Load Value Injection (LVI) Load Hardening Pass.

Also to be a bit clearer, I don't think it's necessary to unify the approaches. It seems like deleting the new approach and dropping in SESES would be sufficient. Let me know if that's not the case.

Jun 16 2020, 5:34 PM · Restricted Project
zbrid added inline comments to D80964: [X86] Add an Unoptimized Load Value Injection (LVI) Load Hardening Pass.
Jun 16 2020, 5:33 PM · Restricted Project
zbrid accepted D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..
Jun 16 2020, 5:33 PM · Restricted Project
zbrid added a reviewer for D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors.: zbrid.
Jun 16 2020, 5:05 PM · Restricted Project
zbrid added a comment to D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..
Jun 16 2020, 5:01 PM · Restricted Project
zbrid added a comment to D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..

Could you explain how not adding the MBB entry block is different from removing extra MBB later? Curious on the details about the differences here since the change makes sense functionally and I don't see any issues, but I can't understand why adding the extra MBB entry block at the point we create the machine function and then deleting extra blocks results in something different than the automatically created entry block. Is it some attributes or configuration in the basic block or something?

Jun 16 2020, 5:01 PM · Restricted Project

May 20 2020

zbrid committed rG60ee88599098: [clang][asm goto][slh] Warn if asm goto + SLH (authored by zbrid).
[clang][asm goto][slh] Warn if asm goto + SLH
May 20 2020, 9:50 AM
zbrid closed D79743: [clang][asm goto][slh] Warn if asm goto + SLH.
May 20 2020, 9:50 AM · Restricted Project
zbrid updated the diff for D79743: [clang][asm goto][slh] Warn if asm goto + SLH.

ClangFormat diagnostic definition

May 20 2020, 9:48 AM · Restricted Project

May 19 2020

zbrid added a comment to D79743: [clang][asm goto][slh] Warn if asm goto + SLH.

This looks good to me. Could you also add a test to use this new DiagGroup (-Wno-slh-asm-goto)?

Thanks.

Jennifer

May 19 2020, 4:34 PM · Restricted Project
zbrid updated the diff for D79743: [clang][asm goto][slh] Warn if asm goto + SLH.

Add test; Update command for existing test

May 19 2020, 4:34 PM · Restricted Project
zbrid committed rGb2d733c35078: [llvm][docs] Add step by step git to GettingStarted (authored by zbrid).
[llvm][docs] Add step by step git to GettingStarted
May 19 2020, 12:38 PM
zbrid closed D80088: [llvm][docs] Add step by step git to GettingStarted.
May 19 2020, 12:37 PM · Restricted Project

May 18 2020

zbrid added a comment to D80088: [llvm][docs] Add step by step git to GettingStarted.

@spatel - I updated the documentation here to use the command mehdi suggested (that you said was good in a follow up comment). The rest of it look good too?

May 18 2020, 5:22 PM · Restricted Project
zbrid added a comment to D79743: [clang][asm goto][slh] Warn if asm goto + SLH.

@jyu2 and @mattdr - updated to address your comments.

May 18 2020, 4:17 PM · Restricted Project
zbrid updated the diff for D79743: [clang][asm goto][slh] Warn if asm goto + SLH.

Update to emit the warning in the parser

May 18 2020, 4:17 PM · Restricted Project
zbrid added a comment to D79743: [clang][asm goto][slh] Warn if asm goto + SLH.

Do you mean runtime crash? If so, I think error should be emit, so that programmer can remove use of "asm goto" and recompile.

May 18 2020, 1:33 PM · Restricted Project
zbrid updated the diff for D80088: [llvm][docs] Add step by step git to GettingStarted.

Change the dry-run command to mehdi's suggestion

May 18 2020, 9:39 AM · Restricted Project
zbrid added a comment to D80088: [llvm][docs] Add step by step git to GettingStarted.

Good idea. Done.

May 18 2020, 9:39 AM · Restricted Project
zbrid added a reviewer for D80088: [llvm][docs] Add step by step git to GettingStarted: mehdi_amini.
May 18 2020, 9:39 AM · Restricted Project

May 17 2020

zbrid updated the diff for D80088: [llvm][docs] Add step by step git to GettingStarted.

Add running tests to the workflow

May 17 2020, 10:39 AM · Restricted Project
zbrid created D80088: [llvm][docs] Add step by step git to GettingStarted.
May 17 2020, 10:39 AM · Restricted Project

May 15 2020

zbrid committed rG18a855da431e: [clang][slh] Add test for SLH feature checking macro (authored by zbrid).
[clang][slh] Add test for SLH feature checking macro
May 15 2020, 12:32 PM
zbrid closed D79894: [clang][slh] Add test for SLH feature checking macro.
May 15 2020, 12:32 PM · Restricted Project

May 13 2020

zbrid retitled D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses from [WIP][seses] Add clang flag; Use lvi-cfi with seses to [x86][seses] Add clang flag; Use lvi-cfi with seses.
May 13 2020, 3:16 PM · Restricted Project, Restricted Project
zbrid created D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses.
May 13 2020, 2:42 PM · Restricted Project, Restricted Project
zbrid added a comment to D79743: [clang][asm goto][slh] Warn if asm goto + SLH.

Two questions:
1> What happen under SLH, will asm goto gets removed, or a runtime problem?
2> Should we emit error or warning in the Parser instead?

May 13 2020, 1:03 PM · Restricted Project
zbrid updated the diff for D79743: [clang][asm goto][slh] Warn if asm goto + SLH.

Update to fix failing test

May 13 2020, 12:31 PM · Restricted Project
zbrid created D79894: [clang][slh] Add test for SLH feature checking macro.
May 13 2020, 11:57 AM · Restricted Project
zbrid added reviewers for D79743: [clang][asm goto][slh] Warn if asm goto + SLH: jyu2, craig.topper.
May 13 2020, 10:52 AM · Restricted Project

May 11 2020

zbrid committed rG379e68a76309: [clang][SLH] Add __has_feature(speculative_load_hardening) (authored by zbrid).
[clang][SLH] Add __has_feature(speculative_load_hardening)
May 11 2020, 2:02 PM
zbrid closed D79733: [clang][SLH] Add __has_feature(speculative_load_hardening).
May 11 2020, 2:02 PM · Restricted Project
zbrid created D79743: [clang][asm goto][slh] Warn if asm goto + SLH.
May 11 2020, 2:01 PM · Restricted Project
zbrid updated the diff for D79733: [clang][SLH] Add __has_feature(speculative_load_hardening).

Change langopt type + SpeculativeLoadHardeningEnabled -> SpeculativeLoadHardening

May 11 2020, 12:56 PM · Restricted Project
zbrid added a reviewer for D75940: [x86][seses] Add documentation for SESES: mattdr.
May 11 2020, 11:50 AM · Restricted Project
zbrid added inline comments to D79733: [clang][SLH] Add __has_feature(speculative_load_hardening).
May 11 2020, 11:50 AM · Restricted Project
zbrid added inline comments to D79733: [clang][SLH] Add __has_feature(speculative_load_hardening).
May 11 2020, 11:50 AM · Restricted Project
zbrid created D79733: [clang][SLH] Add __has_feature(speculative_load_hardening).
May 11 2020, 11:50 AM · Restricted Project
zbrid committed rGbf95cf4a6816: [x86][seses] Introduce SESES pass for LVI (authored by zbrid).
[x86][seses] Introduce SESES pass for LVI
May 11 2020, 9:41 AM
zbrid closed D75939: [x86][seses] Introduce SESES pass for LVI.
May 11 2020, 9:40 AM · Restricted Project
zbrid committed rGf056dacbd756: [llvm][utils] Remove git-svn folder + scripts (authored by zbrid).
[llvm][utils] Remove git-svn folder + scripts
May 11 2020, 9:40 AM
zbrid closed D79348: [llvm][utils] Remove git-svn folder + scripts.
May 11 2020, 9:40 AM · Restricted Project
zbrid added a comment to D75940: [x86][seses] Add documentation for SESES.

@craig.topper @george.burgess.iv Friendly ping on this documentation.

May 11 2020, 9:39 AM · Restricted Project
zbrid updated the diff for D79348: [llvm][utils] Remove git-svn folder + scripts.

Rebasing

May 11 2020, 9:39 AM · Restricted Project

May 5 2020

zbrid edited reviewers for D79340: [compiler-rt][docs] Update license info, added: dberris, arphaman, echristo; removed: jyknight, chandlerc.
May 5 2020, 10:14 AM · Restricted Project

May 4 2020

zbrid abandoned D79361: Revert "[llvm][dfsan][NFC] Factor out fcn initialization".
May 4 2020, 1:26 PM · Restricted Project
zbrid created D79361: Revert "[llvm][dfsan][NFC] Factor out fcn initialization".
May 4 2020, 12:54 PM · Restricted Project
zbrid added a reverting change for rG8d8fda49c99d: [llvm][dfsan][NFC] Factor out fcn initialization: D79361: Revert "[llvm][dfsan][NFC] Factor out fcn initialization".
May 4 2020, 12:54 PM
zbrid updated the summary of D79348: [llvm][utils] Remove git-svn folder + scripts.
May 4 2020, 12:21 PM · Restricted Project
zbrid created D79348: [llvm][utils] Remove git-svn folder + scripts.
May 4 2020, 12:21 PM · Restricted Project
zbrid added reviewers for D79340: [compiler-rt][docs] Update license info: jyknight, chandlerc.
May 4 2020, 10:43 AM · Restricted Project
zbrid created D79340: [compiler-rt][docs] Update license info.
May 4 2020, 10:43 AM · Restricted Project
zbrid committed rG8d8fda49c99d: [llvm][dfsan][NFC] Factor out fcn initialization (authored by zbrid).
[llvm][dfsan][NFC] Factor out fcn initialization
May 4 2020, 10:10 AM
zbrid closed D79307: [llvm][dfsan][NFC] Factor out fcn initialization.
May 4 2020, 10:10 AM · Restricted Project

May 3 2020

zbrid created D79307: [llvm][dfsan][NFC] Factor out fcn initialization.
May 3 2020, 12:45 PM · Restricted Project

Apr 28 2020

zbrid added a comment to D78968: [llvm][utils] Update llc test updater documentation.

I'm also happy to close this if you want to fix the regexes in a patch instead since I agree that would be better.

Apr 28 2020, 8:34 AM · Restricted Project
zbrid added a comment to D78968: [llvm][utils] Update llc test updater documentation.

If this is a problem we should be doing more than just adding a comment in the script.

Possible things to consider:
1 - add support for matching dso_preemptable / dso_local - pretty trivial to add the relevant regex(s)
2 - detect any specifiers and warn that it might not be necessary

Apr 28 2020, 8:34 AM · Restricted Project
zbrid updated the diff for D78968: [llvm][utils] Update llc test updater documentation.

Add FIXME and bug link

Apr 28 2020, 8:34 AM · Restricted Project

Apr 27 2020

zbrid updated the diff for D78968: [llvm][utils] Update llc test updater documentation.

[utils] Update comment to be more specific based on maskray's comment

Apr 27 2020, 7:57 PM · Restricted Project
zbrid updated subscribers of D78968: [llvm][utils] Update llc test updater documentation.

Added some users of update_llc_test_checks.py.

link attributes is not clear. Do you mean dso_local or dso_preemptable? The problem you described seems like a general stale test problem. Missing dso_local may be a problem but I don't know whether that is common. Maybe there are more common problems that are worth mentioning.

Apr 27 2020, 7:56 PM · Restricted Project
zbrid created D78968: [llvm][utils] Update llc test updater documentation.
Apr 27 2020, 3:39 PM · Restricted Project
zbrid committed rGc750847e0c3b: [libcxx][docs][dfsan] Fix rst rendering related typos (authored by zbrid).
[libcxx][docs][dfsan] Fix rst rendering related typos
Apr 27 2020, 3:07 PM
zbrid closed D78953: [libcxx][docs][dfsan] Fix rst rendering related typos.
Apr 27 2020, 3:07 PM · Restricted Project