Page MenuHomePhabricator

zbrid (Zola Bridges)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 1 2018, 5:48 PM (41 w, 3 d)

Recent Activity

Apr 1 2019

zbrid retitled D59827: [slh] x86 impl of ARM instrinsic + builtin for SLH from [slh] x86 impl of ARM instrinsic for SLH to [slh] x86 impl of ARM instrinsic + builtin for SLH.
Apr 1 2019, 9:19 AM · Restricted Project, Restricted Project

Mar 29 2019

zbrid updated the diff for D59827: [slh] x86 impl of ARM instrinsic + builtin for SLH.

actually fix if statement

Mar 29 2019, 11:31 AM · Restricted Project, Restricted Project
zbrid added inline comments to D59827: [slh] x86 impl of ARM instrinsic + builtin for SLH.
Mar 29 2019, 11:18 AM · Restricted Project, Restricted Project
zbrid updated the diff for D59827: [slh] x86 impl of ARM instrinsic + builtin for SLH.

remove unnecessary if in x86 slh intrinsic lowering function

Mar 29 2019, 11:16 AM · Restricted Project, Restricted Project
zbrid updated the diff for D59827: [slh] x86 impl of ARM instrinsic + builtin for SLH.

remove unnecessary requirement from builtin test

Mar 29 2019, 10:33 AM · Restricted Project, Restricted Project
zbrid updated the diff for D59827: [slh] x86 impl of ARM instrinsic + builtin for SLH.

fix test formatting; make target independent intrinsic; add doc

Mar 29 2019, 10:07 AM · Restricted Project, Restricted Project
zbrid updated the diff for D59827: [slh] x86 impl of ARM instrinsic + builtin for SLH.

update with clang-format

Mar 29 2019, 9:16 AM · Restricted Project, Restricted Project

Mar 26 2019

zbrid updated the diff for D59827: [slh] x86 impl of ARM instrinsic + builtin for SLH.

update whitespace in wasm file to match surrounding

Mar 26 2019, 11:04 AM · Restricted Project, Restricted Project
zbrid created D59827: [slh] x86 impl of ARM instrinsic + builtin for SLH.
Mar 26 2019, 10:52 AM · Restricted Project, Restricted Project

Jan 18 2019

zbrid committed rL351565: [clang][slh] add Clang attr no_speculative_load_hardening.
[clang][slh] add Clang attr no_speculative_load_hardening
Jan 18 2019, 9:25 AM
zbrid committed rC351565: [clang][slh] add Clang attr no_speculative_load_hardening.
[clang][slh] add Clang attr no_speculative_load_hardening
Jan 18 2019, 9:25 AM
zbrid closed D54909: [clang][slh] add Clang attr no_speculative_load_hardening.
Jan 18 2019, 9:24 AM

Jan 16 2019

zbrid added inline comments to D56717: [SLH] AArch64: correctly pick temporary register to mask SP.
Jan 16 2019, 10:05 AM
zbrid added a comment to D54909: [clang][slh] add Clang attr no_speculative_load_hardening.

I'm going to revert the diagnostic changes for now and commit this patch. I tried a few ways to implement this without success so far. I have one additional way I want to try based on some advice on the cfe-dev list, but I'll submit it in another patch once I get some time to try and implement it.

Jan 16 2019, 8:36 AM
zbrid updated the diff for D54909: [clang][slh] add Clang attr no_speculative_load_hardening.

[clang][slh] delete stray includes from removed code

Jan 16 2019, 8:34 AM
zbrid updated the diff for D54909: [clang][slh] add Clang attr no_speculative_load_hardening.

[clang][slh] remove diagnostic for now

Jan 16 2019, 8:31 AM
zbrid added a comment to D55929: Initial AArch64 SLH implementation..

Sounds good. I have a bit of time and can start working on updating the design doc to make it more target independent outside of the implementation section.

Jan 16 2019, 7:55 AM

Jan 15 2019

zbrid added a comment to D55929: Initial AArch64 SLH implementation..

Hi Kristof,

Jan 15 2019, 3:43 PM

Jan 11 2019

zbrid added a comment to D54896: Introduce control flow speculation tracking pass for AArch64..

Hi Kristof,
Sorry about this late review. I wanted to make sure that I understood your implementation of SLH for ARM, so I took a look and made a few comments with some questions on this first patch. Let me know your thoughts. I'm planning to take a look at the other commit you made a few days ago related to SLH too. Hopefully I didn't make too many comments that were already addressed in the follow up commit.

Jan 11 2019, 4:04 PM

Jan 8 2019

zbrid added inline comments to D54909: [clang][slh] add Clang attr no_speculative_load_hardening.
Jan 8 2019, 10:13 AM

Jan 7 2019

zbrid added inline comments to D54909: [clang][slh] add Clang attr no_speculative_load_hardening.
Jan 7 2019, 3:18 PM
zbrid updated the diff for D54909: [clang][slh] add Clang attr no_speculative_load_hardening.

[slh] add clang diagnostic

Jan 7 2019, 3:15 PM

Dec 18 2018

zbrid updated the diff for D54909: [clang][slh] add Clang attr no_speculative_load_hardening.

more clang format

Dec 18 2018, 11:13 AM
zbrid updated the diff for D54909: [clang][slh] add Clang attr no_speculative_load_hardening.

clang format

Dec 18 2018, 11:08 AM

Dec 17 2018

zbrid updated the diff for D54909: [clang][slh] add Clang attr no_speculative_load_hardening.

rebase

Dec 17 2018, 3:35 PM
zbrid updated the diff for D54909: [clang][slh] add Clang attr no_speculative_load_hardening.

Give an error when a function was both attributes specified at different places in the code.

Dec 17 2018, 3:30 PM
zbrid added inline comments to D54909: [clang][slh] add Clang attr no_speculative_load_hardening.
Dec 17 2018, 2:05 PM
zbrid added inline comments to D54909: [clang][slh] add Clang attr no_speculative_load_hardening.
Dec 17 2018, 1:58 PM
zbrid updated the diff for D54909: [clang][slh] add Clang attr no_speculative_load_hardening.

detect (some, not yet all) incompatible uses of attrs; move tests to correct folders

Dec 17 2018, 1:50 PM

Dec 12 2018

zbrid updated the diff for D54909: [clang][slh] add Clang attr no_speculative_load_hardening.

Fix indentation of code block in attribute documentation for no speculative load hardening

Dec 12 2018, 2:16 PM
zbrid updated the diff for D54909: [clang][slh] add Clang attr no_speculative_load_hardening.

Update documentation based on review comments.

Dec 12 2018, 2:08 PM

Dec 3 2018

zbrid added a comment to D54909: [clang][slh] add Clang attr no_speculative_load_hardening.

@aaron.ballman @kristof.beyls ping

Dec 3 2018, 9:50 AM

Nov 27 2018

zbrid updated the diff for D54909: [clang][slh] add Clang attr no_speculative_load_hardening.

Add tests and documentation

Nov 27 2018, 4:29 PM
zbrid committed rL347701: [clang][slh] add attribute for speculative load hardening.
[clang][slh] add attribute for speculative load hardening
Nov 27 2018, 11:59 AM
zbrid committed rC347701: [clang][slh] add attribute for speculative load hardening.
[clang][slh] add attribute for speculative load hardening
Nov 27 2018, 11:59 AM

Nov 26 2018

zbrid committed rC347628: Revert "[clang][slh] add attribute for speculative load hardening".
Revert "[clang][slh] add attribute for speculative load hardening"
Nov 26 2018, 6:26 PM
zbrid committed rL347628: Revert "[clang][slh] add attribute for speculative load hardening".
Revert "[clang][slh] add attribute for speculative load hardening"
Nov 26 2018, 6:26 PM
zbrid committed rC347617: [clang][slh] add attribute for speculative load hardening.
[clang][slh] add attribute for speculative load hardening
Nov 26 2018, 4:06 PM
zbrid committed rL347617: [clang][slh] add attribute for speculative load hardening.
[clang][slh] add attribute for speculative load hardening
Nov 26 2018, 4:06 PM
zbrid closed D54915: [clang][slh] add attribute for speculative load hardening.
Nov 26 2018, 4:06 PM
zbrid added a comment to D54915: [clang][slh] add attribute for speculative load hardening.

Oh okay. Thanks for the info!

Nov 26 2018, 4:05 PM
zbrid added inline comments to D54915: [clang][slh] add attribute for speculative load hardening.
Nov 26 2018, 2:04 PM
zbrid created D54915: [clang][slh] add attribute for speculative load hardening.
Nov 26 2018, 2:01 PM
zbrid committed rL347588: Revert "[clang][slh] add attribute for speculative load hardening".
Revert "[clang][slh] add attribute for speculative load hardening"
Nov 26 2018, 12:15 PM
zbrid committed rC347588: Revert "[clang][slh] add attribute for speculative load hardening".
Revert "[clang][slh] add attribute for speculative load hardening"
Nov 26 2018, 12:15 PM
zbrid committed rL347586: [clang][slh] add attribute for speculative load hardening.
[clang][slh] add attribute for speculative load hardening
Nov 26 2018, 11:44 AM
zbrid committed rC347586: [clang][slh] add attribute for speculative load hardening.
[clang][slh] add attribute for speculative load hardening
Nov 26 2018, 11:44 AM
zbrid closed D54555: [clang][slh] add attribute for speculative load hardening.
Nov 26 2018, 11:44 AM
zbrid added a comment to D54555: [clang][slh] add attribute for speculative load hardening.

@kristof.beyls - Good catch. I updated the lang ref documentation as well. Thanks!

Nov 26 2018, 11:37 AM
zbrid updated the diff for D54555: [clang][slh] add attribute for speculative load hardening.

Update langref documentation about the related LLVM attribute

Nov 26 2018, 11:35 AM
zbrid abandoned D54909: [clang][slh] add Clang attr no_speculative_load_hardening.

I need to work on this some more.

Nov 26 2018, 11:19 AM
zbrid created D54909: [clang][slh] add Clang attr no_speculative_load_hardening.
Nov 26 2018, 11:17 AM
zbrid updated the diff for D54555: [clang][slh] add attribute for speculative load hardening.
  • [clang][slh] add Clang attr no_speculative_load_hardening
Nov 26 2018, 10:58 AM
zbrid updated the diff for D54555: [clang][slh] add attribute for speculative load hardening.
  • [clang][slh] add Clang attr no_speculative_load_hardening
Nov 26 2018, 10:57 AM
zbrid committed rL347582: [clang][slh] Forward mSLH only to Clang CC1.
[clang][slh] Forward mSLH only to Clang CC1
Nov 26 2018, 10:16 AM
zbrid committed rC347582: [clang][slh] Forward mSLH only to Clang CC1.
[clang][slh] Forward mSLH only to Clang CC1
Nov 26 2018, 10:16 AM
zbrid closed D54763: [clang][slh] Forward mSLH only to Clang CC1.
Nov 26 2018, 10:16 AM

Nov 21 2018

zbrid updated the diff for D54555: [clang][slh] add attribute for speculative load hardening.

add objective c methods as a target and related test

Nov 21 2018, 1:02 PM

Nov 20 2018

zbrid added inline comments to D54555: [clang][slh] add attribute for speculative load hardening.
Nov 20 2018, 12:12 PM
zbrid updated the diff for D54555: [clang][slh] add attribute for speculative load hardening.

[clang][slh] update docs with kristof's proposal; mention the attr is
function declarations

Nov 20 2018, 12:12 PM
zbrid created D54763: [clang][slh] Forward mSLH only to Clang CC1.
Nov 20 2018, 11:26 AM

Nov 16 2018

zbrid added inline comments to D54555: [clang][slh] add attribute for speculative load hardening.
Nov 16 2018, 5:48 PM
zbrid updated the diff for D54555: [clang][slh] add attribute for speculative load hardening.

[clang][slh] update attribute docs

Nov 16 2018, 5:14 PM

Nov 15 2018

zbrid added inline comments to D54555: [clang][slh] add attribute for speculative load hardening.
Nov 15 2018, 4:40 PM
zbrid updated the diff for D54555: [clang][slh] add attribute for speculative load hardening.

This changes the spelling of the attribute to be the Clang spelling. The test is updated to reflect this change. A FIXME is added to note that this attribute doesn't current work well with the command line flags for SLH.

Nov 15 2018, 4:32 PM

Nov 14 2018

zbrid created D54555: [clang][slh] add attribute for speculative load hardening.
Nov 14 2018, 4:46 PM