This is an archive of the discontinued LLVM Phabricator instance.

Differential D93188

[AMDGPU][NFC] Remove unused VOP3Mods0Clamp
ClosedPublic

Authored by critson on Dec 13 2020, 5:45 PM.

Details

Reviewers
arsenm
foad
Joe_Nash
Commits
rGaf4570cd3ab9: [AMDGPU][NFC] Remove unused VOP3Mods0Clamp
Summary

This is unused and the selection function does not exist.

Diff Detail

Unit TestsFailed

TimeTest
50 msx64 windows > LLVM.CodeGen/XCore::threads.ll

Event Timeline

critson created this revision.Dec 13 2020, 5:45 PM
Herald added subscribers: kerbowa, hiraditya, t-tye and 6 others. · View Herald TranscriptDec 13 2020, 5:45 PM
critson requested review of this revision.Dec 13 2020, 5:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2020, 5:45 PM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
Harbormaster completed remote builds in B82209: Diff 311478.Dec 13 2020, 6:18 PM
foad accepted this revision.Dec 14 2020, 1:22 AM

I wouldn't have bothered with pre-commit review for a change like this.

This revision is now accepted and ready to land.Dec 14 2020, 1:22 AM
This revision was landed with ongoing or failed builds.Dec 14 2020, 3:01 AM
Closed by commit rGaf4570cd3ab9: [AMDGPU][NFC] Remove unused VOP3Mods0Clamp (authored by critson). · Explain Why
This revision was automatically updated to reflect the committed changes.
critson added a commit: rGaf4570cd3ab9: [AMDGPU][NFC] Remove unused VOP3Mods0Clamp.

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
1 line

Diff 311478

llvm/lib/Target/AMDGPU/SIInstrInfo.td

Show First 20 Lines • Show All 1,310 Lines • ▼ Show 20 Lines
def DS1Addr1Offset : ComplexPattern<i32, 2, "SelectDS1Addr1Offset">; def DS1Addr1Offset : ComplexPattern<i32, 2, "SelectDS1Addr1Offset">;
def DS64Bit4ByteAligned : ComplexPattern<i32, 3, "SelectDS64Bit4ByteAligned">; def DS64Bit4ByteAligned : ComplexPattern<i32, 3, "SelectDS64Bit4ByteAligned">;
def DS128Bit8ByteAligned : ComplexPattern<i64, 3, "SelectDS128Bit8ByteAligned">; def DS128Bit8ByteAligned : ComplexPattern<i64, 3, "SelectDS128Bit8ByteAligned">;
def MOVRELOffset : ComplexPattern<i32, 2, "SelectMOVRELOffset">; def MOVRELOffset : ComplexPattern<i32, 2, "SelectMOVRELOffset">;
def VOP3Mods0 : ComplexPattern<untyped, 4, "SelectVOP3Mods0">; def VOP3Mods0 : ComplexPattern<untyped, 4, "SelectVOP3Mods0">;
def VOP3Mods0Clamp : ComplexPattern<untyped, 3, "SelectVOP3Mods0Clamp">;
def VOP3Mods : ComplexPattern<untyped, 2, "SelectVOP3Mods">; def VOP3Mods : ComplexPattern<untyped, 2, "SelectVOP3Mods">;
def VOP3NoMods : ComplexPattern<untyped, 1, "SelectVOP3NoMods">; def VOP3NoMods : ComplexPattern<untyped, 1, "SelectVOP3NoMods">;
// VOP3Mods, but the input source is known to never be NaN. // VOP3Mods, but the input source is known to never be NaN.
def VOP3Mods_nnan : ComplexPattern<fAny, 2, "SelectVOP3Mods_NNaN">; def VOP3Mods_nnan : ComplexPattern<fAny, 2, "SelectVOP3Mods_NNaN">;
def VOP3OMods : ComplexPattern<untyped, 3, "SelectVOP3OMods">; def VOP3OMods : ComplexPattern<untyped, 3, "SelectVOP3OMods">;
def VOP3PMods : ComplexPattern<untyped, 2, "SelectVOP3PMods">; def VOP3PMods : ComplexPattern<untyped, 2, "SelectVOP3PMods">;
▲ Show 20 Lines • Show All 1,208 Lines • Show Last 20 Lines