Page MenuHomePhabricator

[clang-tidy] Support all YAML supported spellings for bools in CheckOptions.
ClosedPublic

Authored by njames93 on Dec 7 2020, 5:03 AM.

Diff Detail

Event Timeline

njames93 created this revision.Dec 7 2020, 5:03 AM
njames93 requested review of this revision.Dec 7 2020, 5:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2020, 5:03 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Is there a way to add test coverage for this to demonstrate that we handle what YAML considers a Boolean and that we don't allow oddities?

njames93 updated this revision to Diff 309985.Dec 7 2020, 12:12 PM

Refactored based on changes to parent.

njames93 updated this revision to Diff 311388.Dec 12 2020, 5:49 AM

Fix test failures and added some to demonstrate this behaviour. Haven't added exhaustive cases as they are present in the YAML parser tests.

This revision is now accepted and ready to land.Dec 15 2020, 11:28 AM
This revision was landed with ongoing or failed builds.Dec 15 2020, 1:15 PM
This revision was automatically updated to reflect the committed changes.