Page MenuHomePhabricator
Differential D92291

clang/test: Remove platform-linker feature
ClosedPublic
Actions

Authored by • thakis on Nov 29 2020, 5:24 PM.

Details

Reviewers
serge-sans-paille
leonardchan
vvereschaka
Commits
rG61da501b6a1b: clang/test: Remove platform-linker feature
Summary

By explicitly requesting the system linker with -fuse-ld=, the
tests are able to CHECK for the system linker even with
CLANG_DEFAULT_LINKER=lld.

Alternative to D74704.

Diff Detail

Event Timeline

• thakis created this revision.Nov 29 2020, 5:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2020, 5:24 PM
Herald added subscribers: llvm-commits, frasercrmck, luismarques and 20 others. · View Herald Transcript
• thakis requested review of this revision.Nov 29 2020, 5:24 PM
serge-sans-paille added a comment.Nov 30 2020, 1:37 AM

If that's okay with @leonardchan in terms of RISCV validation, I'm fine with that one. Any branch removed is less path to cover!

leonardchan added a subscriber: phosek.Nov 30 2020, 10:23 AM

@phosek This shouldn't affect supporting riscv with our toolchain, right?

phosek added a comment.Nov 30 2020, 1:06 PM
In D92291#2423417, @leonardchan wrote:

@phosek This shouldn't affect supporting riscv with our toolchain, right?

Yes, it shouldn't have any impact.

leonardchan accepted this revision.Nov 30 2020, 1:08 PM
This revision is now accepted and ready to land.Nov 30 2020, 1:08 PM
vvereschaka accepted this revision.Nov 30 2020, 4:33 PM

LGTM

Closed by commit rG61da501b6a1b: clang/test: Remove platform-linker feature (authored by • thakis). · Explain WhyNov 30 2020, 5:01 PM
This revision was automatically updated to reflect the committed changes.
• thakis added a commit: rG61da501b6a1b: clang/test: Remove platform-linker feature.
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2020, 5:01 PM
Herald added a subscriber: jrtc27. · View Herald Transcript

Revision Contents
Changeset List

PathSize
clang/
test/
Driver/
5 lines
9 lines
5 lines
11 lines
3 lines
llvm/
utils/
gn/
secondary/
clang/
test/
1 line

Diff 308504

View Options

clang/test/Driver/riscv32-toolchain-extra.c

Loading...
View Options

clang/test/Driver/riscv32-toolchain.c

Loading...
View Options

clang/test/Driver/riscv64-toolchain-extra.c

Loading...
View Options

clang/test/Driver/riscv64-toolchain.c

Loading...
View Options

clang/test/lit.site.cfg.py.in

Loading...
View Options

llvm/utils/gn/secondary/clang/test/BUILD.gn

Loading...