Page MenuHomePhabricator

clang/test: Remove platform-linker feature
ClosedPublic

Authored by thakis on Nov 29 2020, 5:24 PM.

Details

Summary

By explicitly requesting the system linker with -fuse-ld=, the
tests are able to CHECK for the system linker even with
CLANG_DEFAULT_LINKER=lld.

Alternative to D74704.

Diff Detail

Event Timeline

thakis created this revision.Nov 29 2020, 5:24 PM
thakis requested review of this revision.Nov 29 2020, 5:24 PM

If that's okay with @leonardchan in terms of RISCV validation, I'm fine with that one. Any branch removed is less path to cover!

@phosek This shouldn't affect supporting riscv with our toolchain, right?

@phosek This shouldn't affect supporting riscv with our toolchain, right?

Yes, it shouldn't have any impact.

leonardchan accepted this revision.Nov 30 2020, 1:08 PM
This revision is now accepted and ready to land.Nov 30 2020, 1:08 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2020, 5:01 PM
Herald added a subscriber: jrtc27. · View Herald Transcript