Page MenuHomePhabricator
Differential D92173

[mlir][linalg] Mark linalg.yield as ReturnLike
ClosedPublic
Actions

Authored by herhut on Nov 26 2020, 5:29 AM.

Details

Reviewers
aartbik
nicolasvasilache
bkramer
Commits
rG87568c07f052: [mlir][linalg] Mark linalg.yield as ReturnLike
Summary

This change is required so that bufferization can properly identify the linalg.yield as a terminator with an associated parent op.

Diff Detail

Event Timeline

herhut created this revision.Nov 26 2020, 5:29 AM
Herald added a reviewer: aartbik. · View Herald TranscriptNov 26 2020, 5:29 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: mravishankar, teijeong, rdzhabarov and 15 others. · View Herald Transcript
herhut requested review of this revision.Nov 26 2020, 5:29 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptNov 26 2020, 5:29 AM
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
bkramer accepted this revision.Nov 26 2020, 5:32 AM
bkramer added a subscriber: bkramer.

looks good

This revision is now accepted and ready to land.Nov 26 2020, 5:32 AM
herhut updated this revision to Diff 307846.Nov 26 2020, 5:40 AM

Clean up test invocation

This revision was landed with ongoing or failed builds.Nov 26 2020, 5:44 AM
Closed by commit rG87568c07f052: [mlir][linalg] Mark linalg.yield as ReturnLike (authored by herhut). · Explain Why
This revision was automatically updated to reflect the committed changes.
herhut added a commit: rG87568c07f052: [mlir][linalg] Mark linalg.yield as ReturnLike.
Harbormaster completed remote builds in B80223: Diff 307842.Nov 26 2020, 5:44 AM
Harbormaster completed remote builds in B80226: Diff 307846.Nov 26 2020, 5:59 AM

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
Linalg/
IR/
3 lines
integration_test/
Dialect/
Linalg/
CPU/
4 lines
10 lines

Diff 307846

View Options

mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td

Loading...
View Options

mlir/integration_test/Dialect/Linalg/CPU/test-tensor-e2e.mlir

Loading...
View Options

mlir/integration_test/Dialect/Linalg/CPU/test-tensor-matmul.mlir

Loading...