Differential D92092

[AMDGPU] Introduce and use isGFX10Plus. NFC.
ClosedPublic
Actions

Authored by foad on Nov 25 2020, 4:53 AM.

Details

Reviewers

rampitec
Joe_Nash

Commits

rG4f87d30a06dd: [AMDGPU] Introduce and use isGFX10Plus. NFC.

Summary

It's more future-proof to use isGFX10Plus from the start, on the
assumption that future architectures will be based on current
architectures.

Also make use of the existing isGFX9Plus in a few places.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

foad created this revision.Nov 25 2020, 4:53 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 25 2020, 4:53 AM

Herald added subscribers: llvm-commits, kerbowa, hiraditya and 8 others. · View Herald Transcript

foad requested review of this revision.Nov 25 2020, 4:53 AM

Herald added a subscriber: wdng. · View Herald TranscriptNov 25 2020, 4:53 AM

Harbormaster completed remote builds in B80086: Diff 307586.Nov 25 2020, 5:39 AM

rampitec accepted this revision.Nov 25 2020, 10:07 AM

This revision is now accepted and ready to land.Nov 25 2020, 10:07 AM

This revision was landed with ongoing or failed builds.Nov 26 2020, 1:02 AM

Closed by commit rG4f87d30a06dd: [AMDGPU] Introduce and use isGFX10Plus. NFC. (authored by foad). · Explain Why

This revision was automatically updated to reflect the committed changes.

foad added a commit: rG4f87d30a06dd: [AMDGPU] Introduce and use isGFX10Plus. NFC..

foad mentioned this in D92085: [AMDGPU][MC][GFX10] Improved diagnistic message for image instructions w/o DIM modifier.Nov 26 2020, 1:17 AM

Joe_Nash added inline comments.Nov 30 2020, 9:30 AM

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
4880	is equivalent and maybe easier to understand.

foad marked an inline comment as done.Dec 1 2020, 2:22 AM

foad added inline comments.

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
4880	839c9635edce4f6ed348b154a4e755ff8263d366

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Target/

AMDGPU/

AMDGPUAsmPrinter.cpp

2 lines

AMDGPUInstructionSelector.cpp

16 lines

AsmParser/

AMDGPUAsmParser.cpp

67 lines

Disassembler/

AMDGPUDisassembler.h

2 lines

AMDGPUDisassembler.cpp

37 lines

MCTargetDesc/

AMDGPUInstPrinter.cpp

28 lines

SIMCCodeEmitter.cpp

2 lines

SIISelLowering.cpp

20 lines

Utils/

AMDGPUBaseInfo.h

1 line

AMDGPUBaseInfo.cpp

26 lines

Diff 307783

View Options

llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp

View Options

llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp

View Options

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

View Options

llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.h

View Options

llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp

View Options

llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp

View Options

llvm/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp

View Options

llvm/lib/Target/AMDGPU/SIISelLowering.cpp

View Options

llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h

View Options

llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp

[AMDGPU] Introduce and use isGFX10Plus. NFC.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 307783

llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp

llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.h

llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp

llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp

llvm/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp

llvm/lib/Target/AMDGPU/SIISelLowering.cpp

llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h

llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp

[AMDGPU] Introduce and use isGFX10Plus. NFC.
ClosedPublic
Actions

Revision Contents
Changeset List