This is an archive of the discontinued LLVM Phabricator instance.

Differential D91909

[flang][openmp] Fix bug in `OmpClause::Hint` clause which was missing to generate inside in OMP.cpp.inc file.
ClosedPublic

Authored by sameeranjoshi on Nov 21 2020, 2:31 AM.

Details

Reviewers
kiranchandramohan
kiranktp
clementval
sscalpone
jdoerfert
Commits
rG42ecf188b5ae: [flang][openmp] Fix bug in `OmpClause::Hint` clause which was missing to…
Summary

Before this patch "Hint" isn't found inside the generated file.
./bin/llvm-tblgen --gen-directive-gen ../llvm-project/llvm/include/llvm/Frontend/OpenMP/OMP.td -I ../llvm-project/llvm/include/ > OMP.cpp.in

Diff Detail

Unit TestsFailed

TimeTest
390 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp

Event Timeline

sameeranjoshi created this revision.Nov 21 2020, 2:31 AM
Herald added a reviewer: sscalpone. · View Herald TranscriptNov 21 2020, 2:31 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: guansong, yaxunl. · View Herald Transcript
sameeranjoshi requested review of this revision.Nov 21 2020, 2:31 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptNov 21 2020, 2:31 AM
Herald added a subscriber: sstefan1. · View Herald Transcript
sameeranjoshi added a project: Restricted Project.Nov 21 2020, 2:33 AM
Harbormaster completed remote builds in B79680: Diff 306832.Nov 21 2020, 3:40 AM
clementval accepted this revision.Nov 21 2020, 3:55 AM
This revision is now accepted and ready to land.Nov 21 2020, 3:55 AM
This revision was landed with ongoing or failed builds.Nov 21 2020, 5:33 AM
Closed by commit rG42ecf188b5ae: [flang][openmp] Fix bug in `OmpClause::Hint` clause which was missing to… (authored by sameeranjoshi). · Explain Why
This revision was automatically updated to reflect the committed changes.
sameeranjoshi added a commit: rG42ecf188b5ae: [flang][openmp] Fix bug in `OmpClause::Hint` clause which was missing to….

Revision Contents

PathSize
flang/
lib/
Parser/
3 lines
llvm/
include/
llvm/
Frontend/
OpenMP/
2 lines

Diff 306832

flang/lib/Parser/openmp-parsers.cpp

Show First 20 Lines • Show All 178 Lines • ▼ Show 20 LinesTYPE_PARSER(
"FINAL" >> construct<OmpClause>(construct<OmpClause::Final>( "FINAL" >> construct<OmpClause>(construct<OmpClause::Final>(
parenthesized(scalarLogicalExpr))) || parenthesized(scalarLogicalExpr))) ||
"FIRSTPRIVATE" >> construct<OmpClause>(construct<OmpClause::Firstprivate>( "FIRSTPRIVATE" >> construct<OmpClause>(construct<OmpClause::Firstprivate>(
parenthesized(Parser<OmpObjectList>{}))) || parenthesized(Parser<OmpObjectList>{}))) ||
"FROM" >> construct<OmpClause>(construct<OmpClause::From>( "FROM" >> construct<OmpClause>(construct<OmpClause::From>(
parenthesized(Parser<OmpObjectList>{}))) || parenthesized(Parser<OmpObjectList>{}))) ||
"GRAINSIZE" >> construct<OmpClause>(construct<OmpClause::Grainsize>( "GRAINSIZE" >> construct<OmpClause>(construct<OmpClause::Grainsize>(
parenthesized(scalarIntExpr))) || parenthesized(scalarIntExpr))) ||
"HINT" >> construct<OmpClause>(parenthesized(constantExpr)) || "HINT" >> construct<OmpClause>(
construct<OmpClause::Hint>(parenthesized(constantExpr))) ||
"IF" >> construct<OmpClause>(parenthesized(Parser<OmpIfClause>{})) || "IF" >> construct<OmpClause>(parenthesized(Parser<OmpIfClause>{})) ||
"INBRANCH" >> construct<OmpClause>(construct<OmpClause::Inbranch>()) || "INBRANCH" >> construct<OmpClause>(construct<OmpClause::Inbranch>()) ||
"IS_DEVICE_PTR" >> construct<OmpClause>(construct<OmpClause::IsDevicePtr>( "IS_DEVICE_PTR" >> construct<OmpClause>(construct<OmpClause::IsDevicePtr>(
parenthesized(nonemptyList(name)))) || parenthesized(nonemptyList(name)))) ||
"LASTPRIVATE" >> construct<OmpClause>(construct<OmpClause::Lastprivate>( "LASTPRIVATE" >> construct<OmpClause>(construct<OmpClause::Lastprivate>(
parenthesized(Parser<OmpObjectList>{}))) || parenthesized(Parser<OmpObjectList>{}))) ||
"LINEAR" >> "LINEAR" >>
construct<OmpClause>(parenthesized(Parser<OmpLinearClause>{})) || construct<OmpClause>(parenthesized(Parser<OmpLinearClause>{})) ||
▲ Show 20 Lines • Show All 330 Lines • Show Last 20 Lines

llvm/include/llvm/Frontend/OpenMP/OMP.td

Show First 20 Lines • Show All 175 Lines • ▼ Show 20 Linesdef OMPC_NoGroup : Clause<"nogroup"> {
let clangClass = "OMPNogroupClause"; let clangClass = "OMPNogroupClause";
} }
def OMPC_NumTasks : Clause<"num_tasks"> { def OMPC_NumTasks : Clause<"num_tasks"> {
let clangClass = "OMPNumTasksClause"; let clangClass = "OMPNumTasksClause";
let flangClassValue = "ScalarIntExpr"; let flangClassValue = "ScalarIntExpr";
} }
def OMPC_Hint : Clause<"hint"> { def OMPC_Hint : Clause<"hint"> {
let clangClass = "OMPHintClause"; let clangClass = "OMPHintClause";
let flangClass = "ConstantExpr"; let flangClassValue = "ConstantExpr";
} }
def OMPC_DistSchedule : Clause<"dist_schedule"> { def OMPC_DistSchedule : Clause<"dist_schedule"> {
let clangClass = "OMPDistScheduleClause"; let clangClass = "OMPDistScheduleClause";
let flangClass = "OmpDistScheduleClause"; let flangClass = "OmpDistScheduleClause";
let flangClassValue = "ScalarIntExpr"; let flangClassValue = "ScalarIntExpr";
let isValueOptional = 1; let isValueOptional = 1;
} }
def OMPC_DefaultMap : Clause<"defaultmap"> { def OMPC_DefaultMap : Clause<"defaultmap"> {
▲ Show 20 Lines • Show All 1,397 Lines • Show Last 20 Lines