This revision refactors code used in various Linalg transformations and makes it a first class citizen to the LinalgStructureOpInterface. This is in preparation to allowing more advanced Linalg behavior but is otherwise NFC.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOpsInterface.td | ||
---|---|---|
776 | Typo | |
798 | Rephrase "used to the". | |
891 | It's not really "operand dimensions" but "operand dimension sizes". | |
mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp | ||
13–15 | Includes not in sorted order. You also don't need many of the includes below as a result. | |
18 | You don't need this include. | |
19 | You don't need this either. | |
20 | Not needed either. | |
25 | Not needed. | |
26 | Not needed. Prune these includes overall. | |
38 | Doc comment missing. | |
70 | Use i = 0, e = ... form to avoid repeated evaluation. | |
76 | if (!attr) and early return. Will reduce indent / more readable for the entire block below. | |
133–134 | Use .isa<AffineConstantExpr>() / isa<AffineSymbolExpr>() instead of getKind() comparison. | |
mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp | ||
335–338 | Avoid auto here. |
Typo