Page MenuHomePhabricator

[PowerPC] Delete remnant Darwin code in PPCAsmParser
ClosedPublic

Authored by MaskRay on Nov 19 2020, 5:50 PM.

Details

Summary

Continue the work started at D50989.
The code has been long dead since the triple has been removed (D75494).

Diff Detail

Unit TestsFailed

TimeTest
430 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp

Event Timeline

MaskRay created this revision.Nov 19 2020, 5:50 PM
MaskRay requested review of this revision.Nov 19 2020, 5:50 PM
MaskRay updated this revision to Diff 306577.Nov 19 2020, 5:57 PM

Delete unneeded MachO includes and comments

void added inline comments.Nov 19 2020, 6:21 PM
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
2021 ↗(On Diff #306577)

Was this intentional?

nickdesaulniers requested changes to this revision.Nov 20 2020, 12:37 PM
nickdesaulniers added inline comments.
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
2021 ↗(On Diff #306577)

I agree with @void , we should keep the comment but drop the , in a format that the Darwin assembler can deal with.

This revision now requires changes to proceed.Nov 20 2020, 12:37 PM
MaskRay added inline comments.Nov 20 2020, 1:22 PM
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
2021 ↗(On Diff #306577)

This is intentional. Personally I don't think the comment is of any value. The purpose is obvious from its name.

create*AsmPrinterPass is also in AMDGPUAsmPrinter.cpp, which does not have a comment.

MaskRay added inline comments.Nov 25 2020, 8:52 AM
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
2021 ↗(On Diff #306577)

Ping

void accepted this revision.Nov 25 2020, 4:04 PM
MaskRay added inline comments.Nov 29 2020, 9:05 PM
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
2021 ↗(On Diff #306577)
nickdesaulniers accepted this revision.Nov 30 2020, 10:05 AM
nickdesaulniers added inline comments.
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
2021 ↗(On Diff #306577)

I would prefer you didn't remove the entire comment but,

"or enter. I'm a sign, not a cop"
https://imgur.com/gallery/mSHi8

This revision is now accepted and ready to land.Nov 30 2020, 10:05 AM
MaskRay updated this revision to Diff 308413.Nov 30 2020, 10:13 AM

Keep the comment attached to createPPCAsmprinterPass.
Reword it to conform to the coding standard.
/ -> since static /// is useless.

MaskRay marked 3 inline comments as done.Nov 30 2020, 10:14 AM
This revision was landed with ongoing or failed builds.Nov 30 2020, 10:16 AM
This revision was automatically updated to reflect the committed changes.