[clangd] Remove the trailing "." in add-using message.

[hokein]

Summary

to be consistent witih other code actions.

[njames93]

If you are doing this may as well cover DefineOutline and RemoveUsingNamespace - that one can do away with formatv too.

[hokein]

Fix other code actions as well.

[hokein]

In D91694#2402203, @njames93 wrote:

If you are doing this may as well cover DefineOutline and RemoveUsingNamespace - that one can do away with formatv too.

good catch, thanks!

clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp

private:
   NestedNameSpecifierLoc QualifierToRemove;
   // The name following QualifierToRemove. Set by prepare().
   llvm::StringRef Name;
 };
 REGISTER_TWEAK(AddUsing)
 
 std::string AddUsing::title() const {
   return std::string(llvm::formatv(
-      "Add using-declaration for {0} and remove qualifier.", Name));
+      "Add using-declaration for {0} and remove qualifier", Name));
 }
 
 // Locates all "using" statements relevant to SelectionDeclContext.
 class UsingFinder : public RecursiveASTVisitor<UsingFinder> {
 public:
   UsingFinder(std::vector<const UsingDecl *> &Results,
               const DeclContext *SelectionDeclContext, const SourceManager &SM)
       : Results(Results), SelectionDeclContext(SelectionDeclContext), SM(SM) {}

clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp

 public:
   const char *id() const override;
 
   bool hidden() const override { return false; }
   llvm::StringLiteral kind() const override {
     return CodeAction::REFACTOR_KIND;
   }
   std::string title() const override {
-    return "Move function body to out-of-line.";
+    return "Move function body to out-of-line";
   }
 
   bool prepare(const Selection &Sel) override {
     // Bail out if we are not in a header file.
     // FIXME: We might want to consider moving method definitions below class
     // definition even if we are inside a source file.
     if (!isHeaderFile(Sel.AST->getSourceManager().getFilename(Sel.Cursor),
                       Sel.AST->getLangOpts()))

clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp

 /// simplify implementation. Also the namespace must not contain using
 /// directives.
 class RemoveUsingNamespace : public Tweak {
 public:
   const char *id() const override;
 
   bool prepare(const Selection &Inputs) override;
   Expected<Effect> apply(const Selection &Inputs) override;
-  std::string title() const override;
+  std::string title() const override {
+    return "Remove using namespace, re-qualify names instead";
+  }
   llvm::StringLiteral kind() const override {
     return CodeAction::REFACTOR_KIND;
   }
 
 private:
   const UsingDirectiveDecl *TargetDirective = nullptr;
 };
 REGISTER_TWEAK(RemoveUsingNamespace)
Expected<Tweak::Effect> RemoveUsingNamespace::apply(const Selection &Inputs) {
   for (auto Loc : IdentsToQualify) {
     if (auto Err = R.add(tooling::Replacement(Ctx.getSourceManager(), Loc,
                                               /*Length=*/0, Qualifier)))
       return std::move(Err);
   }
   return Effect::mainFileEdit(SM, std::move(R));
 }
 
-std::string RemoveUsingNamespace::title() const {
-  return std::string(
-      llvm::formatv("Remove using namespace, re-qualify names instead."));
-}
 } // namespace
 } // namespace clangd
 } // namespace clang