Paths

Table of Contentst

Differential D91363

[SVE][CodeGen] Extend isConstantSplatValue to support ISD::SPLAT_VECTOR
ClosedPublic
Actions

Authored by kmclaughlin on Nov 12 2020, 9:26 AM.

Details

Reviewers

sdesmalen
efriedma
rengolin

Commits

rG4bee3197f665: [SVE][CodeGen] Extend isConstantSplatValue to support ISD::SPLAT_VECTOR

Summary

Updated the affected scalable_of_scalable tests in sve-gep.ll, as isConstantSplatValue now returns true in DAGCombiner::visitMUL and folds (mul x, 1) -> x

Diff Detail

Unit TestsFailed
View All

	Time	Test
	390 ms	linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp

Event Timeline

kmclaughlin created this revision.Nov 12 2020, 9:26 AM

Herald added a reviewer: rengolin. · View Herald TranscriptNov 12 2020, 9:26 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: llvm-commits, steven.zhang, psnobl and 2 others. · View Herald Transcript

kmclaughlin requested review of this revision.Nov 12 2020, 9:26 AM

kmclaughlin added a child revision: D91084: [SVE][CodeGen] Add the ExtensionType flag to MGATHER.Nov 12 2020, 9:45 AM

Harbormaster completed remote builds in B78636: Diff 304866.Nov 12 2020, 10:02 AM

RKSimon added a subscriber: RKSimon.Nov 12 2020, 1:41 PM

RKSimon added inline comments.

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
148	Is there a truncOrSelf we can use?

Removed the EltSize < SplatVal.getBitWidth() check from isConstantSplatVector and used truncOrSelf instead

kmclaughlin marked an inline comment as done.Nov 13 2020, 10:48 AM

kmclaughlin added inline comments.

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
148	There was no truncOrSelf that I could use here, but I've added this in a separate patch (D91445)

kmclaughlin added a parent revision: D91445: [APInt] Add the truncOrSelf resizing operator to APInt.Nov 13 2020, 10:48 AM

kmclaughlin added a subscriber: lebedev.ri.Nov 23 2020, 3:41 AM

Seems like a good change, LGTM!

This revision is now accepted and ready to land.Nov 24 2020, 3:23 AM

Closed by commit rG4bee3197f665: [SVE][CodeGen] Extend isConstantSplatValue to support ISD::SPLAT_VECTOR (authored by kmclaughlin). · Explain WhyNov 26 2020, 3:24 AM

This revision was automatically updated to reflect the committed changes.

kmclaughlin marked an inline comment as done.

kmclaughlin added a commit: rG4bee3197f665: [SVE][CodeGen] Extend isConstantSplatValue to support ISD::SPLAT_VECTOR.

kmclaughlin removed a child revision: D91084: [SVE][CodeGen] Add the ExtensionType flag to MGATHER.Nov 27 2020, 7:11 AM

Revision Contents
Changeset List

Path

Size

llvm/

lib/

CodeGen/

SelectionDAG/

SelectionDAG.cpp

11 lines

test/

CodeGen/

AArch64/

14 lines

Diff 304866

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

Loading...

llvm/test/CodeGen/AArch64/sve-gep.ll

Loading...