This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Add missing tests to rename feature
ClosedPublic

Authored by kbobyrev on Nov 12 2020, 4:55 AM.

Details

Summary

This adds a couple of missed tests from existing clang-rename ones and
introduces several new ones (e.g. static class member). This patch is required
to ensure feature parity for migration off Clang-Rename API D71880.

Diff Detail

Event Timeline

kbobyrev created this revision.Nov 12 2020, 4:55 AM
kbobyrev requested review of this revision.Nov 12 2020, 4:55 AM
hokein added inline comments.Nov 12 2020, 12:53 PM
clang-tools-extra/clangd/unittests/RenameTests.cpp
203

hmm, I'm not sure this is needed, I think it is identical with C.

618

nit: we have groups of templates on ~Line 215 already, I'd suggest to move these template-related cases to there.

684

nit: add a comment, this is variable template.

703

this test case is about function templates, move to Line 683.

kbobyrev updated this revision to Diff 305047.Nov 13 2020, 12:04 AM
kbobyrev marked 4 inline comments as done.

Address the comments.

hokein accepted this revision.Nov 13 2020, 3:00 AM
hokein added inline comments.
clang-tools-extra/clangd/unittests/RenameTests.cpp
618

this looks like still undone.

I would move this section (from Line638-Line710) to Line307.

This revision is now accepted and ready to land.Nov 13 2020, 3:00 AM
kbobyrev updated this revision to Diff 305070.Nov 13 2020, 3:20 AM

Move the rest of templated cases to appropriate location.

kbobyrev marked an inline comment as done.Nov 13 2020, 3:20 AM
This revision was landed with ongoing or failed builds.Nov 13 2020, 3:29 AM
This revision was automatically updated to reflect the committed changes.