Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/ExecutionEngine/RunnerUtils.cpp | ||
---|---|---|
48 | Just confirming that this shouldn't be something like size_t. |
mlir/include/mlir/ExecutionEngine/RunnerUtils.h | ||
---|---|---|
226 | I would not add index, as we do not know at this level (C, which is called from LLVM) what type index will have. Could we instead do something where we call the print_memref_i32 and have a index_cast operation in front? Not sure index_cast works on memrefs but that would be a nice approach. Until then, maybe at least call this print_memref_index_as_i64? | |
mlir/lib/ExecutionEngine/RunnerUtils.cpp | ||
48 | Directly forward to`print_memref_i64`? |
I would not add index, as we do not know at this level (C, which is called from LLVM) what type index will have. Could we instead do something where we call the print_memref_i32 and have a index_cast operation in front? Not sure index_cast works on memrefs but that would be a nice approach.
Until then, maybe at least call this print_memref_index_as_i64?