This is an archive of the discontinued LLVM Phabricator instance.

Differential D91042

[MC/AsmParser] Fix use of Arm calling convention in target agnostic test
ClosedPublic

Authored by luismarques on Nov 8 2020, 4:10 PM.

Details

Reviewers
compnerd
bogner
asb
lenary
Commits
rG22169e11c304: [MC/AsmParser] Fix use of Arm calling convention in target-agnostic test
Summary

This test originally targeted thumbv7. When it was changed to be a target-independent test the use of the ARM_AAPCS calling convention was left in. That causes failures when running the test on targets that do not support that CC, such as RISC-V. This patch removes the calling convention specifier.

Diff Detail

Unit TestsFailed

TimeTest
420 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp

Event Timeline

luismarques created this revision.Nov 8 2020, 4:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2020, 4:10 PM
Herald added subscribers: llvm-commits, s.egerton, PkmX and 2 others. · View Herald Transcript
luismarques requested review of this revision.Nov 8 2020, 4:10 PM
Harbormaster completed remote builds in B78051: Diff 303740.Nov 8 2020, 4:50 PM
compnerd accepted this revision.Nov 9 2020, 8:57 AM
This revision is now accepted and ready to land.Nov 9 2020, 8:57 AM
This revision was landed with ongoing or failed builds.Nov 24 2020, 2:56 PM
Closed by commit rG22169e11c304: [MC/AsmParser] Fix use of Arm calling convention in target-agnostic test (authored by luismarques). · Explain Why
This revision was automatically updated to reflect the committed changes.
luismarques added a commit: rG22169e11c304: [MC/AsmParser] Fix use of Arm calling convention in target-agnostic test.

Revision Contents

PathSize
llvm/
test/
MC/
AsmParser/
2 lines

Diff 303740

llvm/test/MC/AsmParser/include.ll

; RUN: llc -I %p/Inputs -filetype asm -o - %s | FileCheck %s ; RUN: llc -I %p/Inputs -filetype asm -o - %s | FileCheck %s
; REQUIRES: default_triple ; REQUIRES: default_triple
module asm ".include \22module.x\22" module asm ".include \22module.x\22"
define arm_aapcscc void @f() { define void @f() {
entry: entry:
call void asm sideeffect ".include \22function.x\22", ""() call void asm sideeffect ".include \22function.x\22", ""()
ret void ret void
} }
; CHECK: .set MODULE, 1 ; CHECK: .set MODULE, 1
; CHECK: .set FUNCTION, 1 ; CHECK: .set FUNCTION, 1