[lldb] add a missing dependency on intrinsics_gen

[rmaz]

Summary

Sometimes builds will fail with errors like:

In file included from /build/external/llvm-project/lldb/source/Symbol/SwiftASTContext.cpp:52:
In file included from /build/external/swift/include/swift/IRGen/Linking.h:22:
In file included from /build/external/swift/include/swift/SIL/SILFunction.h:24:
In file included from /build/external/swift/include/swift/SIL/SILBasicBlock.h:23:
In file included from /build/external/swift/include/swift/SIL/SILInstruction.h:21:
In file included from /build/external/swift/include/swift/AST/Builtins.h:24:
**/build/external/llvm-project/llvm/include/llvm/IR/Attributes.h:74:14: fatal error: 'llvm/IR/Attributes.inc' file not found**
#include "llvm/IR/Attributes.inc"
**^~~~~~~~~~~~~~~~~~~~~~~~**

This change ensures the Attributes.inc file is generated before building SwiftASTContext.cpp.

[kastiglione]

lldb/source/Symbol/CMakeLists.txt

-9–-7

Looks like D83454 tried to do away with tablegen_deps, and instead have targets depend directly on intrinsics_gen. Should that be followed here too.

[rmaz]

Update to use DEPENDS

[rmaz]

lldb/source/Symbol/CMakeLists.txt

-9–-7

Good suggestion, updated to match the changes in D83454

[JDevlieghere]

LGTM

lldb/source/Symbol/CMakeLists.txt

43

nit: indentation

[rmaz]

indent DEPENDS

[teemperor]

Just to clarify: This only a dependency in the downstream Swift branch?

[labath]

In D90857#2379761, @teemperor wrote:

Just to clarify: This only a dependency in the downstream Swift branch?

Judging by the error message, this dependency is not correct even in the swift fork. lldbSymbol does not have a direct dependency on llvmIR. It has a dependency on swift (through SwiftASTContext), and swift (through AST/Builtins.h) has a dependency on the generated headers.

So, the right fix should be to add a lldbSymbol->Swift dependency (if one isn't there already), and then a swift->LLVMIR dep.

Unless there are other, direct dependencies (include paths) from lldbSymbol to LLVMIR. However, I don't see any in the llvm repo, so it still sounds like something swifty...

[labath]

Ping!

I'd still like to hear an explanation on how is this patch relevant (in this repository).

Per our code review policy, the responsibility for a patch does not end the moment the patch is committed :

Post-commit review is encouraged, and can be accomplished using any of the tools detailed below. There is a strong expectation that authors respond promptly to post-commit feedback and address it. Failure to do so is cause for the patch to be reverted.

[rmaz]

I'd still like to hear an explanation on how is this patch relevant (in this repository).

Apologies, missed the last notification.

Judging by the error message, this dependency is not correct even in the swift fork. lldbSymbol does not have a direct dependency on llvmIR. It has a dependency on swift (through SwiftASTContext), and swift (through AST/Builtins.h) has a dependency on the generated headers.

Correct.

So, the right fix should be to add a lldbSymbol->Swift dependency (if one isn't there already), and then a swift->LLVMIR dep.

This sounds reasonable, the Swift build script seems to enforce a similar compilation order of:

1. LLVM & Clang
2. Swift
3. LLDB

There are some existing dependencies on Swift libs in standalone mode, let me take a look at this approach instead.

[labath]

Thanks.

lldb/source/Symbol/CMakeLists.txt

 set(LLVM_OPTIONAL_SOURCES LocateSymbolFileMacOSX.cpp)
 
 if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
   set(PLATFORM_SOURCES LocateSymbolFileMacOSX.cpp)
 endif()
 
 add_lldb_library(lldbSymbol
   ArmUnwindInfo.cpp
add_lldb_library(lldbSymbol
   TypeSystem.cpp
   UnwindPlan.cpp
   UnwindTable.cpp
   Variable.cpp
   VariableList.cpp
 
   ${PLATFORM_SOURCES}
 
+  DEPENDS
+    intrinsics_gen
+
   LINK_LIBS
     lldbCore
     lldbExpression
     lldbHost
     lldbTarget
     lldbUtility
     lldbPluginObjCLanguage
 
   LINK_COMPONENTS
     Support
   )