Page MenuHomePhabricator

rmaz (Richard Howell)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 13 2019, 1:09 PM (158 w, 6 d)

Recent Activity

Mon, Sep 26

rmaz committed rG1f451a8bd6f3: [clang] initialize type qualifiers for FunctionNoProtoType (authored by rmaz).
[clang] initialize type qualifiers for FunctionNoProtoType
Mon, Sep 26, 9:49 AM · Restricted Project, Restricted Project
rmaz closed D133586: [clang] initialize type qualifiers for FunctionNoProtoType.
Mon, Sep 26, 9:49 AM · Restricted Project, Restricted Project
rmaz updated the diff for D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

remove else case

Mon, Sep 26, 7:20 AM · Restricted Project, Restricted Project

Fri, Sep 23

rmaz updated the diff for D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

Remove unnecessary friend class

Fri, Sep 23, 9:24 AM · Restricted Project, Restricted Project
rmaz updated the diff for D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

Return default Qualifiers for FunctionNoProtoType

Fri, Sep 23, 7:48 AM · Restricted Project, Restricted Project

Thu, Sep 22

rmaz updated the diff for D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

add -std=c89 to test

Thu, Sep 22, 1:13 PM · Restricted Project, Restricted Project
rmaz added inline comments to D133586: [clang] initialize type qualifiers for FunctionNoProtoType.
Thu, Sep 22, 1:12 PM · Restricted Project, Restricted Project
rmaz added a comment to D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

This is why I'm wondering how we're hitting this problem in the first place. C++ shouldn't be able to create a function without a prototype so why does the ODR hash matter (do we use that in C and I just wasn't aware of it)?

Thu, Sep 22, 1:06 PM · Restricted Project, Restricted Project
rmaz updated the diff for D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

rebase

Thu, Sep 22, 11:20 AM · Restricted Project, Restricted Project

Wed, Sep 21

rmaz updated the diff for D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

Specify target and language for test

Wed, Sep 21, 8:57 AM · Restricted Project, Restricted Project

Tue, Sep 20

rmaz updated the diff for D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

Add unit test for type qualifiers

Tue, Sep 20, 1:52 PM · Restricted Project, Restricted Project

Tue, Sep 13

rmaz added a comment to D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

Do you have a test case for this?

Was struggling to think of a good one. How about a test that repeatedly generates a pcm for a func decl with no params and checks if the DECL_FUNCTION record is the same?

Have you looked at clang/test/Modules/odr_hash.cpp? It's where most of the ODR hash testing takes place by testing that Decls can be merged properly instead of checking the contents of pcm files.. Using #if define, it creates multiple modules from the same file. I would suggest creating two functions in each of the modules, then in the main file, using the function to force it to be loaded from the modules and merged together. The test should fail with the current Clang, but pass with your patch. You may need to create your test file if you need different compiler options.

Tue, Sep 13, 3:00 PM · Restricted Project, Restricted Project
rmaz retitled D133586: [clang] initialize type qualifiers for FunctionNoProtoType from [clang] do not hash undefined qualifiers for FunctionNoProtoType to [clang] initialize type qualifiers for FunctionNoProtoType.
Tue, Sep 13, 2:56 PM · Restricted Project, Restricted Project
rmaz updated the diff for D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

zero out qual types in constructor

Tue, Sep 13, 2:55 PM · Restricted Project, Restricted Project

Mon, Sep 12

rmaz planned changes to D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

I think it is probably safer to zero out the FastTypeQuals instead.

Mon, Sep 12, 2:48 PM · Restricted Project, Restricted Project
rmaz committed rG3c1b42347b3a: [clang] sort additional module maps when serializing (authored by rmaz).
[clang] sort additional module maps when serializing
Mon, Sep 12, 12:01 PM · Restricted Project, Restricted Project
rmaz closed D133611: [clang] sort additional module maps when serializing.
Mon, Sep 12, 12:01 PM · Restricted Project, Restricted Project
rmaz updated the diff for D133611: [clang] sort additional module maps when serializing.

clang-format

Mon, Sep 12, 9:39 AM · Restricted Project, Restricted Project
rmaz updated the diff for D133611: [clang] sort additional module maps when serializing.

rebase

Mon, Sep 12, 8:30 AM · Restricted Project, Restricted Project

Fri, Sep 9

rmaz added a comment to D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

Do you have a test case for this?

Fri, Sep 9, 2:00 PM · Restricted Project, Restricted Project
rmaz added reviewers for D133611: [clang] sort additional module maps when serializing: drodriguez, benlangmuir, rsmith.
Fri, Sep 9, 1:22 PM · Restricted Project, Restricted Project
rmaz requested review of D133611: [clang] sort additional module maps when serializing.
Fri, Sep 9, 1:17 PM · Restricted Project, Restricted Project
rmaz updated the summary of D133586: [clang] initialize type qualifiers for FunctionNoProtoType.
Fri, Sep 9, 10:20 AM · Restricted Project, Restricted Project
rmaz updated the diff for D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

Move code to VisitFunctionProtoType instead of branch

Fri, Sep 9, 10:12 AM · Restricted Project, Restricted Project
rmaz updated the summary of D133586: [clang] initialize type qualifiers for FunctionNoProtoType.
Fri, Sep 9, 10:03 AM · Restricted Project, Restricted Project
rmaz requested review of D133586: [clang] initialize type qualifiers for FunctionNoProtoType.
Fri, Sep 9, 10:01 AM · Restricted Project, Restricted Project

Aug 21 2022

rmaz added a comment to D132267: [llvm-objcopy][MachO] Remove more sections with llvm-bitcode-strip.

I see the producers of the sections here:

Aug 21 2022, 11:25 PM · Restricted Project, Restricted Project

Aug 1 2022

rmaz added a comment to D130710: [ASTWriter] Provide capability to output a PCM/PCH file that does not write out information about its output path.

Is the functionality provided by ORIGINAL_PCH_DIR still useful for making it possible to move a PCH and its referenced headers? It's not completely clear to me when this feature is used in practice. It would be nice to remove it or change the default behaviour if possible, rather than require a new option, but I'm open to this approach if we think we can't change the default.

Given that there was a recent change related to ORIGINAL_PCH_DIR, I'm reluctant to change the default at this point, I added a FIXME for following up to see if we can remove it or change the default later on.

Aug 1 2022, 12:19 AM · Restricted Project, Restricted Project

May 12 2022

rmaz committed rGee51e9795a31: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory (authored by rmaz).
[clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory
May 12 2022, 7:31 AM · Restricted Project, Restricted Project
rmaz closed D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory.
May 12 2022, 7:31 AM · Restricted Project, Restricted Project
rmaz committed rGf11056943e56: [clang] serialize SUBMODULE_TOPHEADER relative to BaseDirectory (authored by rmaz).
[clang] serialize SUBMODULE_TOPHEADER relative to BaseDirectory
May 12 2022, 7:30 AM · Restricted Project, Restricted Project
rmaz closed D124938: [clang] serialize SUBMODULE_TOPHEADER relative to BaseDirectory.
May 12 2022, 7:29 AM · Restricted Project, Restricted Project
rmaz committed rG646e502de0d8: [clang] add -fmodule-file-home-is-cwd (authored by rmaz).
[clang] add -fmodule-file-home-is-cwd
May 12 2022, 7:28 AM · Restricted Project, Restricted Project
rmaz closed D124874: [clang] add -fmodule-file-home-is-cwd.
May 12 2022, 7:28 AM · Restricted Project, Restricted Project

May 11 2022

rmaz added a comment to D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory.

Looks good to me, but perhaps leave it a few days for others to comment (my familiarity with this code is low). I do know people want relocatable outputs though.

May 11 2022, 8:13 AM · Restricted Project, Restricted Project

May 10 2022

rmaz added a reviewer for D125250: [lld/macho] Fixes the -ObjC flag: int3.
May 10 2022, 3:42 PM · Restricted Project, Restricted Project, Restricted Project
rmaz updated the diff for D124874: [clang] add -fmodule-file-home-is-cwd.

Refactor branch into existing case

May 10 2022, 1:27 PM · Restricted Project, Restricted Project

May 9 2022

rmaz added inline comments to D124874: [clang] add -fmodule-file-home-is-cwd.
May 9 2022, 7:19 AM · Restricted Project, Restricted Project

May 6 2022

rmaz added a reviewer for D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory: urnathan.
May 6 2022, 4:37 PM · Restricted Project, Restricted Project
rmaz added a reviewer for D124874: [clang] add -fmodule-file-home-is-cwd: urnathan.
May 6 2022, 4:37 PM · Restricted Project, Restricted Project
rmaz added a reviewer for D124938: [clang] serialize SUBMODULE_TOPHEADER relative to BaseDirectory: urnathan.
May 6 2022, 4:37 PM · Restricted Project, Restricted Project
rmaz updated the diff for D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory.

fix for missing temp dir in test

May 6 2022, 1:48 PM · Restricted Project, Restricted Project

May 4 2022

rmaz updated the diff for D124874: [clang] add -fmodule-file-home-is-cwd.

fix windows paths attempt #2

May 4 2022, 10:31 AM · Restricted Project, Restricted Project
rmaz added reviewers for D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory: manmanren, bruno, aprantl, arphaman, rsmith.
May 4 2022, 10:29 AM · Restricted Project, Restricted Project
rmaz requested review of D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory.
May 4 2022, 10:29 AM · Restricted Project, Restricted Project
rmaz added reviewers for D124938: [clang] serialize SUBMODULE_TOPHEADER relative to BaseDirectory: manmanren, bruno, aprantl, arphaman, rsmith.
May 4 2022, 9:53 AM · Restricted Project, Restricted Project
rmaz requested review of D124938: [clang] serialize SUBMODULE_TOPHEADER relative to BaseDirectory.
May 4 2022, 9:51 AM · Restricted Project, Restricted Project
rmaz updated the diff for D124874: [clang] add -fmodule-file-home-is-cwd.

Use regex for path separators in test

May 4 2022, 9:00 AM · Restricted Project, Restricted Project

May 3 2022

rmaz added reviewers for D124874: [clang] add -fmodule-file-home-is-cwd: aprantl, arphaman, rsmith.
May 3 2022, 1:59 PM · Restricted Project, Restricted Project
rmaz added reviewers for D124874: [clang] add -fmodule-file-home-is-cwd: manmanren, bruno.
May 3 2022, 1:53 PM · Restricted Project, Restricted Project
rmaz requested review of D124874: [clang] add -fmodule-file-home-is-cwd.
May 3 2022, 1:51 PM · Restricted Project, Restricted Project

Mar 7 2022

rmaz committed rG59172194389c: [llvm] remove empty __LLVM segment in llvm-bitcode-strip (authored by rmaz).
[llvm] remove empty __LLVM segment in llvm-bitcode-strip
Mar 7 2022, 8:53 AM · Restricted Project
rmaz closed D120927: [llvm] remove empty __LLVM segment in llvm-bitcode-strip.
Mar 7 2022, 8:52 AM · Restricted Project, Restricted Project
rmaz updated the diff for D120927: [llvm] remove empty __LLVM segment in llvm-bitcode-strip.

With linter

Mar 7 2022, 7:09 AM · Restricted Project, Restricted Project
rmaz updated the diff for D120927: [llvm] remove empty __LLVM segment in llvm-bitcode-strip.

Remove unnecessary CHECK-NOT

Mar 7 2022, 7:08 AM · Restricted Project, Restricted Project

Mar 4 2022

rmaz updated the diff for D120927: [llvm] remove empty __LLVM segment in llvm-bitcode-strip.

Use llvm-readobj --macho-segment

Mar 4 2022, 3:14 PM · Restricted Project, Restricted Project
rmaz updated the diff for D120927: [llvm] remove empty __LLVM segment in llvm-bitcode-strip.

Single pass tests

Mar 4 2022, 3:07 PM · Restricted Project, Restricted Project
rmaz updated the diff for D120669: [llvm] add -r functionality to llvm-bitcode-strip.

update test for windows

Mar 4 2022, 10:42 AM · Restricted Project, Restricted Project
rmaz added a reviewer for D121000: [llvm] fix bitcode-strip.test on windows: drodriguez.
Mar 4 2022, 8:25 AM · Restricted Project, Restricted Project
rmaz requested review of D121000: [llvm] fix bitcode-strip.test on windows.
Mar 4 2022, 8:25 AM · Restricted Project, Restricted Project
rmaz updated the diff for D120669: [llvm] add -r functionality to llvm-bitcode-strip.

with linter

Mar 4 2022, 8:18 AM · Restricted Project, Restricted Project
rmaz updated the diff for D120669: [llvm] add -r functionality to llvm-bitcode-strip.

add : to implicit check not

Mar 4 2022, 8:18 AM · Restricted Project, Restricted Project

Mar 3 2022

rmaz abandoned D120918: [llvm] strip code signature load commands with llvm-bitcode-strip.

It looks like we don't need this change as code signature updating was implemented in D111164. Verified with:

Mar 3 2022, 12:21 PM · Restricted Project, Restricted Project
rmaz updated the summary of D120927: [llvm] remove empty __LLVM segment in llvm-bitcode-strip.
Mar 3 2022, 11:29 AM · Restricted Project, Restricted Project
rmaz added a reviewer for D120927: [llvm] remove empty __LLVM segment in llvm-bitcode-strip: drodriguez.
Mar 3 2022, 11:28 AM · Restricted Project, Restricted Project
rmaz updated the diff for D120927: [llvm] remove empty __LLVM segment in llvm-bitcode-strip.

update test comment

Mar 3 2022, 11:28 AM · Restricted Project, Restricted Project
rmaz requested review of D120927: [llvm] remove empty __LLVM segment in llvm-bitcode-strip.
Mar 3 2022, 11:26 AM · Restricted Project, Restricted Project
rmaz added a reviewer for D120918: [llvm] strip code signature load commands with llvm-bitcode-strip: drodriguez.
Mar 3 2022, 10:10 AM · Restricted Project, Restricted Project
rmaz requested review of D120918: [llvm] strip code signature load commands with llvm-bitcode-strip.
Mar 3 2022, 10:10 AM · Restricted Project, Restricted Project
rmaz added inline comments to D120669: [llvm] add -r functionality to llvm-bitcode-strip.
Mar 3 2022, 8:10 AM · Restricted Project, Restricted Project
rmaz updated the diff for D120669: [llvm] add -r functionality to llvm-bitcode-strip.
  • split test into basic and remove
  • cantFail instead of checking error that cannot occur
Mar 3 2022, 8:09 AM · Restricted Project, Restricted Project
rmaz updated the diff for D120731: [llvm] add -o flag to llvm-bitcode-strip.

update test

Mar 3 2022, 7:34 AM · Restricted Project, Restricted Project
rmaz updated the diff for D120731: [llvm] add -o flag to llvm-bitcode-strip.

reword error message

Mar 3 2022, 7:28 AM · Restricted Project, Restricted Project

Mar 2 2022

rmaz added inline comments to D120669: [llvm] add -r functionality to llvm-bitcode-strip.
Mar 2 2022, 8:14 AM · Restricted Project, Restricted Project
rmaz updated the diff for D120669: [llvm] add -r functionality to llvm-bitcode-strip.
  • add test case for LLVM section with not bundle name
  • add test case for __bundle section in other segment
  • address formatting comments
Mar 2 2022, 8:13 AM · Restricted Project, Restricted Project
rmaz updated the diff for D120731: [llvm] add -o flag to llvm-bitcode-strip.

update test to check error message, remove unused sections and verify output is unchanged.

Mar 2 2022, 7:30 AM · Restricted Project, Restricted Project
rmaz added inline comments to D120669: [llvm] add -r functionality to llvm-bitcode-strip.
Mar 2 2022, 7:26 AM · Restricted Project, Restricted Project
rmaz added inline comments to D120731: [llvm] add -o flag to llvm-bitcode-strip.
Mar 2 2022, 7:13 AM · Restricted Project, Restricted Project
rmaz added inline comments to D120669: [llvm] add -r functionality to llvm-bitcode-strip.
Mar 2 2022, 7:10 AM · Restricted Project, Restricted Project

Mar 1 2022

rmaz updated the diff for D120669: [llvm] add -r functionality to llvm-bitcode-strip.

split out -o into separate diff D120731

Mar 1 2022, 7:36 AM · Restricted Project, Restricted Project
rmaz requested review of D120731: [llvm] add -o flag to llvm-bitcode-strip.
Mar 1 2022, 7:27 AM · Restricted Project, Restricted Project
rmaz planned changes to D120669: [llvm] add -r functionality to llvm-bitcode-strip.
Mar 1 2022, 7:03 AM · Restricted Project, Restricted Project

Feb 28 2022

rmaz added reviewers for D120669: [llvm] add -r functionality to llvm-bitcode-strip: smeenai, drodriguez.
Feb 28 2022, 11:25 AM · Restricted Project, Restricted Project
rmaz requested review of D120669: [llvm] add -r functionality to llvm-bitcode-strip.
Feb 28 2022, 11:24 AM · Restricted Project, Restricted Project

Jan 18 2022

rmaz updated the diff for D116174: [clang] support relative roots to vfs overlays.

Rebase on stable commit

Jan 18 2022, 2:21 PM · Restricted Project, Restricted Project
rmaz updated the diff for D116174: [clang] support relative roots to vfs overlays.

Windows test fixes

Jan 18 2022, 9:57 AM · Restricted Project, Restricted Project

Jan 14 2022

rmaz updated the diff for D116174: [clang] support relative roots to vfs overlays.

Update VirtualFileSystemTest to validate relative root paths.

Jan 14 2022, 12:07 PM · Restricted Project, Restricted Project
rmaz updated the diff for D116174: [clang] support relative roots to vfs overlays.

Add comment to describe relative root path behaviour

Jan 14 2022, 7:55 AM · Restricted Project, Restricted Project
rmaz added a comment to D116174: [clang] support relative roots to vfs overlays.

Each VFS may have its own working directory, so it could be surprising if we use the OS working directory instead of that. This is complicated by the fact the VFS working directory may not be set yet during parsing the yaml (I haven't checked). I'm not really sure what to recommend here. If we do change this, we should document the new behaviour in the doc comment for RedirectingFileSystem though.

Jan 14 2022, 7:36 AM · Restricted Project, Restricted Project

Dec 22 2021

rmaz updated the diff for D116174: [clang] support relative roots to vfs overlays.

clang-format changes

Dec 22 2021, 10:04 AM · Restricted Project, Restricted Project
rmaz updated the summary of D116174: [clang] support relative roots to vfs overlays.
Dec 22 2021, 10:01 AM · Restricted Project, Restricted Project
rmaz updated the summary of D116174: [clang] support relative roots to vfs overlays.
Dec 22 2021, 9:47 AM · Restricted Project, Restricted Project
rmaz added reviewers for D116174: [clang] support relative roots to vfs overlays: keith, JDevlieghere, dexonsmith.
Dec 22 2021, 9:44 AM · Restricted Project, Restricted Project
rmaz updated the diff for D116174: [clang] support relative roots to vfs overlays.

lint

Dec 22 2021, 9:41 AM · Restricted Project, Restricted Project
rmaz requested review of D116174: [clang] support relative roots to vfs overlays.
Dec 22 2021, 9:39 AM · Restricted Project, Restricted Project

Nov 3 2021

rmaz accepted D110123: [clang][objc] Speed up populating the global method pool from modules..
Nov 3 2021, 8:09 AM · Restricted Project

Oct 26 2021

rmaz added a comment to D109632: [clang] de-duplicate methods from AST files.

I don't recall any issues on my last benchmark, but i'll run the patch across all of our modular files and see if anything comes up.

Oct 26 2021, 2:36 PM · Restricted Project
rmaz added a comment to D109632: [clang] de-duplicate methods from AST files.

Code-wise I'm not aware of any remaining issues. Still need to update the commit message and to re-run the clang test suite. But you can totally use the patch for testing. I plan to update D110123 for the review today/tomorrow.

Oct 26 2021, 12:54 PM · Restricted Project

Oct 25 2021

rmaz abandoned D109632: [clang] de-duplicate methods from AST files.

@vsapsai i'll abandon this diff then, thanks for your extensive feedback on the approach. Is D110123 shippable already, or are there some more corner cases to cover?

Oct 25 2021, 5:01 PM · Restricted Project
rmaz abandoned D110092: [clang][NFC] encapsulate global method list in GlobalMethodPool.

Abandoning in favor of D110123

Oct 25 2021, 4:59 PM · Restricted Project