[flang][openacc] Add more parsing/sema tests for init and shutdown directives

[clementval]

Summary

This patch adds some positive and failure tests for init and shutdown directives.

[kiranktp]

flang/test/Semantics/acc-clause-validity.f90

65

I may be wrong here. but i do not see these restrictions in OpenACC 3.0 standard for SHUTDOWN and INIT directive.

[clementval]

flang/test/Semantics/acc-clause-validity.f90

65

There is no written restriction about the if clause on most directives but this is kind of an implicit one since there is also no rule how two if condition would be combined together. Do you combined them with a logical OR or a logical AND. Since the clause takes a condition expression one can combined multiple conditions together in a single if clause.

[sameeranjoshi]

Is there any conclusion on this ?

[clementval]

In D90786#2408355, @sameeranjoshi wrote:

Is there any conclusion on this ?

I have discussed this point with some member of the spec committee and it is not really well defined currently. This will be addressed in future version of the spec but the intention is to allow only a single if clause on all directives.

[clementval]

Ping

[kiranktp]

LGTM

[clementval]

Rebase

flang/test/Semantics/acc-clause-validity.f90

 ! RUN: %S/test_errors.sh %s %t %f18 -fopenacc
 
 ! Check OpenACC clause validity for the following construct and directive:
 !   2.6.5 Data
 !   2.5.1 Parallel
 !   2.5.2 Kernels
 !   2.5.3 Serial
 !   2.9 Loop
 !   2.12 Atomic
 !   2.13 Declare
 !   2.14.3 Set
 !   2.14.4 Update
 !   2.15.1 Routine
 !   2.11 Parallel Loop
 !   2.11 Kernels Loop
 !   2.11 Serial Loop
+!   2.14.1 Init
+!   2.14.2 Shutdown
 !   2.16.13 Wait
 
 program openacc_clause_validity
 
   implicit none
 
   integer :: i, j, b, gang_size, vector_size, worker_size
   integer, parameter :: N = 256
program openacc_clause_validity
   !$acc init if(.TRUE.)
   !$acc init if(ifCondition)
   !$acc init device_num(1)
   !$acc init device_num(i)
   !$acc init device_type(i)
   !$acc init device_type(2, i, j)
   !$acc init device_num(i) device_type(i, j) if(ifCondition)
 
+  !ERROR: At most one IF clause can appear on the INIT directive
+  !$acc init if(.TRUE.) if(ifCondition)
+
+  !ERROR: At most one DEVICE_NUM clause can appear on the INIT directive
+  !$acc init device_num(1) device_num(i)
+
+  !ERROR: At most one DEVICE_TYPE clause can appear on the INIT directive
+  !$acc init device_type(2) device_type(i, j)
+
+  !$acc shutdown
+  !$acc shutdown if(.TRUE.)
+  !$acc shutdown if(ifCondition)
+  !$acc shutdown device_num(1)
+  !$acc shutdown device_num(i)
+  !$acc shutdown device_type(i)
+  !$acc shutdown device_type(2, i, j)
+  !$acc shutdown device_num(i) device_type(i, j) if(ifCondition)
+
+  !ERROR: At most one IF clause can appear on the SHUTDOWN directive
+  !$acc shutdown if(.TRUE.) if(ifCondition)
+
+  !ERROR: At most one DEVICE_NUM clause can appear on the SHUTDOWN directive
+  !$acc shutdown device_num(1) device_num(i)
+
+  !ERROR: At most one DEVICE_TYPE clause can appear on the SHUTDOWN directive
+  !$acc shutdown device_type(2) device_type(i, j)
+
   !ERROR: At least one of ATTACH, COPYIN, CREATE clause must appear on the ENTER DATA directive
   !$acc enter data
 
   !ERROR: Modifier is not allowed for the COPYIN clause on the ENTER DATA directive
   !$acc enter data copyin(zero: i)
 
   !ERROR: Modifier is not allowed for the COPYOUT clause on the EXIT DATA directive
   !$acc exit data copyout(zero: i)