This is an archive of the discontinued LLVM Phabricator instance.

Differential D90517

[clangd] Account for vendor in version string
ClosedPublic

Authored by smeenai on Oct 30 2020, 5:47 PM.

Details

Reviewers
sammccall
kadircet
hokein
Commits
rG6bd01b8184de: [clangd] Account for vendor in version string
Summary

The vendor will be prefixed to the "clangd" and can be an arbitrary
string, so account for it in the test.

Diff Detail

Event Timeline

smeenai created this revision.Oct 30 2020, 5:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 30 2020, 5:47 PM
Herald added subscribers: cfe-commits, usaxena95, arphaman. · View Herald Transcript
smeenai requested review of this revision.Oct 30 2020, 5:47 PM
Herald added subscribers: MaskRay, ilya-biryukov. · View Herald TranscriptOct 30 2020, 5:47 PM
Harbormaster completed remote builds in B77113: Diff 302051.Oct 30 2020, 6:29 PM
sammccall accepted this revision.Oct 31 2020, 3:48 AM
This revision is now accepted and ready to land.Oct 31 2020, 3:48 AM
Closed by commit rG6bd01b8184de: [clangd] Account for vendor in version string (authored by smeenai). · Explain WhyNov 2 2020, 9:05 AM
This revision was automatically updated to reflect the committed changes.
smeenai added a commit: rG6bd01b8184de: [clangd] Account for vendor in version string.

Revision Contents

PathSize
clang-tools-extra/
clangd/
test/
2 lines

Diff 302304

clang-tools-extra/clangd/test/log.test

# RUN: env CLANGD_FLAGS=-index-file=no-such-index not clangd -lit-test </dev/null 2>&1 >/dev/null | FileCheck %s # RUN: env CLANGD_FLAGS=-index-file=no-such-index not clangd -lit-test </dev/null 2>&1 >/dev/null | FileCheck %s
CHECK: I[{{.*}}] clangd version {{.*}} CHECK: I[{{.*}}]{{.*}} clangd version {{.*}}
CHECK: Working directory: {{.*}} CHECK: Working directory: {{.*}}
CHECK: argv[0]: clangd CHECK: argv[0]: clangd
CHECK: argv[1]: -lit-test CHECK: argv[1]: -lit-test
CHECK: CLANGD_FLAGS: -index-file=no-such-index CHECK: CLANGD_FLAGS: -index-file=no-such-index
CHECK: E[{{.*}}] Can't open no-such-index CHECK: E[{{.*}}] Can't open no-such-index
CHECK: Starting LSP over stdin/stdout CHECK: Starting LSP over stdin/stdout