[MLIR] NFC : Move OpenMP dialect include to translation
ClosedPublic
Actions

Authored by kiranchandramohan on Oct 30 2020, 3:42 PM.

Details

Reviewers

ftynse
jdoerfert

Commits

rGab8a4cec5585: [MLIR] NFC : Move OpenMP dialect include to translation

Summary

The OpenMP dialect include is only needed for translation
and is not required in LLVM dialect.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

kiranchandramohan created this revision.Oct 30 2020, 3:42 PM

Herald added a reviewer: ftynse. · View Herald TranscriptOct 30 2020, 3:42 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: rdzhabarov, tatianashp, msifontes and 15 others. · View Herald Transcript

kiranchandramohan requested review of this revision.Oct 30 2020, 3:42 PM

Herald added a reviewer: jdoerfert. · View Herald TranscriptOct 30 2020, 3:42 PM

Herald added subscribers: sstefan1, stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Harbormaster completed remote builds in B77106: Diff 302031.Oct 30 2020, 4:05 PM

Do we also need cmake changes to reflect this?

CMake changes were made in https://reviews.llvm.org/D88351.

ftynse accepted this revision.Nov 2 2020, 12:34 AM

This revision is now accepted and ready to land.Nov 2 2020, 12:34 AM

Closed by commit rGab8a4cec5585: [MLIR] NFC : Move OpenMP dialect include to translation (authored by kiranchandramohan). · Explain WhyNov 3 2020, 2:14 PM

This revision was automatically updated to reflect the committed changes.

kiranchandramohan added a commit: rGab8a4cec5585: [MLIR] NFC : Move OpenMP dialect include to translation.

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Dialect/

LLVMIR/

LLVMDialect.h

1 line

lib/

Target/

LLVMIR/

ConvertToLLVMIR.cpp

1 line

Diff 302031

View Options

mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h