This is an archive of the discontinued LLVM Phabricator instance.

Differential D90510

[MLIR] NFC : Move OpenMP dialect include to translation
ClosedPublic

Authored by kiranchandramohan on Oct 30 2020, 3:42 PM.

Details

Reviewers
ftynse
jdoerfert
Commits
rGab8a4cec5585: [MLIR] NFC : Move OpenMP dialect include to translation
Summary

The OpenMP dialect include is only needed for translation
and is not required in LLVM dialect.

Diff Detail

Event Timeline

kiranchandramohan created this revision.Oct 30 2020, 3:42 PM
Herald added a reviewer: ftynse. · View Herald TranscriptOct 30 2020, 3:42 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: rdzhabarov, tatianashp, msifontes and 15 others. · View Herald Transcript
kiranchandramohan requested review of this revision.Oct 30 2020, 3:42 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptOct 30 2020, 3:42 PM
Herald added subscribers: sstefan1, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B77106: Diff 302031.Oct 30 2020, 4:05 PM
ftynse added a comment.Nov 2 2020, 12:27 AM

Do we also need cmake changes to reflect this?

kiranchandramohan added a comment.Nov 2 2020, 12:33 AM

CMake changes were made in https://reviews.llvm.org/D88351.

ftynse accepted this revision.Nov 2 2020, 12:34 AM
This revision is now accepted and ready to land.Nov 2 2020, 12:34 AM
Closed by commit rGab8a4cec5585: [MLIR] NFC : Move OpenMP dialect include to translation (authored by kiranchandramohan). · Explain WhyNov 3 2020, 2:14 PM
This revision was automatically updated to reflect the committed changes.
kiranchandramohan added a commit: rGab8a4cec5585: [MLIR] NFC : Move OpenMP dialect include to translation.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
LLVMIR/
1 line
lib/
Target/
LLVMIR/
1 line

Diff 302031

mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h

Show All 9 Lines
// LLVM type system. // LLVM type system.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef MLIR_DIALECT_LLVMIR_LLVMDIALECT_H_ #ifndef MLIR_DIALECT_LLVMIR_LLVMDIALECT_H_
#define MLIR_DIALECT_LLVMIR_LLVMDIALECT_H_ #define MLIR_DIALECT_LLVMIR_LLVMDIALECT_H_
#include "mlir/Dialect/LLVMIR/LLVMTypes.h" #include "mlir/Dialect/LLVMIR/LLVMTypes.h"
#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
#include "mlir/IR/Dialect.h" #include "mlir/IR/Dialect.h"
#include "mlir/IR/Function.h" #include "mlir/IR/Function.h"
#include "mlir/IR/OpDefinition.h" #include "mlir/IR/OpDefinition.h"
#include "mlir/IR/OpImplementation.h" #include "mlir/IR/OpImplementation.h"
#include "mlir/IR/TypeSupport.h" #include "mlir/IR/TypeSupport.h"
#include "mlir/IR/Types.h" #include "mlir/IR/Types.h"
#include "mlir/Interfaces/ControlFlowInterfaces.h" #include "mlir/Interfaces/ControlFlowInterfaces.h"
#include "mlir/Interfaces/SideEffectInterfaces.h" #include "mlir/Interfaces/SideEffectInterfaces.h"
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines

mlir/lib/Target/LLVMIR/ConvertToLLVMIR.cpp

//===- ConvertToLLVMIR.cpp - MLIR to LLVM IR conversion -------------------===// //===- ConvertToLLVMIR.cpp - MLIR to LLVM IR conversion -------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// This file implements a translation between the MLIR LLVM dialect and LLVM IR. // This file implements a translation between the MLIR LLVM dialect and LLVM IR.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "mlir/Target/LLVMIR.h" #include "mlir/Target/LLVMIR.h"
#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
#include "mlir/Target/LLVMIR/ModuleTranslation.h" #include "mlir/Target/LLVMIR/ModuleTranslation.h"
#include "mlir/Translation.h" #include "mlir/Translation.h"
#include "llvm/ADT/StringRef.h" #include "llvm/ADT/StringRef.h"
#include "llvm/IR/Module.h" #include "llvm/IR/Module.h"
#include "llvm/IR/Verifier.h" #include "llvm/IR/Verifier.h"
#include "llvm/Support/ToolOutputFile.h" #include "llvm/Support/ToolOutputFile.h"
Show All 31 Lines