Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Conversion/ShapeToStandard/ShapeToStandard.cpp | ||
---|---|---|
567 | Just a note. I have deleted this locally. |
Looks good!
mlir/lib/Conversion/ShapeToStandard/ShapeToStandard.cpp | ||
---|---|---|
228 | If you want to enforce this, you can compare the types below to shape::getExtentTensorType. | |
mlir/test/Conversion/ShapeToStandard/shape-to-standard.mlir | ||
394 | nit: indentation | |
403 | Maybe test this with one shape of statically known rank? | |
409 | Name, e.g. I | |
412 | SMALLER_EXTENT_INDEX? |
I'm going to land this with these changes because the code was already in another commit and didn't receive any strong negative feedback, so I'm hoping there are only nits left if anything. I will follow up on any comments.
mlir/lib/Conversion/ShapeToStandard/ShapeToStandard.cpp | ||
---|---|---|
228 | Right now this is enforced by checking that neither input is a Shape. I'm going to leave this to ease future find replace when this is changed because I copied this from Broadcast lowering in this file. |
If you want to enforce this, you can compare the types below to shape::getExtentTensorType.