The aim of this patch is to enable POSIX _l functions for z/OS. In particular, the functions are provided with libc++ and this patch resorts to the fallback functions. Nonetheless, the functions are being added so the implementation of the ctype<> member functions can call them. The following changes were needed to allow for a successful build when using the libc++ library for z/OS.
Details
Details
- Reviewers
abhina.sreeskantharajan Jonathan.Crowther EricWF howard.hinnant ldionne - Group Reviewers
Restricted Project - Commits
- rGe72e785d4707: [SystemZ][z/OS] Enable POSIX_l functions for z/OS
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Please quit removing libc++ as a reviewer. There's a reason why we add that group of reviewers. You won't check this in without the approval of someone in the group anyway.
libcxx/include/wchar.h | ||
---|---|---|
173 ↗ | (On Diff #301323) | Where are those defined for z/OS? I see definitions in src/solaris/support/mbsnrtowcs.inc and src/support/win32/support.cpp, but nothing that seems to be included when building for z/OS. Did I miss something? |
Comment Actions
Removed mbsnrtowcs and wcsnrtombs declarations from libcxx wchar.h. Adding those declarations to the system wchar.h instead.
libcxx/include/wchar.h | ||
---|---|---|
173 ↗ | (On Diff #301323) | Please see updated revision. Removed this change and added the declarations to the system wchar.h instead. |
libcxx/include/support/ibm/xlocale.h | ||
---|---|---|
21 | Wikipedia tells me that AIX 7.1 was released 10 years ago. Can we remove this AIX < 7.1 specific workaround? |
Wikipedia tells me that AIX 7.1 was released 10 years ago. Can we remove this AIX < 7.1 specific workaround?