- Factor out common elements of the input YAML document and use sed to macro replace the run line specific elements.
- Add checks for the common elements which depend on the ELF class.
- Use non-numeric suffix for temporary files to avoid merge conflicts.
- Sort tests by GFX# ascending.
- Group ELF and YAML tests by GFX#.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml | ||
---|---|---|
1 | Is using sed actually portable? |
llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml | ||
---|---|---|
1 | I wasn't certain, but it seems to be a de-facto requirement to run check-all: $ grep -r 'RUN:.* sed' llvm/test | wc -l 152 I made sure not to use any flags not already used in existing tests (i.e. I only use -e) |
llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml | ||
---|---|---|
145–156 | Put in gfx number order. |
Is using sed actually portable?