All known instances in the code where we relied upon the TypeSize
comparison operators have now been changed to either use scalar
integer comparisons or one of the TypeSize::isKnownXY functions.
It is now safe to remove the comparison operators.
Details
Details
Diff Detail
Diff Detail
Unit Tests
Unit Tests
Time | Test | |
---|---|---|
370 ms | linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp |
Event Timeline
Comment Actions
Is this the right way to go here? I've assumed we want to remove the operators, but perhaps they should be marked as deprecated and left in for a while first?
Comment Actions
LGTM
I don't think this is likely to significantly impact most out-of-tree users; no need to temporarily deprecate.