Page MenuHomePhabricator

[SVE] Remove TypeSize comparison operators
ClosedPublic

Authored by david-arm on Mon, Oct 26, 8:24 AM.

Details

Summary

All known instances in the code where we relied upon the TypeSize
comparison operators have now been changed to either use scalar
integer comparisons or one of the TypeSize::isKnownXY functions.
It is now safe to remove the comparison operators.

Diff Detail

Event Timeline

david-arm created this revision.Mon, Oct 26, 8:24 AM
Herald added a project: Restricted Project. · View Herald Transcript
david-arm requested review of this revision.Mon, Oct 26, 8:24 AM

Is this the right way to go here? I've assumed we want to remove the operators, but perhaps they should be marked as deprecated and left in for a while first?

efriedma accepted this revision.Tue, Oct 27, 1:43 PM

LGTM

I don't think this is likely to significantly impact most out-of-tree users; no need to temporarily deprecate.

This revision is now accepted and ready to land.Tue, Oct 27, 1:43 PM
This revision was landed with ongoing or failed builds.Thu, Oct 29, 7:32 AM
This revision was automatically updated to reflect the committed changes.