[clangd] Increase the TooMany limit for index-based textual navigation to 5

[nridge]

My experience using this feature in real codebases has been that we take this early-exit too often; the limit of 3 is fairly easy to hit due to things like layers of wrappers that repeat a function name. Bumping the limit to 5 has increased the usefulness for me.

[kadircet]

My experience using this feature in real codebases has been that we take this early-exit too often; the limit of 3 is fairly easy to hit due to things like layers of wrappers that repeat a function name. Bumping the limit to 5 has increased the usefulness for me.

What about counting number of different files, rather than number of symbols ?

[nridge]

In D90134#2352932, @kadircet wrote:

My experience using this feature in real codebases has been that we take this early-exit too often; the limit of 3 is fairly easy to hit due to things like layers of wrappers that repeat a function name. Bumping the limit to 5 has increased the usefulness for me.

What about counting number of different files, rather than number of symbols ?

If you mean counting the number of different files but keeping the limit at 3, I don't think that would change much; in my experience, you often have wrappers that repeat the same names in a different file than the functions they are wrapping.

clang-tools-extra/clangd/XRefs.cpp

if (Sym.Definition) {
       if (!MaybeDefLoc) {
         log("locateSymbolNamedTextuallyAt: {0}", MaybeDefLoc.takeError());
         return;
       }
       Located.PreferredDeclaration = *MaybeDefLoc;
       Located.Definition = *MaybeDefLoc;
     }
 
-    if (ScoredResults.size() >= 3) {
-      // If we have more than 3 results, don't return anything,
+    if (ScoredResults.size() >= 5) {
+      // If we have more than 5 results, don't return anything,
       // as confidence is too low.
       // FIXME: Alternatively, try a stricter query?
       TooMany = true;
       return;
     }
 
     SymbolQualitySignals Quality;
     Quality.merge(Sym);