[clang-tidy] Use --use-color in run-clang-tidy.py

[dsanders11]

Summary

Now that D79477 landed, it's a better user experience to use '--use-color' in run-clang-tidy.py and preserving the colored output.

[aaron.ballman]

This change LGTM, but please wait a few days in case @alexfh (or others) have concerns.

[dsanders11]

No one has raised any concerns, so if someone with commit access wants to commit this on my behalf it would be appreciated.. Thanks!

[aaron.ballman]

In D90110#2367596, @dsanders11 wrote:

No one has raised any concerns, so if someone with commit access wants to commit this on my behalf it would be appreciated.. Thanks!

I've commit on your behalf in a07a2c88d96cc48d7d381a0300565090c24b9770, thank you for the patch!

[• Toni]

Just a note for future changes: This change breaks parsers which relied on no colored input.

And how do we instruct run-clang-tidy.py to run clang-tidy without colors?

clang-tools-extra/clang-tidy/tool/run-clang-tidy.py

if os.path.isabs(f):
     return f
   return os.path.normpath(os.path.join(directory, f))
 
 
 def get_tidy_invocation(f, clang_tidy_binary, checks, tmpdir, build_path,
                         header_filter, allow_enabling_alpha_checkers,
                         extra_arg, extra_arg_before, quiet, config):
   """Gets a command line for clang-tidy."""
-  start = [clang_tidy_binary]
+  start = [clang_tidy_binary, '--use-color']
   if allow_enabling_alpha_checkers:
     start.append('-allow-enabling-analyzer-alpha-checkers')
   if header_filter is not None:
     start.append('-header-filter=' + header_filter)
   if checks:
     start.append('-checks=' + checks)
   if tmpdir is not None:
     start.append('-export-fixes')