Page MenuHomePhabricator

dsanders11 (David Sanders)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2020, 12:14 AM (5 w, 10 h)

Recent Activity

Sun, Nov 1

dsanders11 added a comment to D90110: [clang-tidy] Use --use-color in run-clang-tidy.py.

No one has raised any concerns, so if someone with commit access wants to commit this on my behalf it would be appreciated.. Thanks!

Sun, Nov 1, 11:39 PM · Restricted Project, Restricted Project

Sat, Oct 31

dsanders11 added a comment to D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows.

LGTM! Do you need someone to commit on your behalf?

Sat, Oct 31, 6:08 AM · Restricted Project, Restricted Project

Thu, Oct 29

dsanders11 added a comment to D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows.

Oh, how neat. The bug you linked to was closed as a dup of another bug. The other bug was then closed as something that's not in scope with the general product direction, whatever that means.

Thu, Oct 29, 2:23 PM · Restricted Project, Restricted Project
dsanders11 updated the diff for D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows.

code review changes

Thu, Oct 29, 2:17 PM · Restricted Project, Restricted Project

Oct 28 2020

dsanders11 added a comment to D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows.

What issues did you run into regarding testing, because I feel like the patch should have test coverage (esp given that color vs ANSI escape codes are a bit of an oddity to reason about)?

Oct 28 2020, 3:15 PM · Restricted Project, Restricted Project

Oct 24 2020

dsanders11 requested review of D90110: [clang-tidy] Use --use-color in run-clang-tidy.py.
Oct 24 2020, 5:36 PM · Restricted Project, Restricted Project
dsanders11 added a reviewer for D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows: alexfh.
Oct 24 2020, 5:35 PM · Restricted Project, Restricted Project
dsanders11 added a comment to D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows.

Added a few inline comments for clarification.

Oct 24 2020, 5:26 PM · Restricted Project, Restricted Project
dsanders11 requested review of D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows.
Oct 24 2020, 5:18 PM · Restricted Project, Restricted Project