- Still rough edges that need more sugar but the bones are there. Notes left in the test case for things that can be improved.
- Does not actually yield custom OpViews yet for traversing. Will rework that in a followup.
Nit: if the mapping already exists
Nit: "an the"
What is the convention for bool values? true = loaded, false = not found, no-value = not attempted?
Is this change intentional?
Can this ever contain false? If not, we rather want a StringSet<> for this.
Changed to StringSet.
Thanks from a previous iteration of the patch where I had to capture the module in the method, but since I've pulled this out to the PyGlobals now, it is unnecessary. Reverted.
Thanks. Originally was mapping to the module, removed the mapped value and should have dropped it back to a set then. Done.