This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Fix copy-pasted docstrings in Python bindings
ClosedPublic

Authored by ftynse on Oct 20 2020, 2:22 AM.

Details

Summary

Docstrings for __str__ method in many classes was recycling the constant
string defined for Type, without being types themselves. Use proper
docstrings instead. Since they are succint, use string literals instead of
top-level constants to avoid further mistakes.

Depends On D89779

Diff Detail

Event Timeline

ftynse created this revision.Oct 20 2020, 2:22 AM
ftynse requested review of this revision.Oct 20 2020, 2:22 AM
stellaraccident accepted this revision.Oct 20 2020, 9:31 AM

Thanks. Believe it or not, I actually read the generic one as correct, thinking 'type' referred to the python class it was attached to. In any case, this is an improvement.

This revision is now accepted and ready to land.Oct 20 2020, 9:31 AM
This revision was landed with ongoing or failed builds.Oct 21 2020, 12:53 AM
This revision was automatically updated to reflect the committed changes.