This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Use the correct base class for Attributes in Python bindings
ClosedPublic

Authored by ftynse on Oct 20 2020, 2:22 AM.

Details

Summary

The pybind class typedef for concrete attribute classes was erroneously
deriving all of them from PyAttribute instead of the provided base class. This
has not been triggering any error because only one level of the hierarchy is
currently exposed.

Depends On D89778

Diff Detail

Event Timeline

ftynse created this revision.Oct 20 2020, 2:22 AM
ftynse requested review of this revision.Oct 20 2020, 2:22 AM
stellaraccident accepted this revision.Oct 20 2020, 9:34 AM

Thanks - missed this in the previous fix to the type hierarchy.

This revision is now accepted and ready to land.Oct 20 2020, 9:34 AM
This revision was landed with ongoing or failed builds.Oct 21 2020, 12:52 AM
This revision was automatically updated to reflect the committed changes.