This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Do not generate S_CMP_LG_U64 on gfx7
ClosedPublic

Authored by piotr on Oct 16 2020, 3:40 AM.

Details

Summary

S_CMP_LG_U64 was added in gfx8 and is guarded by hasScalarCompareEq64().

Rewrite S_CMP_LG_U64 to S_OR_B32 + S_CMP_LG_U32 for targets that
do not support 64-bit scalar compare.

Diff Detail

Event Timeline

piotr created this revision.Oct 16 2020, 3:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 16 2020, 3:40 AM
piotr requested review of this revision.Oct 16 2020, 3:40 AM
arsenm accepted this revision.Oct 16 2020, 6:41 AM

I don't see why this is emitting this compare in the first place, but this is just doing the same thing that's already done here

This revision is now accepted and ready to land.Oct 16 2020, 6:41 AM
This revision was landed with ongoing or failed builds.Oct 19 2020, 5:45 AM
This revision was automatically updated to reflect the committed changes.