Update clang/lib/StaticAnalyzer to stop relying on a MemoryBuffer*, using the MemoryBufferRef from getBufferOrNone or the Optional<MemoryBufferRef> from getBufferOrFake, depending on whether there's logic for checking validity of the buffer. The change to clang/lib/StaticAnalyzer/Core/IssueHash.cpp is potentially a functionality change, since the logic was wrong (it checked for nullptr, which was never returned by the old API), but if that was reachable the new behaviour should be better.
dexonsmith added parent revisions: D89280: Support: Allow use of MemoryBufferRef with line_iterator, D89348: clang/Basic: Replace ContentCache::getBuffer with Optional semantics.
dexonsmith added a child revision: D66782: SourceManager: Prefer Optional<MemoryBufferRef> over MemoryBuffer*.
Closed by commit rGaf4fb416bd35: clang/StaticAnalyzer: Stop using SourceManager::getBuffer (authored by dexonsmith). · Explain WhyOct 14 2020, 9:34 PM
This revision was automatically updated to reflect the committed changes.