This is an archive of the discontinued LLVM Phabricator instance.

Differential D89275

[mlir] Fix sporadic build failures due to missing dependency
ClosedPublic

Authored by stella.stamenova on Oct 12 2020, 2:57 PM.

Details

Reviewers
NathanielMcVicar
ftynse
jdoerfert
mehdi_amini
Commits
rG0c15a1b4bcef: [mlir] Fix sporadic build failures due to missing dependency
Summary

The build of MLIR occasionally fails (especially on Windows) because there is missing dependency between MLIRLLVMIR and MLIROpenMPOpsIncGen.

  1. LLVMDialect.cpp includes LLVMDialect.h
  2. LLVMDialect.h includes OpenMPDialect.h
  3. OpenMPDialect.h includes OpenMPOpsDialect.h.inc, OpenMPOpsEnums.h.inc and OpenMPOps.h.inc

The OpenMP .inc files are generated by MLIROpenMPOpsIncGen, so MLIRLLVMIR which builds LLVMDialect.cpp should depend on MLIROpenMPOpsIncGen

Diff Detail

Event Timeline

stella.stamenova created this revision.Oct 12 2020, 2:57 PM
Herald added a reviewer: ftynse. · View Herald TranscriptOct 12 2020, 2:58 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: rdzhabarov, tatianashp, msifontes and 14 others. · View Herald Transcript
stella.stamenova requested review of this revision.Oct 12 2020, 2:58 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptOct 12 2020, 2:58 PM
Herald added subscribers: sstefan1, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
stella.stamenova edited the summary of this revision. (Show Details)Oct 12 2020, 2:58 PM
Harbormaster completed remote builds in B74861: Diff 297699.Oct 12 2020, 3:16 PM
mehdi_amini accepted this revision.Oct 12 2020, 5:47 PM
This revision is now accepted and ready to land.Oct 12 2020, 5:47 PM
Closed by commit rG0c15a1b4bcef: [mlir] Fix sporadic build failures due to missing dependency (authored by stella.stamenova). · Explain WhyOct 13 2020, 9:55 AM
This revision was automatically updated to reflect the committed changes.
stella.stamenova added a commit: rG0c15a1b4bcef: [mlir] Fix sporadic build failures due to missing dependency.

Revision Contents

PathSize
mlir/
lib/
Dialect/
LLVMIR/
1 line

Diff 297896

mlir/lib/Dialect/LLVMIR/CMakeLists.txt

add_subdirectory(Transforms) add_subdirectory(Transforms)
add_mlir_dialect_library(MLIRLLVMIR add_mlir_dialect_library(MLIRLLVMIR
IR/LLVMDialect.cpp IR/LLVMDialect.cpp
IR/LLVMTypes.cpp IR/LLVMTypes.cpp
IR/LLVMTypeSyntax.cpp IR/LLVMTypeSyntax.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/LLVMIR ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/LLVMIR
DEPENDS DEPENDS
MLIRLLVMOpsIncGen MLIRLLVMOpsIncGen
MLIRLLVMConversionsIncGen MLIRLLVMConversionsIncGen
MLIROpenMPOpsIncGen
intrinsics_gen intrinsics_gen
LINK_COMPONENTS LINK_COMPONENTS
AsmParser AsmParser
BitReader BitReader
BitWriter BitWriter
Core Core
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines