Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Time | Test | |
---|---|---|
40 ms | linux > MLIR.Dialect/GPU::invalid.mlir Script:
--
: 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/mlir-opt -split-input-file -verify-diagnostics /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/GPU/invalid.mlir
| |
10 ms | linux > MLIR.Dialect/GPU::ops.mlir Script:
--
: 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/mlir-opt -allow-unregistered-dialect /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/GPU/ops.mlir | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/GPU/ops.mlir
| |
130 ms | linux > MLIR.Dialect/GPU::outlining.mlir Script:
--
: 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/mlir-opt -allow-unregistered-dialect -gpu-kernel-outlining -split-input-file -verify-diagnostics /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/GPU/outlining.mlir | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/GPU/outlining.mlir
| |
60 ms | windows > MLIR.Dialect/GPU::invalid.mlir Script:
--
: 'RUN: at line 1'; c:\ws\w16-1\llvm-project\premerge-checks\build\bin\mlir-opt.exe -split-input-file -verify-diagnostics C:\ws\w16-1\llvm-project\premerge-checks\mlir\test\Dialect\GPU\invalid.mlir
| |
50 ms | windows > MLIR.Dialect/GPU::ops.mlir Script:
--
: 'RUN: at line 1'; c:\ws\w16-1\llvm-project\premerge-checks\build\bin\mlir-opt.exe -allow-unregistered-dialect C:\ws\w16-1\llvm-project\premerge-checks\mlir\test\Dialect\GPU\ops.mlir | c:\ws\w16-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16-1\llvm-project\premerge-checks\mlir\test\Dialect\GPU\ops.mlir
| |
View Full Test Results (6 Failed) |
Event Timeline
I like this updated syntax. @ftynse WDYT?
mlir/include/mlir/Dialect/GPU/GPUOps.td | ||
---|---|---|
410 | The custom<Space> is ugly but I see its motivation. Maybe file a bug to add support for explicit whitespace to the assembly format? | |
mlir/lib/Dialect/GPU/IR/GPUDialect.cpp | ||
505 | I'd prefer to expose the parsing of just the argument list instead of parsing a result type and then failing. |
mlir/include/mlir/Dialect/GPU/GPUOps.td | ||
---|---|---|
410 | Alternatively I could custom-parse/print the grid in or even with the operands. That would look less ugly, but it's a little less expressive. |
mlir/include/mlir/Dialect/GPU/GPUOps.td | ||
---|---|---|
410 | Switched to space literal. |
Thanks. Just some nits.
mlir/include/mlir/Dialect/GPU/GPUOps.td | ||
---|---|---|
366 | Can you update the example, too? | |
mlir/include/mlir/IR/FunctionImplementation.h | ||
61 ↗ | (On Diff #299102) | You could add an option here whether it may have attributes, like allowAttributes or something and then parsing would just fail with a parse error. |
mlir/lib/Dialect/GPU/IR/GPUDialect.cpp | ||
487 | Nit: This could be in the assemblyFormat |
Apply reviewer comments.
mlir/lib/Dialect/GPU/IR/GPUDialect.cpp | ||
---|---|---|
487 | The args(...) is optional, and I don't think custom<> inside an optional group is supported. I left it as is. |