This is an archive of the discontinued LLVM Phabricator instance.

Differential D88990

Update documentation on stage3 cmake build
ClosedPublic

Authored by serge-sans-paille on Oct 7 2020, 11:01 AM.

Details

Reviewers
beanz
sylvestre.ledru
tbaeder
Commits
rGb4ffc40d622b: Update documentation and implementation of stage3 build
Summary

Have the build work out of the box by forcing an LLD build. That way, we don't require an external LTO-aware linker, as we build one.
Also remove reference to the seemingly dead builder.

Diff Detail

Event Timeline

serge-sans-paille created this revision.Oct 7 2020, 11:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2020, 11:01 AM
Herald added subscribers: llvm-commits, dexonsmith, mgorny. · View Herald Transcript
serge-sans-paille requested review of this revision.Oct 7 2020, 11:01 AM
serge-sans-paille added reviewers: sylvestre.ledru, tbaeder.
sylvestre.ledru accepted this revision.Oct 7 2020, 11:04 AM
This revision is now accepted and ready to land.Oct 7 2020, 11:04 AM
beanz requested changes to this revision.Oct 7 2020, 11:11 AM

Using lld on Darwin isn't ideal, the system linker is desirable there.

This revision now requires changes to proceed.Oct 7 2020, 11:11 AM
serge-sans-paille added a comment.Oct 7 2020, 11:46 AM
In D88990#2317447, @beanz wrote:

Using lld on Darwin isn't ideal, the system linker is desirable there.

What about making it the default on Linux and Windows?

beanz added a comment.Oct 7 2020, 12:07 PM
In D88990#2317562, @serge-sans-paille wrote:
In D88990#2317447, @beanz wrote:

Using lld on Darwin isn't ideal, the system linker is desirable there.

What about making it the default on Linux and Windows?

That would be reasonable.

serge-sans-paille updated this revision to Diff 296773.Oct 7 2020, 12:39 PM

APPLE-specific setting wrt linker

beanz accepted this revision.Oct 7 2020, 12:45 PM

LGTM

This revision is now accepted and ready to land.Oct 7 2020, 12:45 PM
Closed by commit rGb4ffc40d622b: Update documentation and implementation of stage3 build (authored by serge-sans-paille). · Explain WhyOct 7 2020, 10:55 PM
This revision was automatically updated to reflect the committed changes.
serge-sans-paille added a commit: rGb4ffc40d622b: Update documentation and implementation of stage3 build.
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2020, 10:55 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aidengrossman mentioned this in rG1a83865b786c: [Docs] Minor Fixups in Advanced Builds Documentation.May 13 2023, 3:47 PM

Revision Contents

PathSize
clang/
cmake/
caches/
9 lines
llvm/
docs/
6 lines

Diff 296773

clang/cmake/caches/3-stage-base.cmake

set(CMAKE_BUILD_TYPE RELEASE CACHE STRING "") set(CMAKE_BUILD_TYPE RELEASE CACHE STRING "")
set(CLANG_ENABLE_BOOTSTRAP ON CACHE BOOL "") set(CLANG_ENABLE_BOOTSTRAP ON CACHE BOOL "")
set(LLVM_BUILD_EXTERNAL_COMPILER_RT ON CACHE BOOL "") set(LLVM_BUILD_EXTERNAL_COMPILER_RT ON CACHE BOOL "")
set(BOOTSTRAP_LLVM_ENABLE_LTO ON CACHE BOOL "") set(BOOTSTRAP_LLVM_ENABLE_LTO ON CACHE BOOL "")
# Use LLD do have less requirements on system linker, unless we're on an apple
# platform where the system compiler is to be prefered.
if(APPLE)
set(BOOTSTRAP_LLVM_ENABLE_LLD OFF CACHE BOOL "")
else()
set(BOOTSTRAP_LLVM_ENABLE_LLD ON CACHE BOOL "")
endif()
set(CLANG_BOOTSTRAP_TARGETS set(CLANG_BOOTSTRAP_TARGETS
clang clang
check-all check-all
check-llvm check-llvm
check-clang check-clang
test-suite CACHE STRING "") test-suite CACHE STRING "")
set(CLANG_BOOTSTRAP_CMAKE_ARGS set(CLANG_BOOTSTRAP_CMAKE_ARGS
-C ${CMAKE_CURRENT_LIST_DIR}/3-stage-base.cmake -C ${CMAKE_CURRENT_LIST_DIR}/3-stage-base.cmake
CACHE STRING "") CACHE STRING "")

llvm/docs/AdvancedBuilds.rst

Show First 20 Lines • Show All 180 Lines • ▼ Show 20 Lines
identical. identical.
You can perform one of these 3-stage builds with LLVM & clang using the You can perform one of these 3-stage builds with LLVM & clang using the
following commands: following commands:
.. code-block:: console .. code-block:: console
$ cmake -G Ninja -C <path_to_clang>/cmake/caches/3-stage.cmake <source dir> $ cmake -G Ninja -C <path_to_clang>/cmake/caches/3-stage.cmake <source dir>
$ ninja stage3 $ cmake --build . --target stage3 --parallel
After the build you can compare the stage2 & stage3 compilers. We have a bot After the build you can compare the stage2 & stage3 compilers.
setup `here <http://lab.llvm.org:8011/builders/clang-3stage-ubuntu>`_ that runs
this build and compare configuration.